Skip to contentSkip to conversation

Add lcdproc config options, for driver selection

PATCH New spdawson at gmail.com 2 participants 2 messages Apr 11, 2012

lore
Share & tools
lore

spdawson at gmail.com

author
#0 lore raw

PATCH 1/1 Add lcdproc config options, for driver selection

Add a configuration menu item to specify a list of lcdproc drivers to be built. The list defaults to 'all'.

Signed-off-by Simon Dawson <[email protected]>
---
 package/lcdproc/Config.in  |    7 +++++++
 package/lcdproc/lcdproc.mk |    2 +-
 2 files changed, 8 insertions(+), 1 deletions(-)
package/lcdproc/Config.in +7 -0
index 6c8614d..70a2078 100644
@@ -5,3 +5,10 @@ config BR2_PACKAGE_LCDPROC
          LCD display driver daemon and clients
 
          http://lcdproc.org/
+
+config BR2_PACKAGE_LCDPROC_DRIVERS
+	string "List of drivers to build"
+	default "all"
+	help
+	  Specify a comma-separated list of lcdproc drivers to be built
+	depends on BR2_PACKAGE_LCDPROC
package/lcdproc/lcdproc.mk +1 -1
index e8919e9..745b386 100644
@@ -7,7 +7,7 @@ LCDPROC_VERSION = 0.5.5
 LCDPROC_SOURCE = lcdproc-$(LCDPROC_VERSION).tar.gz
 LCDPROC_SITE = http://$(BR2_SOURCEFORGE_MIRROR).dl.sourceforge.net/project/lcdproc/lcdproc/$(LCDPROC_VERSION)
 
-LCDPROC_CONF_OPT = --enable-drivers=all
+LCDPROC_CONF_OPT = --enable-drivers=$(BR2_PACKAGE_LCDPROC_DRIVERS)
 
 LCDPROC_DEPENDENCIES = ncurses
Signature · 1 line
1.7.5.4
#1 lore raw

PATCH 1/1 Add lcdproc config options, for driver selection

Hello,

Le Wed, 11 Apr 2012 12:31:30 +0100,
spdawson at gmail.com a ?crit :

Quoted 2 lines

Add a configuration menu item to specify a list of lcdproc drivers to be built. The list defaults to 'all'.

Ok, I told you to wait for others comments on whether we should have the full list (as you did initially) or this solution. I didn't want to waste your time on this. Some comments below, though.

package/lcdproc/Config.in config BR2_PACKAGE_LCDPROC · line 14

Quoted 6 lines
package/lcdproc/Config.in +6 -0
+config BR2_PACKAGE_LCDPROC_DRIVERS
+	string "List of drivers to build"
+	default "all"
+	help
+	  Specify a comma-separated list of lcdproc drivers to be built
+	depends on BR2_PACKAGE_LCDPROC

The depends on should be before the help text. It's not mandatory by the kconfig syntax, but that's the way we use kconfig everywhere in Buildroot.

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com