usb: gadget: add a sparse endian notation
Subsystems (2)
PATCH 1/1 usb: gadget: add a sparse endian notation
The original code works fine, but Sparse complains because it isn't annotated properly.
drivers/usb/gadget/composite.c:793:26: warning: incorrect type in assignment (different base types)drivers/usb/gadget/composite.c:793:26: expected unsigned short [unsigned] [usertype] languagedevel/drivers/usb/gadget/composite.c:793:26: got restricted __le16 [usertype] <noident>devel/drivers/usb/gadget/composite.c:795:29: warning: restricted __le16 degrades to integer drivers/usb/gadget/composite.c:798:24: warning: incorrect type in assignment (different base types)drivers/usb/gadget/composite.c:798:24: expected restricted __le16 [usertype] <noident>devel/drivers/usb/gadget/composite.c:798:24: got unsigned short [unsigned] [usertype] language
drivers/usb/gadget/composite.c +1 -1
@@ -785,7 +785,7 @@ done:static void collect_langs (struct usb_gadget_strings **sp,__le16 *buf) {const struct usb_gadget_strings *s; -u16 language; +__le16 language;__le16 *tmp;while (*sp) {
Felipe Balbi
AppliedQuoted 11 lines · Dan Carpenter
The original code works fine, but Sparse complains because it isn't annotated properly.
drivers/usb/gadget/composite.c:793:26: warning: incorrect type in assignment (different base types)drivers/usb/gadget/composite.c:793:26: expected unsigned short [unsigned] [usertype] languagedevel/drivers/usb/gadget/composite.c:793:26: got restricted__le16[usertype] <noident>devel/drivers/usb/gadget/composite.c:795:29: warning: restricted__le16degrades to integerdrivers/usb/gadget/composite.c:798:24: warning: incorrect type in assignment (different base types)drivers/usb/gadget/composite.c:798:24: expected restricted__le16[usertype] <noident>devel/drivers/usb/gadget/composite.c:798:24: got unsigned short [unsigned] [usertype] language
Quoted 1 line
Signed-off-by Dan Carpenter <[email protected]>
applied, thanks.
Signature · 1 line
balbi