net/ipv4:Remove two memleak reports by kmemeleak_not_leak.

PATCH In review majianpeng 3 participants 3 messages Apr 17, 2012 – Apr 18, 2012

Subsystems (3)

Networking Network drivers IPv4/IPv6

lore

Share & tools

lore

majianpeng

author

2012-04-17 05:32 UTC #0 lore raw

PATCH 1/1 net/ipv4:Remove two memleak reports by kmemeleak_not_leak.

Quoted 1 line

From fe9ae7e12cc7bdc56705eb504facb71aa86dfe65 Mon Sep 17 00:00:00 2001

From: majianpeng <[email protected]>
Date: Tue, 17 Apr 2012 13:29:55 +0800
Subject: [PATCH] net/ipv4:Remove two memleak reports by kmemeleak_not_leak.

Signed-off-by majianpeng <[email protected]>

---
 net/ipv4/route.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

net/ipv4/route.c +1 -1

index 167ea10..dd15648 100644
@@ -3505,6 +3505,6 @@ int __init ip_rt_init(void)
  */
 void __init ip_static_sysctl_init(void)
 {
-	register_sysctl_paths(ipv4_path, ipv4_skeleton);
+	kmemleak_not_leak(register_sysctl_paths(ipv4_path, ipv4_skeleton));
 }
 #endif

Signature · 6 lines

1.7.5.4

 				
--------------
majianpeng
2012-04-17

Eric Dumazet

Acked-by on v1 1/1

2012-04-17 05:34 UTC #1 lore raw

Quoted 16 lines · majianpeng

From fe9ae7e12cc7bdc56705eb504facb71aa86dfe65 Mon Sep 17 00:00:00 2001
From: majianpeng <[email protected]>
Date: Tue, 17 Apr 2012 13:29:55 +0800
Subject: [PATCH] net/ipv4:Remove two memleak reports by kmemeleak_not_leak.
Signed-off-by majianpeng <[email protected]>
---
 net/ipv4/route.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
net/ipv4/route.c +0 -0
index 167ea10..dd15648 100644

net/ipv4/route.c int __init ip_rt_init(void) · line 3510

Quoted 7 lines

net/ipv4/route.c +1 -1

@@ -3505,6 +3505,6 @@ int __init ip_rt_init(void)
  */
 void __init ip_static_sysctl_init(void)
 {
-	register_sysctl_paths(ipv4_path, ipv4_skeleton);
+	kmemleak_not_leak(register_sysctl_paths(ipv4_path, ipv4_skeleton));
 }
 #endif

Acked-by Eric Dumazet <[email protected]>

Thanks

David Miller

maintainer

2012-04-18 04:22 UTC #2 lore raw

In reply to majianpeng

From: "majianpeng" <[email protected]>
Date: Tue, 17 Apr 2012 13:33:31 +0800

Quoted 7 lines

Quoted 1 line
From fe9ae7e12cc7bdc56705eb504facb71aa86dfe65 Mon Sep 17 00:00:00 2001
From: majianpeng <[email protected]>
Date: Tue, 17 Apr 2012 13:29:55 +0800
Subject: [PATCH] net/ipv4:Remove two memleak reports by kmemeleak_not_leak.
Signed-off-by majianpeng <[email protected]>

I've applied both of your patches, but you are EXTREMELY careless with your commit log messages and subject lines.

In this patch, and the net/core one, you misspell "kmemleak_not_leak"

In the net/core patch, you failed to separate "by" and "kmemleak_not_leak" with a space in the Subject line.

Furthermore, it is extraneous to include the same From:, Date:, and
Subject: fields in the body of your email. They are just fine in your normal email headers.

Thanks.