Skip to contentSkip to conversation

mmc: Fix warning if CONFIG_MMC_TRACE is enabled

PATCH New Dirk Behme 4 participants 6 messages Mar 8, 2012 – Apr 21, 2012 MMC, SD and SDIO

lore
Share & tools
lore

Dirk Behme

author
#0 lore raw

PATCH 1/1 mmc: Fix warning if CONFIG_MMC_TRACE is enabled

Fix the warning

mmc.c: In function 'mmc_send_cmd':
mmc.c:87: warning: assignment from incompatible pointer type

in case CONFIG_MMC_TRACE is enabled.

---
 drivers/mmc/mmc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/mmc/mmc.c +1 -1
index 21665ec..881b5c0 100644
@@ -84,7 +84,7 @@ int mmc_send_cmd(struct mmc *mmc, struct mmc_cmd *cmd, struct mmc_data *data)
 			for (i = 0; i < 4; i++) {
 				int j;
 				printf("\t\t\t\t\t%03d - ", i*4);
-				ptr = &cmd->response[i];
+				ptr = (u8 *)&cmd->response[i];
 				ptr += 3;
 				for (j = 0; j < 4; j++)
 					printf("%02X ", *ptr--);
Signature · 1 line
1.7.0.4
#1 lore raw

PATCH 1/1 mmc: Fix warning if CONFIG_MMC_TRACE is enabled

Quoted 9 lines · Dirk Behme

Fix the warning

mmc.c: In function 'mmc_send_cmd':
mmc.c:87: warning: assignment from incompatible pointer type

in case CONFIG_MMC_TRACE is enabled.

Quoted 24 lines

---
?drivers/mmc/mmc.c | ? ?2 +-
?1 files changed, 1 insertions(+), 1 deletions(-)

drivers/mmc/mmc.c +1 -2
index 21665ec..881b5c0 100644
@@ -84,7 +84,7 @@ int mmc_send_cmd(struct mmc *mmc, struct mmc_cmd *cmd, struct mmc_data *data)
 ? ? ? ? ? ? ? ? ? ? ? ?for (i = 0; i < 4; i++) {
 ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?int j;
 ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?printf("\t\t\t\t\t%03d - ", i*4);
- ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ptr = &cmd->response[i];
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ptr = (u8 *)&cmd->response[i];
 ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?ptr += 3;
 ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?for (j = 0; j < 4; j++)
 ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?printf("%02X ", *ptr--);
--

1.7.0.4

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

#2 lore raw

PATCH 1/1 mmc: Fix warning if CONFIG_MMC_TRACE is enabled

In reply to Dirk Behme

Dear Dirk Behme,

Quoted 10 lines

Fix the warning

mmc.c: In function 'mmc_send_cmd':
mmc.c:87: warning: assignment from incompatible pointer type

in case CONFIG_MMC_TRACE is enabled.

---

Quoted 8 lines
 drivers/mmc/mmc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/mmc/mmc.c +0 -0
index 21665ec..881b5c0 100644

drivers/mmc/mmc.c int mmc_send_cmd(struct mmc *mmc, struct mmc_cmd *cmd, · line 90

Quoted 8 lines
drivers/mmc/mmc.c +1 -1
@@ -84,7 +84,7 @@ int mmc_send_cmd(struct mmc *mmc, struct mmc_cmd *cmd,
 struct mmc_data *data) for (i = 0; i < 4; i++) {
 				int j;
 				printf("\t\t\t\t\t%03d - ", i*4);
-				ptr = &cmd->response[i];
+				ptr = (u8 *)&cmd->response[i];
 				ptr += 3;
 				for (j = 0; j < 4; j++)
 					printf("%02X ", *ptr--);

Best regards,
Marek Vasut

author
#3 lore raw

PATCH 1/1 mmc: Fix warning if CONFIG_MMC_TRACE is enabled

Quoted 19 lines · Marek Vasut

Dear Dirk Behme,

Quoted 10 lines

Fix the warning

mmc.c: In function 'mmc_send_cmd':
mmc.c:87: warning: assignment from incompatible pointer type

in case CONFIG_MMC_TRACE is enabled.

---

Quoted 3 lines
 drivers/mmc/mmc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Quoted 13 lines

drivers/mmc/mmc.c int mmc_send_cmd(struct mmc *mmc, struct mmc_cmd *cmd, · line 90

Quoted 13 lines
drivers/mmc/mmc.c +1 -1
index 21665ec..881b5c0 100644
@@ -84,7 +84,7 @@ int mmc_send_cmd(struct mmc *mmc, struct mmc_cmd *cmd,
 struct mmc_data *data) for (i = 0; i < 4; i++) {
 				int j;
 				printf("\t\t\t\t\t%03d - ", i*4);
-				ptr = &cmd->response[i];
+				ptr = (u8 *)&cmd->response[i];
 				ptr += 3;
 				for (j = 0; j < 4; j++)
 					printf("%02X ", *ptr--);

Who could help to still get this into 2012.04?

Many thanks,

Dirk

#4 lore raw

PATCH 1/1 mmc: Fix warning if CONFIG_MMC_TRACE is enabled

Dear Dirk Behme,

Quoted 5 lines · Marek Vasut
Quoted 4 lines

Dear Dirk Behme,

Quoted 2 lines

Fix the warning

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines

mmc.c: In function 'mmc_send_cmd':
mmc.c:87: warning: assignment from incompatible pointer type

in case CONFIG_MMC_TRACE is enabled.

I'd be glad to see it in ... Andy?

Quoted 25 lines
Quoted 25 lines
Quoted 1 line

---

Quoted 19 lines
 drivers/mmc/mmc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/mmc/mmc.c +1 -1
index 21665ec..881b5c0 100644
@@ -84,7 +84,7 @@ int mmc_send_cmd(struct mmc *mmc, struct mmc_cmd *cmd,
 struct mmc_data *data) for (i = 0; i < 4; i++) {
 
 				int j;
 				printf("\t\t\t\t\t%03d - ", i*4);
 
-				ptr = &cmd->response[i];
+				ptr = (u8 *)&cmd->response[i];
 
drivers/mmc/mmc.c +0 -0
 				ptr += 3;
 				for (j = 0; j < 4; j++)
Quoted 7 lines
Quoted 1 line
Quoted 1 line

printf("%02X ", *ptr--);

Who could help to still get this into 2012.04?

Many thanks,

Dirk

Best regards,
Marek Vasut

#5 lore raw

PATCH 1/1 mmc: Fix warning if CONFIG_MMC_TRACE is enabled

In reply to Dirk Behme

Dear Dirk Behme,

Quoted 5 lines · In message <[email protected]> you…

Fix the warning

mmc.c: In function 'mmc_send_cmd':
mmc.c:87: warning: assignment from incompatible pointer type

Quoted 7 lines

in case CONFIG_MMC_TRACE is enabled.

---
 drivers/mmc/mmc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

Signature · 8 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Science makes godlike -- it is all over with priests and  gods  when
man becomes scientific. Moral: science is the forbidden as such -- it
alone  is  forbidden. Science is the *first* sin, the *original* sin.
*This alone is  morality.*  ``Thou  shalt  not  know''  --  the  rest
follows."                                       - Friedrich Nietzsche