mount.cifs.c toggle_dac_capability() stores return code

Hello again,

the build process of the cifs-utils for Mandriva 2011 made me notice of the unused variable rc in toggle_dac_capability() of mount.cifs.c.

A bit up in the code we store the return value and do not make use of it while calling return.

The attached patch intends to fix this.

The failing build result is still visible at
https://build.opensuse.org/package/live_build_log?arch=x86_64&package=cifs-utils&project=network%3Asamba%3ASTABLE&repository=Mandriva_2011

Cheers,

Lars

Lars Müller [ˈlaː(r)z ˈmʏlɐ]
Samba Team + SUSE Labs
SUSE Linux, Maxfeldstraße 5, 90409 Nürnberg, Germany

Author: Lars Mueller <lmuelle-IBi9RG/[email protected]>
Subject: cifs-utils don't make use of stored return code
Bugzilla: na
Upstream-Reported: http://permalink.gmane.org/gmane.linux.kernel.cifs/5935
Upstream-Acknowledged: Yes

Index: cifs-utils-5.4/mount.cifs.c
===================================================================
@@ -577,7 +577,7 @@ toggle_dac_capability(int writable, int
 	}
 free_caps:
 	cap_free(caps);
-	return 0;
+	return rc;
 }
 #else /* HAVE_LIBCAP */
 static int

ACK. Good catch.

Jeff Layton <[email protected]>