Skip to contentSkip to conversation

Fixed atleast coding style issues relating spaces

PATCH In review Jeffrin Jose 2 participants 2 messages Apr 21, 2012 Sound

lore
Share & tools
lore

Jeffrin Jose

author
#0 lore raw

PATCH 1/1 Fixed atleast coding style issues relating spaces

hello

I have fixed atleast coding style issues relating spaces in file sound/usb/card.c

Please see attachment.

/Jeffrin

Signature · 4 lines
software engineer
Bohr Lab
department of computer science
Rajagiri school of engineering and technology.
Quoted 1 line

From 62fffec818ecc3df83f6c6a274512ab85579dfde Mon Sep 17 00:00:00 2001

From: Jeffrin Jose <[email protected]>
Date: Sun, 22 Apr 2012 02:31:38 +0530
Subject: [PATCH 7/7] sound:Fixed atleast coding style issue relating spaces.

Fixed atleast coding style issues relating spaces in the file sound/usb/card.c

Signed-off-by Jeffrin Jose <[email protected]>
---
 sound/usb/card.c |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)
sound/usb/card.c +5 -5
index 4a7be7b..b664eb8 100644
@@ -186,7 +186,7 @@ static int snd_usb_create_stream(struct snd_usb_audio *chip, int ctrlif, int int
 		return -EINVAL;
 	}
 
-	if (! snd_usb_parse_audio_interface(chip, interface)) {
+	if (!snd_usb_parse_audio_interface(chip, interface)) {
 		usb_set_interface(dev, interface, 0); /* reset the current interface */
 		usb_driver_claim_interface(&usb_audio_driver, iface, (void *)-1L);
 		return -EINVAL;

@@ -331,7 +331,7 @@ static int snd_usb_audio_create(struct usb_device *dev, int idx,
 	}
 
 	chip = kzalloc(sizeof(*chip), GFP_KERNEL);
-	if (! chip) {
+	if (!chip) {
 		snd_card_free(card);
 		return -ENOMEM;
 	}

@@ -474,12 +474,12 @@ snd_usb_audio_probe(struct usb_device *dev,
 			break;
 		}
 	}
-	if (! chip) {
+	if (!chip) {
 		/* it's a fresh one.
 		 * now look for an empty slot and create a new card instance
 		 */
 		for (i = 0; i < SNDRV_CARDS; i++)
-			if (enable[i] && ! usb_chip[i] &&
+			if (enable[i] && !usb_chip[i] &&
 			    (vid[i] == -1 || vid[i] == USB_ID_VENDOR(id)) &&
 			    (pid[i] == -1 || pid[i] == USB_ID_PRODUCT(id))) {
 				if (snd_usb_audio_create(dev, i, quirk, &chip) < 0) {

@@ -687,7 +687,7 @@ err_out:
 #define usb_audio_resume	NULL
 #endif		/* CONFIG_PM */
 
-static struct usb_device_id usb_audio_ids [] = {
+static struct usb_device_id usb_audio_ids[] = {
 #include "quirks-table.h"
     { .match_flags = (USB_DEVICE_ID_MATCH_INT_CLASS | USB_DEVICE_ID_MATCH_INT_SUBCLASS),
       .bInterfaceClass = USB_CLASS_AUDIO,
Signature · 1 line
1.7.9
Acked-by on v1 1/1
#1 lore raw
Quoted 7 lines · Jeffrin Jose

hello

I have fixed atleast coding style issues relating
spaces in file sound/usb/card.c

Please see attachment.

ok, So I took a quick look at the patch and I think it looks fine. So as far as that goes, feel free to add

Acked-by Jesper Juhl <[email protected]>

but you really should try to send patches inline rather than as attachments. Attachments are a pain when you want to reply and quote and comment on the patch.

As far as the mail (patch) subject goes, I also feel a need to comment; what's up with "atleast"? Shouldn't it just be
"Fixed coding style issues relating to spaces" ??

Anyway, the actual change looks good to me.

Signature · 3 lines
Jesper Juhl <[email protected]>       http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.