modpost: use proper kernel style for autogenerated files
PATCH 1/1 modpost: use proper kernel style for autogenerated files
If the kernel build process is creating files automatically, the least it can do is create them in a properly formatted manner. Sure, it's a minor issue, but being consistent is nice.
Cc Rusty Russell <[email protected]>
Cc Alessio Igor Bogani <[email protected]>
Cc Tony Lindgren <[email protected]>
Cc Ben Hutchings <[email protected]>
Cc Russell King <[email protected]>
Signed-off-by Greg Kroah-Hartman <[email protected]>
scripts/mod/modpost.c +4 -4
@@ -1850,14 +1850,14 @@ static void add_header(struct buffer *b, struct module *mod)buf_printf (b,"\n" );buf_printf (b,"struct module __this_module\n" );buf_printf (b,"__attribute__((section(\".gnu.linkonce.this_module\"))) = {\n" ); -buf_printf (b," .name = KBUILD_MODNAME,\n" ); +buf_printf (b,"\t.name = KBUILD_MODNAME,\n" );if (mod->has_init) -buf_printf (b," .init = init_module,\n" ); +buf_printf (b,"\t.init = init_module,\n" );if (mod->has_cleanup)buf_printf (b,"#ifdef CONFIG_MODULE_UNLOAD\n" -" .exit = cleanup_module,\n" +"\t.exit = cleanup_module,\n" "#endif\n" ); -buf_printf (b," .arch = MODULE_ARCH_INIT,\n" ); +buf_printf (b,"\t.arch = MODULE_ARCH_INIT,\n" );buf_printf (b,"};\n" ); }
Rusty Russell
AppliedQuoted 10 lines · Greg Kroah-Hartman
If the kernel build process is creating files automatically, the least it can do is create them in a properly formatted manner. Sure, it's a minor issue, but being consistent is nice.
Cc Rusty Russell <[email protected]>Cc Alessio Igor Bogani <[email protected]>Cc Tony Lindgren <[email protected]>Cc Ben Hutchings <[email protected]>Cc Russell King <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>
Applied, thanks (I think!)
Cheers,
Rusty.