Skip to contentSkip to conversation

fixed coding style issue with comments

PATCH In review Jeffrin Jose 2 participants 2 messages Apr 29, 2012 Sound

lore
Share & tools
lore

Jeffrin Jose

author
#0 lore raw

PATCH 1/2 fixed coding style issue with comments

Hello .

Fixed coding style issue relating to comments in sound/usb/clock.c

Quoted 1 line

From 3bc5e14b4cf0dceb45314880233fe5a843ae048d Mon Sep 17 00:00:00 2001

From: Jeffrin Jose <[email protected]>
Date: Sun, 29 Apr 2012 18:05:21 +0530
Subject: [PATCH 09/10] sound:Fixed a coding style issue of comments.

Fixed a coding style issue by replacing C99 style with C89 in the file sound/usb/clock.c

Signed-off-by Jeffrin Jose <[email protected]>
---
 sound/usb/clock.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
sound/usb/clock.c +1 -1
index 379baad..a3319af 100644
@@ -240,7 +240,7 @@ static int set_sample_rate_v1(struct snd_usb_audio *chip, int iface,
 	crate = data[0] | (data[1] << 8) | (data[2] << 16);
 	if (crate != rate) {
 		snd_printd(KERN_WARNING "current rate %d is different from the runtime rate %d\n", crate, rate);
-		// runtime->rate = crate;
+		/* runtime->rate = crate; */
 	}
 
 	return 0;
Signature · 8 lines
1.7.9


-- 
software engineer
Bohr Lab
department of computer science
Rajagiri school of engineering and technology.
#1 lore raw

Hi,

Quoted 1 line · Jeffrin Jose

Fixed coding style issue relating to comments

[...]

sound/usb/clock.c static int set_sample_rate_v1(struct snd_usb_audio *chip, int iface, · line 244

Quoted 5 lines
sound/usb/clock.c +1 -1
 	if (crate != rate) {
 		snd_printd(KERN_WARNING "current rate %d is different from the runtime rate %d\n", crate, rate);
-		// runtime->rate = crate;
+		/* runtime->rate = crate; */
 	}

If you really want ti fix some style issues, you could also split the snd_printd() line that is over 80 characters. Moreover, this comment is not really meaningful, I would remove it at all.

I would prefer something like

- if (create != rate) {
+ if (create != rate)
- snd_printd(KERN_WARNING "current rate %d is different from the runtime rate %d\n", crate, rate);
+ snd_printd(KERN_WARNING
+ "current rate %d is different from runtime rate %d\n",
+ crate, rate);
- // runtime->rate = crate;
- }

Andi