Skip to contentSkip to conversation

s3c2412-i2s: Fix dai registration

PATCH Applied Heiko Stübner 2 participants 3 messages Apr 30, 2012 – May 1, 2012

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 s3c2412-i2s: Fix dai registration

As s3c2412-i2s is using the s3c_i2sv2 it should call the more specialised s3c_i2sv2_register_dai instead of simply calling snd_soc_register_dai.

Without this call the snd_soc_dai_ops structure isn't initialised correctly.

---
 sound/soc/samsung/s3c2412-i2s.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
sound/soc/samsung/s3c2412-i2s.c +1 -1
index 7218507..79fbeea 100644
@@ -166,7 +166,7 @@ static struct snd_soc_dai_driver s3c2412_i2s_dai = {
 
 static __devinit int s3c2412_iis_dev_probe(struct platform_device *pdev)
 {
-	return snd_soc_register_dai(&pdev->dev, &s3c2412_i2s_dai);
+	return s3c_i2sv2_register_dai(&pdev->dev, -1, &s3c2412_i2s_dai);
 }
 
 static __devexit int s3c2412_iis_dev_remove(struct platform_device *pdev)
Signature · 1 line
1.7.5.4
Applied
#1 lore raw
Quoted 2 lines · Heiko Stübner

As s3c2412-i2s is using the s3c_i2sv2 it should call the more specialised s3c_i2sv2_register_dai instead of simply calling snd_soc_register_dai.

Applied, thanks. Please always use subject lines appropraite for the subsystem.

#2 lore raw

Am Dienstag 01 Mai 2012, 00:46:11 schrieb Mark Brown:

Quoted 6 lines · Heiko Stübner
Quoted 2 lines

As s3c2412-i2s is using the s3c_i2sv2 it should call the more specialised s3c_i2sv2_register_dai instead of simply calling snd_soc_register_dai.

Applied, thanks. Please always use subject lines appropraite for the subsystem.

which should've been "ASoC:" in this case, sorry for getting it wrong

Heiko