Skip to contentSkip to conversation

Mark dhcp_use_ldap default off and enable binding to unreserved ports

PATCH New Sven Vermeulen 2 participants 2 messages May 1, 2012 – May 4, 2012

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Mark dhcp_use_ldap default off and enable binding to unreserved ports

Do not include the privileges for using LDAP by default (boolean defaults to off).

Also includes support for binding to unreserved ports, used by DHCP to detect the open interfaces (as seen in common/discover.c, function "begin_iface_scan" in the DHCP sources). Include a comment in the sources to inform us about this in the future.

See also http://oss.tresys.com/pipermail/refpolicy/2012-March/004981.html

---
 dhcp.te |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
dhcp.te +3 -1
index 064604a..32937ad 100644
@@ -10,7 +10,7 @@ policy_module(dhcp, 1.9.1)
 ## Allow DHCP daemon to use LDAP backends
 ## </p>
 ## </desc>
-gen_tunable(dhcpd_use_ldap, true)
+gen_tunable(dhcpd_use_ldap, false)
 
 type dhcpd_t;
 type dhcpd_exec_t;
@@ -71,6 +71,8 @@ corenet_udp_sendrecv_generic_node(dhcpd_t)
 corenet_raw_sendrecv_generic_node(dhcpd_t)
 corenet_tcp_sendrecv_all_ports(dhcpd_t)
 corenet_udp_sendrecv_all_ports(dhcpd_t)
+# Needed to detect open number of interfaces (common/discover.c::begin_iface_scan)
+corenet_udp_bind_all_unreserved_ports(dhcpd_t)
 corenet_tcp_bind_generic_node(dhcpd_t)
 corenet_udp_bind_generic_node(dhcpd_t)
 corenet_tcp_bind_dhcpd_port(dhcpd_t)
Signature · 1 line
1.7.3.4
#1 lore raw

PATCH 1/1 Mark dhcp_use_ldap default off and enable binding to unreserved ports

Quoted 5 lines · Sven Vermeulen

Do not include the privileges for using LDAP by default (boolean defaults to off).

Also includes support for binding to unreserved ports, used by DHCP to detect the open interfaces (as seen in common/discover.c, function "begin_iface_scan" in the DHCP sources). Include a comment in the sources to inform us about this in the future.

Merged.

Quoted 29 lines

See also http://oss.tresys.com/pipermail/refpolicy/2012-March/004981.html

---
 dhcp.te |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
dhcp.te +3 -1
index 064604a..32937ad 100644
@@ -10,7 +10,7 @@ policy_module(dhcp, 1.9.1)
 ## Allow DHCP daemon to use LDAP backends
 ## </p>
 ## </desc>
-gen_tunable(dhcpd_use_ldap, true)
+gen_tunable(dhcpd_use_ldap, false)
 
 type dhcpd_t;
 type dhcpd_exec_t;
@@ -71,6 +71,8 @@ corenet_udp_sendrecv_generic_node(dhcpd_t)
 corenet_raw_sendrecv_generic_node(dhcpd_t)
 corenet_tcp_sendrecv_all_ports(dhcpd_t)
 corenet_udp_sendrecv_all_ports(dhcpd_t)
+# Needed to detect open number of interfaces (common/discover.c::begin_iface_scan)
+corenet_udp_bind_all_unreserved_ports(dhcpd_t)
 corenet_tcp_bind_generic_node(dhcpd_t)
 corenet_udp_bind_generic_node(dhcpd_t)
 corenet_tcp_bind_dhcpd_port(dhcpd_t)
Signature · 3 lines
Chris PeBenito
Tresys Technology, LLC
www.tresys.com | oss.tresys.com