Skip to contentSkip to conversation

usb: [ARM] fix unresolved err() reference in host/ohci-pxa27x.c

PATCH New Paul Gortmaker 2 participants 2 messages May 1, 2012

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 usb: [ARM] fix unresolved err() reference in host/ohci-pxa27x.c

Commit af4e1ee04026908086d7ed252db2619a8ceaa333 (usb-next)

"USB: remove err() macro"

was preceeded by a tree-wide cleanup of users, however this one squeaked through the cracks because it had whitespace between the function name and the bracket for the args.

Map it onto dev_err, just like all the "pre-commits" made in advance of af4e1ee04026, such as the example seen in the commit d57b177208b6ec20cacd7321ee32ef02f9f9e7fa:

"USB: ohci-xls.c: remove err() usage"

Build tested with the ARM magician_defconfig settings.

Cc Eric Miao <[email protected]>
Cc Russell King <[email protected]>
Cc Alan Stern <[email protected]>
Cc Greg Kroah-Hartman <[email protected]>
drivers/usb/host/ohci-pxa27x.c +2 -1
index c31b281..e1a3cc6 100644
@@ -419,7 +419,8 @@ ohci_pxa27x_start (struct usb_hcd *hcd)
 		return ret;
 
 	if ((ret = ohci_run (ohci)) < 0) {
-		err ("can't start %s", hcd->self.bus_name);
+		dev_err(hcd->self.controller, "can't start %s",
+			hcd->self.bus_name);
 		ohci_stop (hcd);
 		return ret;
 	}
Signature · 1 line
1.7.9.1
#1 lore raw

PATCH 1/1 usb: [ARM] fix unresolved err() reference in host/ohci-pxa27x.c

Quoted 8 lines · Paul Gortmaker

Commit af4e1ee04026908086d7ed252db2619a8ceaa333 (usb-next)

"USB: remove err() macro"

was preceeded by a tree-wide cleanup of users, however this one squeaked through the cracks because it had whitespace between the function name and the bracket for the args.

Quoted 7 lines

Map it onto dev_err, just like all the "pre-commits" made in advance of af4e1ee04026, such as the example seen in the commit d57b177208b6ec20cacd7321ee32ef02f9f9e7fa:

"USB: ohci-xls.c: remove err() usage"

Build tested with the ARM magician_defconfig settings.

Thanks so much for these three patches, sorry for messing up the build and missing these three calls.

greg k-h