vme: vme_tsi148.c: local functions should not be exposed globally
PATCH 1/1 vme: vme_tsi148.c: local functions should not be exposed globally
Functions not referenced outside of a source file should be marked static to prevent them from being exposed globally.
Quiets the sparse warnings:
warning: symbol 'tsi148_alloc_consistent' was not declared. Should it be static?
warning: symbol 'tsi148_free_consistent' was not declared. Should it be static?
Signed-off-by H Hartley Sweeten <[email protected]>
Cc Greg Kroah-Hartman <[email protected]>
Cc Martyn Welch <[email protected]>
---
drivers/vme/bridges/vme_tsi148.c +3 -3
@@ -2141,7 +2141,7 @@ static int tsi148_slot_get(struct vme_bridge *tsi148_bridge)return (int )slot; } -void *tsi148_alloc_consistent (struct device *parent,size_t size, +static void *tsi148_alloc_consistent (struct device *parent,size_t size,dma_addr_t *dma) {struct pci_dev *pdev;
@@ -2152,8 +2152,8 @@ void *tsi148_alloc_consistent(struct device *parent, size_t size,return pci_alloc_consistent (pdev, size, dma); } -void tsi148_free_consistent (struct device *parent,size_t size,void *vaddr, -dma_addr_t dma) +static void tsi148_free_consistent (struct device *parent,size_t size, +void *vaddr,dma_addr_t dma) {struct pci_dev *pdev;
Quoted 12 lines · H Hartley Sweeten lin
Functions not referenced outside of a source file should be marked static to prevent them from being exposed globally.
Quiets the sparse warnings:
warning: symbol '
tsi148_alloc_consistent' was not declared. Should it be static?
warning: symbol 'tsi148_free_consistent' was not declared. Should it be static?Signed-off-by H Hartley Sweeten <[email protected]>Cc Greg Kroah-Hartman <[email protected]>Cc Martyn Welch <[email protected]>
Good catch,
Acked-by Martyn Welch <[email protected]>
Martyn
Quoted 26 lines
---
drivers/vme/bridges/vme_tsi148.c +3
-3@@ -2141,7 +2141,7 @@ static int tsi148_slot_get(struct vme_bridge *tsi148_bridge)return (int )slot; } -void *tsi148_alloc_consistent (struct device *parent,size_t size, +static void *tsi148_alloc_consistent (struct device *parent,size_t size,dma_addr_t *dma) {struct pci_dev *pdev;@@ -2152,8 +2152,8 @@ void *tsi148_alloc_consistent(struct device *parent, size_t size,return pci_alloc_consistent (pdev, size, dma); } -void tsi148_free_consistent (struct device *parent,size_t size,void *vaddr, -dma_addr_t dma) +static void tsi148_free_consistent (struct device *parent,size_t size, +void *vaddr,dma_addr_t dma) {struct pci_dev *pdev;
Signature · 4 lines
Martyn Welch (Lead Software Engineer) | Registered in England and Wales GE Intelligent Platforms | (3828642) at 100 Barbirolli Square T +44(0)1327322748 | Manchester, M2 3AB E [email protected] | VAT:GB 927559189