mx28evk: add NAND support

PATCH New Lauri Hintsala 4 participants 10 messages Apr 17, 2012 – May 6, 2012

Share & tools

Lauri Hintsala

author

2012-04-17 10:35 UTC #0 lore raw

PATCH 1/1 mx28evk: add NAND support

NAND support is not enabled by default because Eval Kit is not delivered with NAND chip. To enable NAND support add CONFIG_CMD_NAND to board config.

Signed-off-by Lauri Hintsala <[email protected]>

---
 board/freescale/mx28evk/iomux.c |   21 +++++++++++++++++++++
 include/configs/mx28evk.h       |   10 ++++++++++
 2 files changed, 31 insertions(+), 0 deletions(-)

board/freescale/mx28evk/iomux.c +21 -0

index 396761b..6587c45 100644
@@ -26,6 +26,7 @@
 #include <asm/arch/sys_proto.h>
 
 #define	MUX_CONFIG_SSP0	(MXS_PAD_3V3 | MXS_PAD_8MA | MXS_PAD_PULLUP)
+#define	MUX_CONFIG_GPMI	(MXS_PAD_3V3 | MXS_PAD_4MA | MXS_PAD_NOPULL)
 #define	MUX_CONFIG_ENET	(MXS_PAD_3V3 | MXS_PAD_8MA | MXS_PAD_PULLUP)
 #define	MUX_CONFIG_EMI	(MXS_PAD_3V3 | MXS_PAD_12MA | MXS_PAD_NOPULL)
 #define	MUX_CONFIG_SSP2	(MXS_PAD_3V3 | MXS_PAD_4MA | MXS_PAD_PULLUP)

@@ -55,6 +56,26 @@ const iomux_cfg_t iomux_setup[] = {
 	MX28_PAD_PWM3__GPIO_3_28 |
 		(MXS_PAD_12MA | MXS_PAD_3V3 | MXS_PAD_PULLUP),
 
+#ifdef CONFIG_NAND_MXS
+	/* GPMI NAND */
+	MX28_PAD_GPMI_D00__GPMI_D0 | MUX_CONFIG_GPMI,
+	MX28_PAD_GPMI_D01__GPMI_D1 | MUX_CONFIG_GPMI,
+	MX28_PAD_GPMI_D02__GPMI_D2 | MUX_CONFIG_GPMI,
+	MX28_PAD_GPMI_D03__GPMI_D3 | MUX_CONFIG_GPMI,
+	MX28_PAD_GPMI_D04__GPMI_D4 | MUX_CONFIG_GPMI,
+	MX28_PAD_GPMI_D05__GPMI_D5 | MUX_CONFIG_GPMI,
+	MX28_PAD_GPMI_D06__GPMI_D6 | MUX_CONFIG_GPMI,
+	MX28_PAD_GPMI_D07__GPMI_D7 | MUX_CONFIG_GPMI,
+	MX28_PAD_GPMI_CE0N__GPMI_CE0N | MUX_CONFIG_GPMI,
+	MX28_PAD_GPMI_RDY0__GPMI_READY0 | MUX_CONFIG_GPMI,
+	MX28_PAD_GPMI_RDN__GPMI_RDN |
+		(MXS_PAD_3V3 | MXS_PAD_8MA | MXS_PAD_PULLUP),
+	MX28_PAD_GPMI_WRN__GPMI_WRN | MUX_CONFIG_GPMI,
+	MX28_PAD_GPMI_ALE__GPMI_ALE | MUX_CONFIG_GPMI,
+	MX28_PAD_GPMI_CLE__GPMI_CLE | MUX_CONFIG_GPMI,
+	MX28_PAD_GPMI_RESETN__GPMI_RESETN | MUX_CONFIG_GPMI,
+#endif
+
 	/* FEC0 */
 	MX28_PAD_ENET0_MDC__ENET0_MDC | MUX_CONFIG_ENET,
 	MX28_PAD_ENET0_MDIO__ENET0_MDIO | MUX_CONFIG_ENET,

include/configs/mx28evk.h +10 -0

index 02f3366..2a44baa 100644
@@ -148,6 +148,16 @@
 #endif
 
 /*
+ * NAND Driver
+ */
+#ifdef CONFIG_CMD_NAND
+#define CONFIG_NAND_MXS
+#define CONFIG_SYS_MAX_NAND_DEVICE	1
+#define CONFIG_SYS_NAND_BASE		0x60000000
+#define CONFIG_SYS_NAND_5_ADDR_CYCLE
+#endif
+
+/*
  * Ethernet on SOC (FEC)
  */
 #ifdef	CONFIG_CMD_NET

Signature · 1 line

1.7.5.4

Marek Vasut

2012-04-17 11:21 UTC #1 lore raw

PATCH 1/1 mx28evk: add NAND support

Dear Lauri Hintsala,

Quoted 4 lines

NAND support is not enabled by default because Eval Kit is not delivered with NAND chip. To enable NAND support add CONFIG_CMD_NAND to board config.
Signed-off-by Lauri Hintsala <[email protected]>

Acked-by Marek Vasut <[email protected]>

I think we can schedule it for .04 release as this is basically a fix? Fabio ?

Quoted 55 lines

---
 board/freescale/mx28evk/iomux.c |   21 +++++++++++++++++++++
 include/configs/mx28evk.h       |   10 ++++++++++
 2 files changed, 31 insertions(+), 0 deletions(-)

(quoted diff) +0 -0

b/board/freescale/mx28evk/iomux.c index 396761b..6587c45 100644

board/freescale/mx28evk/iomux.c +21 -0

@@ -26,6 +26,7 @@
 #include <asm/arch/sys_proto.h>
 
 #define	MUX_CONFIG_SSP0	(MXS_PAD_3V3 | MXS_PAD_8MA | MXS_PAD_PULLUP)
+#define	MUX_CONFIG_GPMI	(MXS_PAD_3V3 | MXS_PAD_4MA | MXS_PAD_NOPULL)
 #define	MUX_CONFIG_ENET	(MXS_PAD_3V3 | MXS_PAD_8MA | MXS_PAD_PULLUP)
 #define	MUX_CONFIG_EMI	(MXS_PAD_3V3 | MXS_PAD_12MA | MXS_PAD_NOPULL)
 #define	MUX_CONFIG_SSP2	(MXS_PAD_3V3 | MXS_PAD_4MA | MXS_PAD_PULLUP)

@@ -55,6 +56,26 @@ const iomux_cfg_t iomux_setup[] = {
 	MX28_PAD_PWM3__GPIO_3_28 |
 		(MXS_PAD_12MA | MXS_PAD_3V3 | MXS_PAD_PULLUP),
 
+#ifdef CONFIG_NAND_MXS
+	/* GPMI NAND */
+	MX28_PAD_GPMI_D00__GPMI_D0 | MUX_CONFIG_GPMI,
+	MX28_PAD_GPMI_D01__GPMI_D1 | MUX_CONFIG_GPMI,
+	MX28_PAD_GPMI_D02__GPMI_D2 | MUX_CONFIG_GPMI,
+	MX28_PAD_GPMI_D03__GPMI_D3 | MUX_CONFIG_GPMI,
+	MX28_PAD_GPMI_D04__GPMI_D4 | MUX_CONFIG_GPMI,
+	MX28_PAD_GPMI_D05__GPMI_D5 | MUX_CONFIG_GPMI,
+	MX28_PAD_GPMI_D06__GPMI_D6 | MUX_CONFIG_GPMI,
+	MX28_PAD_GPMI_D07__GPMI_D7 | MUX_CONFIG_GPMI,
+	MX28_PAD_GPMI_CE0N__GPMI_CE0N | MUX_CONFIG_GPMI,
+	MX28_PAD_GPMI_RDY0__GPMI_READY0 | MUX_CONFIG_GPMI,
+	MX28_PAD_GPMI_RDN__GPMI_RDN |
+		(MXS_PAD_3V3 | MXS_PAD_8MA | MXS_PAD_PULLUP),
+	MX28_PAD_GPMI_WRN__GPMI_WRN | MUX_CONFIG_GPMI,
+	MX28_PAD_GPMI_ALE__GPMI_ALE | MUX_CONFIG_GPMI,
+	MX28_PAD_GPMI_CLE__GPMI_CLE | MUX_CONFIG_GPMI,
+	MX28_PAD_GPMI_RESETN__GPMI_RESETN | MUX_CONFIG_GPMI,
+#endif
+
 	/* FEC0 */
 	MX28_PAD_ENET0_MDC__ENET0_MDC | MUX_CONFIG_ENET,
 	MX28_PAD_ENET0_MDIO__ENET0_MDIO | MUX_CONFIG_ENET,

include/configs/mx28evk.h +3 -0

index 02f3366..2a44baa 100644
@@ -148,6 +148,16 @@
 #endif
 
 /*
+ * NAND Driver
+ */
+#ifdef CONFIG_CMD_NAND

include/configs/mx28evk.h line 163

Quoted 10 lines

include/configs/mx28evk.h +7 -0

+#define CONFIG_NAND_MXS
+#define CONFIG_SYS_MAX_NAND_DEVICE	1
+#define CONFIG_SYS_NAND_BASE		0x60000000
+#define CONFIG_SYS_NAND_5_ADDR_CYCLE
+#endif
+
+/*
  * Ethernet on SOC (FEC)
  */
 #ifdef	CONFIG_CMD_NET

Best regards,
Marek Vasut

Fabio Estevam

2012-04-17 13:34 UTC #2 lore raw

PATCH 1/1 mx28evk: add NAND support

Quoted 6 lines · Marek Vasut

Dear Lauri Hintsala,
Quoted 4 lines
NAND support is not enabled by default because Eval Kit is not delivered with NAND chip. To enable NAND support add CONFIG_CMD_NAND to board config.

Quoted 6 lines

Quoted 1 line
Signed-off-by Lauri Hintsala <[email protected]>
Acked-by Marek Vasut <[email protected]>
I think we can schedule it for .04 release as this is basically a fix? Fabio ?

Looks good to me. My only suggestion (can be part of a separate patch) is to modify the mx28evk README and explain that mx28evk can also boot from NAND and explain the boot mode settings, etc.

Thanks,

Fabio Estevam

Marek Vasut

2012-04-17 14:22 UTC #3 lore raw

PATCH 1/1 mx28evk: add NAND support

Dear Fabio Estevam,

Quoted 9 lines · Marek Vasut

Quoted 8 lines
Dear Lauri Hintsala,
Quoted 5 lines
NAND support is not enabled by default because Eval Kit is not delivered with NAND chip. To enable NAND support add CONFIG_CMD_NAND to board config.
Signed-off-by Lauri Hintsala <[email protected]>

Quoted 8 lines

Quoted 4 lines
Acked-by Marek Vasut <[email protected]>
I think we can schedule it for .04 release as this is basically a fix? Fabio ?
Looks good to me. My only suggestion (can be part of a separate patch) is to modify the mx28evk README and explain that mx28evk can also boot from NAND and explain the boot mode settings, etc.

Good idea, but let's do this in a separate patch :)

Quoted 4 lines

Thanks,
Fabio Estevam

Best regards,
Marek Vasut

Stefano Babic

2012-04-17 14:30 UTC #4 lore raw

PATCH 1/1 mx28evk: add NAND support

In reply to Marek Vasut

Quoted 10 lines · Marek Vasut

Dear Lauri Hintsala,
Quoted 4 lines
NAND support is not enabled by default because Eval Kit is not delivered with NAND chip. To enable NAND support add CONFIG_CMD_NAND to board config.
Signed-off-by Lauri Hintsala <[email protected]>
Acked-by Marek Vasut <[email protected]>
I think we can schedule it for .04 release as this is basically a fix? Fabio ?

Well, this is not a fix because it adds a feature that is not yet supported. It should be deferred to the next release.

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

Marek Vasut

2012-04-17 14:46 UTC #5 lore raw

PATCH 1/1 mx28evk: add NAND support

Dear Stefano Babic,

Quoted 9 lines · Marek Vasut

Quoted 8 lines
Dear Lauri Hintsala,
Quoted 5 lines
NAND support is not enabled by default because Eval Kit is not delivered with NAND chip. To enable NAND support add CONFIG_CMD_NAND to board config.
Signed-off-by Lauri Hintsala <[email protected]>

Quoted 7 lines

Quoted 4 lines
Acked-by Marek Vasut <[email protected]>
I think we can schedule it for .04 release as this is basically a fix? Fabio ?
Well, this is not a fix because it adds a feature that is not yet supported. It should be deferred to the next release.

Ok, I won't object either way as it doesn't concern me that much ;-)

Quoted 3 lines

Best regards,
Stefano Babic

Best regards,
Marek Vasut

Fabio Estevam

2012-05-02 17:26 UTC #6 lore raw

PATCH 1/1 mx28evk: add NAND support

In reply to Stefano Babic

Hi Stefano,

Quoted 2 lines · Stefano Babic

Well, this is not a fix because it adds a feature that is not yet supported. It should be deferred to the next release.

Can this be applied now?

Marek Vasut

2012-05-02 17:53 UTC #7 lore raw

PATCH 1/1 mx28evk: add NAND support

Dear Fabio Estevam,

Quoted 7 lines

Hi Stefano,
Quoted 2 lines · Stefano Babic
Well, this is not a fix because it adds a feature that is not yet supported. It should be deferred to the next release.
Can this be applied now?

Should be ...

Best regards,
Marek Vasut

stefano babic

2012-05-02 20:58 UTC #8 lore raw

PATCH 1/1 mx28evk: add NAND support

In reply to Fabio Estevam

Am 02/05/2012 19:26, schrieb Fabio Estevam:

Quoted 9 lines

Hi Stefano,
Quoted 2 lines · Stefano Babic
Well, this is not a fix because it adds a feature that is not yet supported. It should be deferred to the next release.
Can this be applied now?

Yes, I will do it.

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

Stefano Babic

2012-05-06 16:42 UTC #9 lore raw

PATCH 1/1 mx28evk: add NAND support

In reply to Lauri Hintsala

Quoted 5 lines · Lauri Hintsala

NAND support is not enabled by default because Eval Kit is not delivered with NAND chip. To enable NAND support add CONFIG_CMD_NAND to board config.
Signed-off-by Lauri Hintsala <[email protected]>
---

Applied to u-boot-imx, thanks

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================