Skip to contentSkip to conversation

Extcon: fix section mismatch in extcon_gpio.c

PATCH In review H Hartley Sweeten 3 participants 6 messages May 2, 2012 External connector subsystem (extcon)

lore
Share & tools
lore

H Hartley Sweeten

author
#0 lore raw

PATCH 1/1 Extcon: fix section mismatch in extcon_gpio.c

Fix the section mismatch be renaming the struct platform_driver variable.

Signed-off-by H Hartley Sweeten <[email protected]>
Cc MyungJoo Ham <[email protected]>
Cc Mark Brown <[email protected]>
Cc Greg Kroah-Hartman <[email protected]>
Cc Kyungmin Park <[email protected]>

---

drivers/extcon/extcon_gpio.c +2 -2
index 5c0f085..fe7a07b 100644
@@ -153,7 +153,7 @@ static int __devexit gpio_extcon_remove(struct platform_device *pdev)
 	return 0;
 }
 
-static struct platform_driver gpio_extcon = {
+static struct platform_driver gpio_extcon_driver = {
 	.probe		= gpio_extcon_probe,
 	.remove		= __devexit_p(gpio_extcon_remove),
 	.driver		= {

@@ -162,7 +162,7 @@ static struct platform_driver gpio_extcon = {
 	},
 };
 
-module_platform_driver(gpio_extcon);
+module_platform_driver(gpio_extcon_driver);
 
 MODULE_AUTHOR("Mike Lockwood <[email protected]>");
 MODULE_DESCRIPTION("GPIO extcon driver");
#1 lore raw
Quoted 2 lines · H Hartley Sweeten

Fix the section mismatch be renaming the struct platform_driver variable.

I'm pretty sure I sent a version of this patch sometime last week :/

#2 lore raw
Quoted 5 lines · Mark Brown
Quoted 2 lines · H Hartley Sweeten

Fix the section mismatch be renaming the struct platform_driver variable.

I'm pretty sure I sent a version of this patch sometime last week :/

So did I, but I can't seem to find it anywhere. Did I not apply it?

odd.

#3 lore raw
Quoted 3 lines · Greg KH

So did I, but I can't seem to find it anywhere. Did I not apply it?

odd.

Nope, no response at all from you that I recall. Perhaps I forgot to CC the list or something.

#4 lore raw
Quoted 8 lines · Mark Brown
Quoted 3 lines · Greg KH

So did I, but I can't seem to find it anywhere. Did I not apply it?

odd.

Nope, no response at all from you that I recall. Perhaps I forgot to CC the list or something.

Hm, I found it now, it ended up in my "already applied this" mbox, but obviously, I didn't apply it.

Very sorry about that, I went through a few hundred patches the other day on the airplane, I must have messed this one up, my apologies.

greg k-h

author
#5 lore raw
In reply to Mark Brown
Quoted 5 lines · Mark Brown
Quoted 2 lines · H Hartley Sweeten

Fix the section mismatch be renaming the struct platform_driver variable.

I'm pretty sure I sent a version of this patch sometime last week :/

If you have Mark's patch already, I have no problem with you using his instead.

Regards,
Hartley