msm7x30: Add support for low speed uart on msm7x30
PATCH 1/5 msm7x30: Add support for low speed uart on msm7x30
From: Mohamed Haneef <[email protected]>
* Support for low speed uart
--- drivers/serial/Makefile | 1 + drivers/serial/serial_msm_uart.c | 206 ++++++++++++++++++++++++++++++++++++++ 2 files changed, 207 insertions(+), 0 deletions(-) create mode 100644 drivers/serial/serial_msm_uart.c
drivers/serial/Makefile +1 -0
@@ -55,6 +55,7 @@ COBJS-$(CONFIG_S3C44B0_SERIAL) += serial_s3c44b0.o COBJS-$(CONFIG_XILINX_UARTLITE) += serial_xuartlite.o COBJS-$(CONFIG_SANDBOX_SERIAL) += sandbox.o COBJS-$(CONFIG_SCIF_CONSOLE) += serial_sh.o +COBJS-$(CONFIG_MSM_UART) += serial_msm_uart.o ifndef CONFIG_SPL_BUILD COBJS-$(CONFIG_USB_TTY) += usbtty.o
drivers/serial/serial_msm_uart.c new file +206 -0
206 lines not on this page · raw message
--
1.7.1
The contents of this e-mail and any attachment(s) may contain confidential or privileged information for the intended recipient(s). Unintended recipients are prohibited from taking action on the basis of information in this e-mail and using or disseminating the information, and must notify the sender and delete it from their system. L&T Infotech will not accept responsibility or liability for the accuracy or completeness of, or the presence of any virus or disabling code in this e-mail"
PATCH 1/5 msm7x30: Add support for low speed uart on msm7x30
Hi Mohamed,
Le 16/02/2012 03:59, mohamed.haneef at lntinfotech.com a ?crit :
Review
Quoted 2 lines
(quoted diff) +2
-0+#define UART_CR_TX_DISABLE (1<< 3) +#define UART_CR_TX_ENABLE (1<< 3)
I doubt the same bit value can mean both enable and disable.
Review
Quoted 2 lines
(quoted diff) +2
-0+#define UART_CR_RX_DISABLE (1<< 3) +#define UART_CR_RX_ENABLE (1<< 3)
Ditto.
Besides, neither of these defines are used anyway. What's the point of having them? I suspect many others are unused, too. Unless there is a compelling reason to keep useless defines, remove them.
Quoted 8 lines
The contents of this e-mail and any attachment(s) may contain confidential or privileged information for the intended recipient(s). Unintended recipients are prohibited from taking action on the basis of information in this e-mail and using or disseminating the information, and must notify the sender and delete it from their system. L&T Infotech will not accept responsibility or liability for the accuracy or completeness of, or the presence of any virus or disabling code in this e-mail"
Please do not post with this footer on the list. It os obnoxious (and quite purposeless on a public list :) )
Amicalement,
Signature · 1 line
Albert.
PATCH v2 1/5 msm7x30: Add Support for low speed uart on msm7x30
In reply to mohamed.haneef at lntinfotech.com* Support for low speed uart
---
Changes for v2:
- Removed unused macros
drivers/serial/Makefile | 1 + drivers/serial/serial_msm_uart.c | 156 ++++++++++++++++++++++++++++++++++++++ 2 files changed, 157 insertions(+), 0 deletions(-) create mode 100644 drivers/serial/serial_msm_uart.c
drivers/serial/Makefile +1 -0
@@ -55,6 +55,7 @@ COBJS-$(CONFIG_S3C44B0_SERIAL) += serial_s3c44b0.o COBJS-$(CONFIG_XILINX_UARTLITE) += serial_xuartlite.o COBJS-$(CONFIG_SANDBOX_SERIAL) += sandbox.o COBJS-$(CONFIG_SCIF_CONSOLE) += serial_sh.o +COBJS-$(CONFIG_MSM_UART) += serial_msm_uart.o ifndef CONFIG_SPL_BUILD COBJS-$(CONFIG_USB_TTY) += usbtty.o
drivers/serial/serial_msm_uart.c new file +156 -0
156 lines not on this page · raw message
--
1.7.1
The contents of this e-mail and any attachment(s) may contain confidential or privileged information for the intended recipient(s). Unintended recipients are prohibited from taking action on the basis of information in this e-mail and using or disseminating the information, and must notify the sender and delete it from their system. L&T Infotech will not accept responsibility or liability for the accuracy or completeness of, or the presence of any virus or disabling code in this e-mail"
[U-Boot] reminder for [PATCH 0/5] Support for qualcomm msm7630 board
In reply to mohamed.haneef at lntinfotech.comFrom: Mohamed Haneef <[email protected]>
This is a humbel reminder for review of patch series for msm7630 board after making the changes proposed by u-boot community. The Patches contain the following support
* low speed uart for msm7630
* interprocessor communication
* qc_mmc microcontroller
* msm7630 soc
* msm7630 surf board
The contents of this e-mail and any attachment(s) may contain confidential or privileged information for the intended recipient(s). Unintended recipients are prohibited from taking action on the basis of information in this e-mail and using or disseminating the information, and must notify the sender and delete it from their system. L&T Infotech will not accept responsibility or liability for the accuracy or completeness of, or the presence of any virus or disabling code in this e-mail"
[U-Boot] (no subject)
In reply to mohamed.haneef at lntinfotech.comThe patch for msm7630 was released to the u-boot community on 16-feb-2-2012 can this be mainlined in v2012.07 release.The Patches contain the following support
* low speed uart for msm7630
* interprocessor communication
* qc_mmc microcontroller
* msm7630 soc
* msm7630 surf board
Thanks and regards,
Mohamed Haneef M.A
The contents of this e-mail and any attachment(s) may contain confidential or privileged information for the intended recipient(s). Unintended recipients are prohibited from taking action on the basis of information in this e-mail and using or disseminating the information, and must notify the sender and delete it from their system. L&T Infotech will not accept responsibility or liability for the accuracy or completeness of, or the presence of any virus or disabling code in this e-mail"
[U-Boot] msm7630 mainline request
In reply to mohamed.haneef at lntinfotech.comThe patch for msm7630 was released to the u-boot community on 16-feb-2-2012 can this be mainlined in v2012.07 release.The Patches contain the following support
* low speed uart for msm7630
* interprocessor communication
* qc_mmc microcontroller
* msm7630 soc
* msm7630 surf board
Thanks and regards,
Mohamed Haneef M.A
The contents of this e-mail and any attachment(s) may contain confidential or privileged information for the intended recipient(s). Unintended recipients are prohibited from taking action on the basis of information in this e-mail and using or disseminating the information, and must notify the sender and delete it from their system. L&T Infotech will not accept responsibility or liability for the accuracy or completeness of, or the presence of any virus or disabling code in this e-mail"
[U-Boot] msm7630 mainline request
Dear mohamed.haneef at lntinfotech.com,
Quoted 7 lines
The patch for msm7630 was released to the u-boot community on 16-feb-2-2012 can this be mainlined in v2012.07 release.The Patches contain the following support * low speed uart for msm7630
* interprocessor communication
*qc_mmcmicrocontroller
* msm7630 soc
* msm7630 surf board
It'd be great, CCing albert to review it as we don't have MSM maintainer.
Quoted 4 lines
Thanks and regards,
Mohamed Haneef M.A
Quoted 11 lines
The contents of this e-mail and any attachment(s) may contain confidential or privileged information for the intended recipient(s). Unintended recipients are prohibited from taking action on the basis of information in this e-mail and using or disseminating the information, and must notify the sender and delete it from their system. L&T Infotech will not accept responsibility or liability for the accuracy or completeness of, or the presence of any virus or disabling code in this e-mail"
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Best regards,
Marek Vasut