Skip to contentSkip to conversation

params: add 3rd arg to option handler callback signature

DISCUSSION Dan Carpenter 1 participant 1 message May 3, 2012

lore
Share & tools
lore
#0 lore raw

Hello Jim Cromie,

This is a semi-automatic email about new static checker warnings in linux-next.

The patch 9fb48c744ba6: "params: add 3rd arg to option handler callback signature" from Apr 27, 2012, leads to the following Smatch complaint:

kernel/params.c:196 parse_args()
error: we previously assumed 'args' could be null (see line 193)

kernel/params.c
192
193 if (args && *args)

                    ^^^^

New check.

194 pr_debug("doing %s, parsing ARGS: '%s'\n", doing, args);
195

   196		while (*args) {
                       ^^^^^

Old dereference.

197 int ret;
198 int irq_was_disabled;

regards,
dan carpenter