Package proposed: read-edid
PATCH 1/1 Package proposed: read-edid
Hi,
I would like to propose the read-edid package for inclusion in Buildroot. This package provides a pair of utilities: one to issue a real-mode BIOS call to read monitor descriptor block (EDID), and other to parse it.
Thanks.
Signature · 10 lines
Dimitry Golubovsky Anywhere on the Web -------------- next part -------------- A non-text attachment was scrubbed... Name: buildroot-read-edid.patch Type: application/octet-stream Size: 1986 bytes Desc: not available URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20120503/eed95758/attachment.obj>
PATCH 1/1 Package proposed: read-edid
Hi Dimitry,
Quoted 4 lines · Dimitry Golubovsky
I would like to propose the read-edid package for inclusion in Buildroot. This package provides a pair of utilities: one to issue a real-mode BIOS call to read monitor descriptor block (EDID), and other to parse it.
Please send your patch inline to ease review. Use may 'git send-email' to automate patch sending.
Also, you have to sign-off your patches for them to be included in Buildroot. See http://elinux.org/Developer_Certificate_Of_Origin.
A few more comments inline below.
package/Config.in +1 -0
@@ -210,6 +210,7 @@ source "package/openocd/Config.in" source "package/parted/Config.in" source "package/pciutils/Config.in" source "package/picocom/Config.in" +source "package/read-edid/Config.in" source "package/rng-tools/Config.in" source "package/sane-backends/Config.in" source "package/sdparm/Config.in"
package/read-edid/Config.in new file +2 -0
@@ -0,0 +1,11 @@ +config BR2_PACKAGE_READ_EDID + bool "read-edid"
read-edid can only run on x86 PCs and PowerPC Macs, so it should depend on (BR2_i386 || BR2_x86_64 || BR2_powerpc).
+ help
+ Read-edid is a pair of tools (originally by John Fremlin) for reading the EDID + from a monitor. It should work with most monitors made since 1996 (except for + newer ones with 256-byte EDID's - WiP), assuming the video card supports the + standard read commands (most do). Read-edid is a set of two tools - get-edid, + which gets the raw edid information from the monitor, and parse-edid, which + turns the raw binary information into an XF86Config-compatible monitor section.
+
+ http://polypux.org/projects/read-edid/
package/read-edid/read-edid.mk new file +8 -0
@@ -0,0 +1,21 @@ +############################################ +# +# read-edid +# +############################################ + +READ_EDID_VERSION = 1.4.2 +READ_EDID_SOURCE = read-edid-$(READ_EDID_VERSION).tar.gz
This is the default value. Just drop this line.
+READ_EDID_SITE = http://www.polypux.org/projects/read-edid/
+
+define READ_EDID_BUILD_CMDS
+ $(MAKE) CC="$(TARGET_CC)" LD="$(TARGET_LD)" -C $(@D)
You can use $(TARGET_CONFIGURE_OPTS) instead of specifying CC and LD.
+endef
+
+define READ_EDID_INSTALL_TARGET_CMDS
+ $(INSTALL) -D -m 0755 $(@D)/get-edid $(TARGET_DIR)/bin
+ $(INSTALL) -D -m 0755 $(@D)/parse-edid $(TARGET_DIR)/bin
+endef
+
+$(eval $(call AUTOTARGETS,package,read-edid))
The last two parameters of AUTOTARGETS are not needed anymore.
baruch
Signature · 3 lines
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -PATCH 1/1 Package proposed: read-edid
Hello Dimitry,
Thanks for your contribution! Baruch has raised valid points in his review, I will add one more comment below.
Le Thu, 3 May 2012 08:18:20 +0300,
Baruch Siach <[email protected]> a ?crit :
Review
Quoted 4 lines
(quoted diff) +4
-0+define READ_EDID_INSTALL_TARGET_CMDS + $(INSTALL) -D -m 0755 $(@D)/get-edid $(TARGET_DIR)/bin + $(INSTALL) -D -m 0755 $(@D)/parse-edid $(TARGET_DIR)/bin +endef
This should rather be:
+define READ_EDID_INSTALL_TARGET_CMDS
+ $(INSTALL) -D -m 0755 $(@D)/get-edid $(TARGET_DIR)/usr/bin/get-edid
+ $(INSTALL) -D -m 0755 $(@D)/parse-edid $(TARGET_DIR)/usr/bin/parse-edid
+endef
I.e, you need to repeat the filename in the second argument, and those non-essential binaries should probably live in usr/bin/ rather than bin/.
Can you take Baruch and my comments into account and post an updated version?
Thanks!
Thomas
Signature · 4 lines
Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com