Skip to contentSkip to conversation

nv50/pgraph: DATA_ERROR 0x24

PATCH In review Marcin Slusarz 2 participants 4 messages May 6, 2012 3 messages not in the archive

lore
Share & tools
lore

Marcin Slusarz

author
#0 lore raw

PATCH 1/1 nv50/pgraph: DATA_ERROR 0x24

---
 rnndb/nv50_pgraph.xml |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
rnndb/nv50_pgraph.xml +3 -0
index 92d69ea..6499631 100644
@@ -93,6 +93,9 @@
 	<value value="0x23" name="XY_OUT_OF_BOUNDS"> <!-- m2mf at least. 2d too? -->
 		<brief>Your x/y coords exceed the size of your surface.</brief>
 	</value>
+	<value value="0x24" name="VP_NO_INPUT_MASK">
+		<brief>You tried to submit vertices without setting input mask (VP_ATTR_EN).</brief>
+	</value>
 	<value value="0x27" name="CP_MORE_PARAMS_THAN_SHARED">
 		<brief>You tried to launch block with more params than allocated s[] space.</brief>
 	</value>
Signature · 1 line
1.7.8.5

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw
Quoted 10 lines · Marcin Slusarz
---
  rnndb/nv50_pgraph.xml |    3 +++
  1 files changed, 3 insertions(+), 0 deletions(-)
rnndb/nv50_pgraph.xml +0 -0
index 92d69ea..6499631 100644

rnndb/nv50_pgraph.xml line 101

Quoted 9 lines
rnndb/nv50_pgraph.xml +3 -0
@@ -93,6 +93,9 @@
  	<value value="0x23" name="XY_OUT_OF_BOUNDS">  <!-- m2mf at least. 2d too? -->
  		<brief>Your x/y coords exceed the size of your surface.</brief>
  	</value>
+	<value value="0x24" name="VP_NO_INPUT_MASK">
+		<brief>You tried to submit vertices without setting input mask (VP_ATTR_EN).</brief>
+	</value>
  	<value value="0x27" name="CP_MORE_PARAMS_THAN_SHARED">
  		<brief>You tried to launch block with more params than allocated s[] space.</brief>
  	</value>

Could we get a better name + description for that? The error happens when there are no enabled inputs (VP_ATTR_EN is set, but is 0), not when it's not set at all. VP_ZERO_INPUTS or VP_NO_INPUTS perhaps?

Also, have you checked if that error happens on all submission methods, or just VERTEX_DATA? I don't see why VERTEX_ELEMENT / VERTEX_BUFFER_COUNT would have a problem with 0 inputs.

Marcin Kościelnicki
_______________________________________________
Nouveau mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/nouveau

A message that is not in the archive (sent off-list or not yet received): [email protected]

author
#4 lore raw
Quoted 16 lines · Marcin Kościelnicki
Quoted 15 lines · Marcin Slusarz
---
  rnndb/nv50_pgraph.xml |    3 +++
  1 files changed, 3 insertions(+), 0 deletions(-)
rnndb/nv50_pgraph.xml +2 -0
index 92d69ea..6499631 100644
@@ -93,6 +93,9 @@
  	<value value="0x23" name="XY_OUT_OF_BOUNDS">  <!-- m2mf at least. 2d too? -->
  		<brief>Your x/y coords exceed the size of your surface.</brief>
  	</value>
+	<value value="0x24" name="VP_NO_INPUT_MASK">
+		<brief>You tried to submit vertices without setting input mask (VP_ATTR_EN).</brief>
Quoted 8 lines

rnndb/nv50_pgraph.xml line 101

Quoted 4 lines
rnndb/nv50_pgraph.xml +1 -0
+	</value>
  	<value value="0x27" name="CP_MORE_PARAMS_THAN_SHARED">
  		<brief>You tried to launch block with more params than allocated s[] space.</brief>
  	</value>

Could we get a better name + description for that? The error happens when there are no enabled inputs (VP_ATTR_EN is set, but is 0), not when it's not set at all. VP_ZERO_INPUTS or VP_NO_INPUTS perhaps?

Yes, that's correct.

Quoted 3 lines

Also, have you checked if that error happens on all submission methods, or just VERTEX_DATA? I don't see why VERTEX_ELEMENT / VERTEX_BUFFER_COUNT would have a problem with 0 inputs.

It definitely has problems with VERTEX_BUFFER_COUNT, only later I discovered VERTEX_DATA have them too. I didn't check VB_ELEMENT_*, but I bet it's the same story.

Marcin

---
From: Marcin Slusarz <[email protected]>
Subject: [PATCH] nv50/pgraph: DATA_ERROR 0x24

---
 rnndb/nv50_pgraph.xml |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
rnndb/nv50_pgraph.xml +3 -0
index 92d69ea..aa925fa 100644
@@ -93,6 +93,9 @@
 	<value value="0x23" name="XY_OUT_OF_BOUNDS"> <!-- m2mf at least. 2d too? -->
 		<brief>Your x/y coords exceed the size of your surface.</brief>
 	</value>
+	<value value="0x24" name="VP_ZERO_INPUTS">
+		<brief>You tried to submit vertices with VP input mask (VP_ATTR_EN) set to 0.</brief>
+	</value>
 	<value value="0x27" name="CP_MORE_PARAMS_THAN_SHARED">
 		<brief>You tried to launch block with more params than allocated s[] space.</brief>
 	</value>
Signature · 5 lines
1.7.8.5
_______________________________________________
Nouveau mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/nouveau

A message that is not in the archive (sent off-list or not yet received): [email protected]

#6 lore raw
Quoted 10 lines
Quoted 3 lines

Could we get a better name + description for that? The error happens when there are no enabled inputs (VP_ATTR_EN is set, but is 0), not when it's not set at all. VP_ZERO_INPUTS or VP_NO_INPUTS perhaps?

Yes, that's correct.

Quoted 3 lines

Also, have you checked if that error happens on all submission methods, or just VERTEX_DATA? I don't see why VERTEX_ELEMENT / VERTEX_BUFFER_COUNT would have a problem with 0 inputs.

Quoted 6 lines

It definitely has problems with VERTEX_BUFFER_COUNT, only later I discovered VERTEX_DATA have them too. I didn't check VB_ELEMENT_*, but I bet it's the same story.

Marcin

Thanks, pushed.