Skip to contentSkip to conversation

Kirwood: Add Iomega Iconnect support

PATCH New Arnaud Patard (Rtp) 3 participants 11 messages Apr 18, 2012 – May 11, 2012

lore
Share & tools
lore
#0 lore raw

v2 cover Kirwood: Add Iomega Iconnect support

This patchset is a new try to merge support for the iconnect platforms. Compared to v1, this one is adding also a (forgotten) patch I made to fix led blinking and a patch creating a common function for it, to avoid code duplication.

Arnaud Patard

#4 lore raw

PATCH v2 3/3 kirkwood: Add iconnect support

Quoted 4 lines · Arnaud Patard

Add support for Iomega Iconnect system.

Arnaud,

I have so far been unable to get a kernel to boot with your patches. I just get

Uncompressing Linux... done, booting the kernel.

then nothing even with earlyprintk in the cmd line.

I applied the patches to a recent clone of Linus' tree as they depend on other device tree work that isn't in the latest stable kernel - I haven't yet verified if that tree boots as if it were a RD88F6281 with your changes disabled so that is probably my next step.

I've also hit the issue of the stock U-Boot not supporting DTB so am running with
CONFIG_ARM_APPENDED_DTB=y
CONFIG_ARM_ATAG_DTB_COMPAT=y
Have you been using the latter option or are you just using the settings in your dtb file? I'm assuming that you are running with an initrd, so far I've been trying to run without one hence I was hoping to be able to set the rootfs location on the kernel command line.

Regards

AdamBaker

#5 lore raw

PATCH v2 3/3 kirkwood: Add iconnect support

Adam Baker <[email protected]> writes:

Hi,

Quoted 6 lines · Arnaud Patard
Quoted 4 lines

Add support for Iomega Iconnect system.

Quoted 6 lines

Arnaud,

I have so far been unable to get a kernel to boot with your patches. I just get

Uncompressing Linux... done, booting the kernel.

hm. sounds weird. Are you sure that you have the DTB appended to your kernel image ?

Quoted 7 lines

then nothing even with earlyprintk in the cmd line.

I applied the patches to a recent clone of Linus' tree as they depend on other device tree work that isn't in the latest stable kernel - I haven't yet verified if that tree boots as if it were a RD88F6281 with your changes disabled so that is probably my next step.

With device-tree, you don't have to worry with your machine number.

Quoted 7 lines

I've also hit the issue of the stock U-Boot not supporting DTB so am running with
CONFIG_ARM_APPENDED_DTB=y
CONFIG_ARM_ATAG_DTB_COMPAT=y
Have you been using the latter option or are you just using the settings in your dtb file? I'm assuming that you are running with an initrd, so far I've

It depends on what your boot media is. For instance if you boot your kernel and the rootfs on usb and necessary modules built-in you can boot directly with things like root=/dev/sdaX rootwait.

Quoted 2 lines

been trying to run without one hence I was hoping to be able to set the rootfs location on the kernel command line.

either you use ARM_ATAG_DTB_COMPAT and set the command line on from uboot or you don't set it and set the command line from the dts file.

Arnaud

#6 lore raw

PATCH v2 3/3 kirkwood: Add iconnect support

Quoted 11 lines · Arnaud Patard

Adam Baker <[email protected]> writes:

Hi,

Quoted 7 lines · Arnaud Patard
Quoted 3 lines

Add support for Iomega Iconnect system.

Arnaud,

Quoted 7 lines
Quoted 4 lines

I have so far been unable to get a kernel to boot with your patches. I just get

Uncompressing Linux... done, booting the kernel.

hm. sounds weird. Are you sure that you have the DTB appended to your kernel image ?

Yes, if I don't append the DTB and I set ArcNumber to 1682 then it boots using the ref board setup, if the DTB is appended then it doesn't boot (I configured the kernel to support iconnect, dreamplug and RD-88F6281)

Quoted 8 lines
Quoted 7 lines

I've also hit the issue of the stock U-Boot not supporting DTB so am running with
CONFIG_ARM_APPENDED_DTB=y
CONFIG_ARM_ATAG_DTB_COMPAT=y
Have you been using the latter option or are you just using the settings in your dtb file? I'm assuming that you are running with an initrd, so far I've

Quoted 4 lines

It depends on what your boot media is. For instance if you boot your kernel and the rootfs on usb and necessary modules built-in you can boot directly with things like root=/dev/sdaX rootwait.

That's exactly how I had been booting it with my old kernel, I was just wondering what your setup is to help narrow down the difference that means yours works and mine doesn't.

Quoted 6 lines
Quoted 2 lines

been trying to run without one hence I was hoping to be able to set the rootfs location on the kernel command line.

either you use ARM_ATAG_DTB_COMPAT and set the command line on from uboot or you don't set it and set the command line from the dts file.

I tried disabling ARM_ATAG_DTB_COMPAT and setting my desired command line in the dts but that didn't help. I'll have to give some thought to what to try next.

Adam

P.S. I note your LED names don't have the platform name in fromnt of them - I thought that was normally included to avoid any confusion with LED names for attached peripherals.

#7 lore raw

PATCH v2 3/3 kirkwood: Add iconnect support

Adam Baker <[email protected]> writes:

Hi,

Quoted 15 lines · Arnaud Patard
Quoted 14 lines

Adam Baker <[email protected]> writes:

Hi,

Quoted 10 lines · Arnaud Patard
Quoted 3 lines

Add support for Iomega Iconnect system.

Arnaud,

I have so far been unable to get a kernel to boot with your patches. I just get

Quoted 8 lines
Quoted 4 lines
Quoted 1 line

Uncompressing Linux... done, booting the kernel.

hm. sounds weird. Are you sure that you have the DTB appended to your kernel image ?

Yes, if I don't append the DTB and I set ArcNumber to 1682 then it boots using the ref board setup, if the DTB is appended then it doesn't boot (I configured the kernel to support iconnect, dreamplug and RD-88F6281)

hm. ok. Can you provide your uImage/kernel config/modules/ and which sources you've used... so that I can try to reproduce / boot your kernel?

Arnaud

#8 lore raw

PATCH v2 3/3 kirkwood: Add iconnect support

Quoted 24 lines · Arnaud Patard

Adam Baker <[email protected]> writes:

Hi,

Quoted 20 lines · Arnaud Patard
Quoted 18 lines

Adam Baker <[email protected]> writes:

Hi,

Quoted 11 lines · Arnaud Patard
Quoted 3 lines

Add support for Iomega Iconnect system.

Arnaud,

I have so far been unable to get a kernel to boot with your patches. I just get

Uncompressing Linux... done, booting the kernel.

hm. sounds weird. Are you sure that you have the DTB appended to your kernel image ?

Quoted 7 lines
Quoted 3 lines

Yes, if I don't append the DTB and I set ArcNumber to 1682 then it boots using the ref board setup, if the DTB is appended then it doesn't boot (I configured the kernel to support iconnect, dreamplug and RD-88F6281)

hm. ok. Can you provide your uImage/kernel config/modules/ and which sources you've used... so that I can try to reproduce / boot your kernel?

Arnaud has spotted that my kernel config was missing CONFIG_SERIAL_OF_PLATFORM which is why I was getting no output from it. After fixing that I've got a working system, therefore

I have verified that all of the LED options work, that the reset and OTB buttons generate the expected codes (I think the reason Iomega chose odd SW_ values is simply those are the first 2 defined values in linux/input.h) and that the mtd partitions start at the correct offsets for what they claim to contain (although the last one might make more sense called root rather than boot). I've verified that the WLAN interface works but not tested wired ethernet.

Unfortunately CONFIG_SERIAL_OF_PLATFORM has dependencies so it wouldn't be a good idea for CONFIG_MACH_ICONNECT_DT to select it. There could be some value in it making the default value for CONFIG_SERIAL_OF_PLATFORM=y.

Regards

Adam

#9 lore raw

PATCH v2 3/3 kirkwood: Add iconnect support

Hi,

I don't see any trace of my patch in arm-soc#for-next. Did I miss to address some comments, preventing it to be merged ?

Thanks,
Arnaud

#10 lore raw

PATCH v2 3/3 kirkwood: Add iconnect support

Quoted 4 lines · Arnaud Patard

Hi,

I don't see any trace of my patch in arm-soc#for-next. Did I miss to address some comments, preventing it to be merged ?

Nope, I'm just a little behind. Hopefully I'll get it moving in the next day or two.

thx,

Jason.