Skip to contentSkip to conversation

Deadlock in VFS on corrupted filesystem

DISCUSSION Jan Kara 2 participants 2 messages May 10, 2012 – May 13, 2012 VFS

lore
Share & tools
lore

Jan Kara

author reviewer
#0 lore raw

Hello Al!

Sami found in his testing a rather easy way to deadlock a system with
corrupted filesystem: Just have a directory D and inside D a directory entry pointing to D itself (e.g. corrupt '.' directory entry to have other name). Then when you try to remove the corrupted directory entry system will deadlock because we will try to lock D both as a parent and a child.

Generally, when the directory structure is corrupted so that cycles are created, our locking protocol is prone to deadlocks. This is somewhat unpleasant if you have a system where you allow mounting untrusted media. So my question is: Do we care? And if yes, how to best fix this? My naive idea would be that we could check in d_instantiate() whether we are creating a directory dentry and if yes, check that inode is not already attached to a directory hierarchy (i.e. effectively forbid directory hardlinks). But this might be a bit tricky given dentry aliases. So what are your thoughts?

Honza

Signature · 2 lines
Jan Kara <[email protected]>
SUSE Labs, CR
#1 lore raw
Quoted 9 lines · Jan Kara

Generally, when the directory structure is corrupted so that cycles are created, our locking protocol is prone to deadlocks. This is somewhat unpleasant if you have a system where you allow mounting untrusted media. So my question is: Do we care? And if yes, how to best fix this? My naive idea would be that we could check in d_instantiate() whether we are creating a directory dentry and if yes, check that inode is not already attached to a directory hierarchy (i.e. effectively forbid directory hardlinks). But this might be a bit tricky given dentry aliases. So what are your thoughts?

Besides being a potential security problem, two other possible considerations come to my mind. Not saying that either of these need necessarily be big concern, just my thoughts:

* I think it could be sensibly argued that a filesystem implementation where the flipping of a single bit in a filesystem image can cause a deadlock is not very robust, i.e. this could plausibly happen without any malice;

* From testing perspective, and especially fuzz testing perspective, the tolerated presence of such flaws makes finding other, unrelated problems harder.

Sami