Skip to contentSkip to conversation

regulator: tps62360: Fix build error due to missing semicolon

PATCH In review Axel Lin 3 participants 4 messages May 14, 2012 Voltage and current regulator framework

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 regulator: tps62360: Fix build error due to missing semicolon

Fix below build error:
CC [M] drivers/regulator/tps62360-regulator.o
drivers/regulator/tps62360-regulator.c:351:1: error: expected ',' or ';' before 'extern' make[2]: *** [drivers/regulator/tps62360-regulator.o] Error 1
make[1]: *** [drivers/regulator] Error 2
make: *** [drivers] Error 2

Signed-off-by Axel Lin <[email protected]>
---
 drivers/regulator/tps62360-regulator.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/regulator/tps62360-regulator.c +1 -1
index 60765cc..82cd763 100644
@@ -347,7 +347,7 @@ static const struct of_device_id tps62360_of_match[] = {
 	 { .compatible = "ti,tps62362", .data = (void *)TPS62362},
 	 { .compatible = "ti,tps62363", .data = (void *)TPS62363},
 	{},
-}
+};
 MODULE_DEVICE_TABLE(of, tps62360_of_match);
 #endif
Signature · 1 line
1.7.5.4
Acked-by on v1 1/1
#1 lore raw
Quoted 17 lines · Axel Lin

Fix below build error:
CC [M] drivers/regulator/tps62360-regulator.o
drivers/regulator/tps62360-regulator.c:351:1: error: expected ',' or ';' before 'extern' make[2]: *** [drivers/regulator/tps62360-regulator.o] Error 1
make[1]: *** [drivers/regulator] Error 2
make: *** [drivers] Error 2

Signed-off-by Axel Lin<[email protected]>
---
  drivers/regulator/tps62360-regulator.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
drivers/regulator/tps62360-regulator.c +0 -0
index 60765cc..82cd763 100644

drivers/regulator/tps62360-regulator.c static const struct of_device_id tps62360_of_match[] = { · line 353

Quoted 8 lines
drivers/regulator/tps62360-regulator.c +1 -1
@@ -347,7 +347,7 @@ static const struct of_device_id tps62360_of_match[] = {
  	 { .compatible = "ti,tps62362", .data = (void *)TPS62362},
  	 { .compatible = "ti,tps62363", .data = (void *)TPS62363},
  	{},
-}
+};
  MODULE_DEVICE_TABLE(of, tps62360_of_match);
  #endif

Really strange!! I am not getting this compilation error in my build.

Acked-by Laxman Dewangan <[email protected]>
#2 lore raw
Quoted 8 lines · Laxman Dewangan
Quoted 3 lines · Axel Lin

Fix below build error:
CC [M] drivers/regulator/tps62360-regulator.o
drivers/regulator/tps62360-regulator.c:351:1: error: expected ',' or ';' before 'extern'

Really strange!! I am not getting this compilation error in my build.

Acked-by Laxman Dewangan <[email protected]>

I suspect it's due to a CONFIG_OF difference. Applied, thanks. Are you OK with Axel's patches to rc5t583? I'd been holing off on them for your review.

#3 lore raw
In reply to Laxman Dewangan
Quoted 28 lines · Laxman Dewangan
Quoted 17 lines · Axel Lin

Fix below build error:
CC [M] drivers/regulator/tps62360-regulator.o
drivers/regulator/tps62360-regulator.c:351:1: error: expected ',' or ';' before 'extern' make[2]: *** [drivers/regulator/tps62360-regulator.o] Error 1
make[1]: *** [drivers/regulator] Error 2
make: *** [drivers] Error 2

Signed-off-by Axel Lin<[email protected]>
---
   drivers/regulator/tps62360-regulator.c |    2 +-
   1 files changed, 1 insertions(+), 1 deletions(-)
drivers/regulator/tps62360-regulator.c +0 -0
index 60765cc..82cd763 100644

drivers/regulator/tps62360-regulator.c static const struct of_device_id tps62360_of_match[] = { · line 353

Quoted 8 lines
drivers/regulator/tps62360-regulator.c +1 -1
@@ -347,7 +347,7 @@ static const struct of_device_id tps62360_of_match[] = {
   	 { .compatible = "ti,tps62362", .data = (void *)TPS62362},
   	 { .compatible = "ti,tps62363", .data = (void *)TPS62363},
   	{},
-}
+};
   MODULE_DEVICE_TABLE(of, tps62360_of_match);
   #endif

Really strange!! I am not getting this compilation error in my build.

Quoted 2 lines
Acked-by Laxman Dewangan<[email protected]>

Got reproduced this error if I compile the driver as module. Now onwards, I will compile as y and m for any change. Sorry for inconvenience and thanks for fixing this.