cx23885-dvb: Remove a dirty hack that would require DVBv3

Hi, I'm working some new Smatch stuff and sending bug reports for old code. -Dan

---
This is a semi-automatic email about new static checker warnings.

The patch a7d44baaed0a: "[media] cx23885-dvb: Remove a dirty hack that would require DVBv3" from Dec 26, 2011, leads to the following Smatch complaint:

drivers/media/video/cx23885/cx23885-dvb.c:137 cx23885_dvb_gate_ctrl()

	 error: we previously assumed 'fe->dvb.frontend' could be null (see line 130)

drivers/media/video/cx23885/cx23885-dvb.c
129
130 if (fe && fe->dvb.frontend && fe->dvb.frontend->ops.i2c_gate_ctrl)

                    ^^^^^^^^^^^^^^^^^^^^^^

Old check.

131 fe->dvb.frontend->ops.i2c_gate_ctrl(fe->dvb.frontend, open);
132
133 /*
134 * FIXME: Improve this path to avoid calling the
135 * cx23885_dvb_set_frontend() every time it passes here.
136 */

   137		cx23885_dvb_set_frontend(fe->dvb.frontend);
                                         ^^^^^^^^^^^^^^^^

New call to cx23885_dvb_set_frontend(). If "fe->dvb.frontend" is NULL then we will oops in cx23885_dvb_set_frontend(). Also if "fe" is NULL we'll oops right here.

138 }
139

regards,
dan carpenter