m28evk: use same notation to alloc the 128kB stack

Signed-off-by Otavio Salvador <[email protected]>

Cc Marek Vasut <[email protected]>

Cc Stefano Babic <[email protected]>

Cc Wolfgang Denk <[email protected]>

---
 include/configs/m28evk.h |    2 --
 1 file changed, 2 deletions(-)

include/configs/m28evk.h +0 -0

index a076aa5..29ea8eb 100644

Please drop the other one, so this is the same as mx28evk.h and we can easily unify it. btw how did you find this?

Quoted 2 lines

Please drop the other one, so this is the same as mx28evk.h and we can easily unify it. btw how did you find this?

Good; will check it.

I found it when looking about common stuff in boad configs; I am still willing to try to have a common header file for both but I am first interested in move i.MX23 further.

You submit your MX23 stuff, let's get that in. Then we can start with this consolidation. Is it OK?

Quoted 2 lines

You submit your MX23 stuff, let's get that in. Then we can start with this consolidation. Is it OK?

This works but wouldn't be better to avoid a duplication before it? It doesn't matter for me but I'd prefer it fixed.

Quoted 2 lines

This works but wouldn't be better to avoid a duplication before it? It doesn't matter for me but I'd prefer it fixed.

I'm all for applying this 2/3, the rest should be discussed more thoroughly.

Quoted 5 lines

Quoted 2 lines

This works but wouldn't be better to avoid a duplication before it? It doesn't matter for me but I'd prefer it fixed.

I'm all for applying this 2/3, the rest should be discussed more thoroughly.

I checked mx28evk and m28evk config and both are setting CONFIG_OF_LIBFDT at same place now. It seems this patch is the way to go. Please take a look and confirm it.

Signed-off-by Otavio Salvador <[email protected]>

Cc Marek Vasut <[email protected]>

Cc Stefano Babic <[email protected]>

Cc Wolfgang Denk <[email protected]>

---

+ ? ? ? "loaduimage=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${uimage}\0" \
+ ? ? ? "mmcboot=echo Booting from mmc ...; " \
+ ? ? ? ? ? ? ? "run mmcargs; " \
+ ? ? ? ? ? ? ? "bootm\0" \
+ ? ? ? "netargs=setenv bootargs console=ttymxc0,${baudrate} " \

Quoted 5 lines · Otavio Salvador

+ ? ? ? "loaduimage=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${uimage}\0" \
+ ? ? ? "mmcboot=echo Booting from mmc ...; " \
+ ? ? ? ? ? ? ? "run mmcargs; " \
+ ? ? ? ? ? ? ? "bootm\0" \
+ ? ? ? "netargs=setenv bootargs console=ttymxc0,${baudrate} " \

No, ttymxc0 is wrong for mx28. You should use console=${console}.

The environment has been based on mx53loco and m28evk but keeping the possibility to easy change the default console device as Freescale and mainline kernels differ on the device name.

Signed-off-by Otavio Salvador <[email protected]>

Cc Marek Vasut <[email protected]>

Cc Stefano Babic <[email protected]>

Cc Wolfgang Denk <[email protected]>

Cc Fabio Estevam <[email protected]>

---
 include/configs/mx28evk.h |   83 ++++++++++++++++++++++++++++++++++++++++-----
 1 file changed, 75 insertions(+), 8 deletions(-)

Starting by now, I will NAK all these patches that get posted and reposted and reposted again continuously ignoring the rules for patch submissions.

The environment has been based on mx53loco and m28evk but keeping the possibility to easy change the default console device as Freescale and mainline kernels differ on the device name.

Signed-off-by Otavio Salvador <[email protected]>

Cc Marek Vasut <[email protected]>

Cc Stefano Babic <[email protected]>

Cc Wolfgang Denk <[email protected]>

Cc Fabio Estevam <[email protected]>

---
 include/configs/mx28evk.h |   83

++++++++++++++++++++++++++++++++++++++++----- 1 file changed, 75 insertions(+), 8 deletions(-)

include/configs/mx28evk.h +67 -8

index e98a746..6c2bf5f 100644
@@ -234,7 +234,6 @@
 #define CONFIG_SETUP_MEMORY_TAGS
 #define CONFIG_BOOTDELAY	3
 #define CONFIG_BOOTFILE	"uImage"
-#define CONFIG_BOOTCOMMAND	"run bootcmd_net"
 #define CONFIG_LOADADDR	0x42000000
 #define CONFIG_SYS_LOAD_ADDR	CONFIG_LOADADDR
 #define CONFIG_OF_LIBFDT

@@ -243,13 +242,81 @@
  * Extra Environments
  */
 #define CONFIG_EXTRA_ENV_SETTINGS \
-	"console_fsl=console=ttyAM0" \
-	"console_mainline=console=ttyAMA0" \
-	"netargs=setenv bootargs console=${console_mainline}" \
+	"update_nand_full_filename=u-boot.nand\0" \
+	"update_nand_firmware_filename=u-boot.sb\0"	\
+	"update_sd_firmware_filename=u-boot.sd\0" \
+	"update_nand_firmware_maxsz=0x100000\0"	\
+	"update_nand_stride=0x40\0"	/* MX28 datasheet ch. 12.12 */ \
+	"update_nand_count=0x4\0"	/* MX28 datasheet ch. 12.12 */ \
+	"update_nand_get_fcb_size="	/* Get size of FCB blocks */ \
+		"nand device 0 ; " \
+		"nand info ; " \
+		"setexpr fcb_sz ${update_nand_stride} * ${update_nand_count};" \
+		"setexpr update_nand_fcb ${fcb_sz} * ${nand_writesize}\0" \
+	"update_nand_full="		    /* Update FCB, DBBT and FW */ \
+		"if tftp ${update_nand_full_filename} ; then " \
+		"run update_nand_get_fcb_size ; " \
+		"nand scrub -y 0x0 ${filesize} ; " \
+		"nand write.raw ${loadaddr} 0x0 ${update_nand_fcb} ; " \
+		"setexpr update_off ${loadaddr} + ${update_nand_fcb} ; " \
+		"setexpr update_sz ${filesize} - ${update_nand_fcb} ; " \
+		"nand write ${update_off} ${update_nand_fcb} ${update_sz} ; " \
+		"fi\0" \
+	"update_nand_firmware="		/* Update only firmware */ \
+		"if tftp ${update_nand_firmware_filename} ; then " \
+		"run update_nand_get_fcb_size ; " \
+		"setexpr fcb_sz ${update_nand_fcb} * 2 ; " /* FCB + DBBT */ \
+		"setexpr fw_sz ${update_nand_firmware_maxsz} * 2 ; " \
+		"setexpr fw_off ${fcb_sz} + ${update_nand_firmware_maxsz};" \
+		"nand erase ${fcb_sz} ${fw_sz} ; " \
+		"nand write ${loadaddr} ${fcb_sz} ${filesize} ; " \
+		"nand write ${loadaddr} ${fw_off} ${filesize} ; " \
+		"fi\0" \
+	"update_sd_firmware="		/* Update the SD firmware partition */ \
+		"if mmc rescan ; then "	\
+		"if tftp ${update_sd_firmware_filename} ; then " \
+		"setexpr fw_sz ${filesize} / 0x200 ; "	/* SD block size */ \
+		"setexpr fw_sz ${fw_sz} + 1 ; "	\
+		"mmc write ${loadaddr} 0x800 ${fw_sz} ; " \
+		"fi ; "	\
+		"fi\0" \
+	"script=boot.scr\0"	\
+	"uimage=uImage\0" \
+	"console_fsl=ttyAM0\0" \
+	"console_mainline=ttyAMA0\0" \
+	"console=${console_mainline}\0" \
+	"mmcdev=0\0" \
+	"mmcpart=2\0" \
+	"mmcroot=/dev/mmcblk0p3 rw\0" \
+	"mmcrootfstype=ext3 rootwait\0"	\
+	"mmcargs=setenv bootargs console=${console},${baudrate} " \
+		"root=${mmcroot} " \
+		"rootfstype=${mmcrootfstype}\0"	\
+	"loadbootscript="  \
+		"fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0" \
+	"bootscript=echo Running bootscript from mmc ...; "	\
+		"source\0" \
+	"loaduimage=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${uimage}\0" \
+	"mmcboot=echo Booting from mmc ...; " \
+		"run mmcargs; "	\
+		"bootm\0" \
+	"netargs=setenv bootargs console=ttymxc0,${baudrate} " \
 		"root=/dev/nfs " \
-		"ip=dhcp nfsroot=${serverip}:${nfsroot}\0" \
-	"bootcmd_net=echo Booting from net ...; " \
-		"run netargs; " \
-		"dhcp ${uimage}; bootm\0" \
+		"ip=dhcp nfsroot=${serverip}:${nfsroot},v3,tcp\0" \
+	"netboot=echo Booting from net ...; " \
+		"run netargs; "	\
+		"dhcp ${uimage}; bootm\0"
+
+#define CONFIG_BOOTCOMMAND \
+	"if mmc rescan ${mmcdev}; then " \
+		"if run loadbootscript; then " \

Quoted 2 lines

But I like this patch. On the other hand, can't this be made even more generic so everyone can use such a nice unified env?

I tried something in this direction but Wolfgang NACKed the patch. It wasn't clear to me what he wants so I preferred to go again with mx28evk patch only.

Dear Otavio Salvador,

Quoted 3 lines

I tried something in this direction but Wolfgang NACKed the patch. It wasn't clear to me what he wants so I preferred to go again with mx28evk patch only.

Well ... it might have been a good idea to discuss it with WD. I think we discussed some time ago that universal default env would be very cool.

I can work on that as far as I know what people expect to have. In meanwhile I'd prefer to have this in since it allow the default environment to just work in our BSP layer for OpenEmbedded.

Dear Otavio Salvador,

In message <CAP9ODKqPY51QzdLPejC4GyO3H-

Quoted 3 lines

I can work on that as far as I know what people expect to have. In meanwhile I'd prefer to have this in since it allow the default environment to just work in our BSP layer for OpenEmbedded.

There is no such thing as "the default environment".

The default environment is vendor specific at bets, and usualy board specific. As explained before, I will not accept the Freescale style on boards maintained by DENX.

Not because I consider it inherently bad, but for example because it is different from what we, our customers, our documentation and our test scripts are used to.

Best regards,

Wolfgang Denk

Quoted 4 lines

Not because I consider it inherently bad, but for example because it is different from what we, our customers, our documentation and our test scripts are used to.

Then I guess some kind of "common env" for all boards won't happen ?

The environment has been based on mx53loco and m28evk but keeping the possibility to easy change the default console device as Freescale and mainline kernels differ on the device name.

Signed-off-by Otavio Salvador <[email protected]>

Cc Marek Vasut <[email protected]>

Cc Stefano Babic <[email protected]>

Cc Wolfgang Denk <[email protected]>

Is this really necessary? I think it's a matter of personal taste, isn't it?