source-check: change behavior to check only selected packages / add source-check-all

PATCH RESEND New Thomas De Schampheleire 4 participants 4 messages May 15, 2012 – May 16, 2012 Kbuild

Share & tools

Thomas De Schampheleire

author

2012-05-15 18:43 UTC #0 lore raw

PATCH RESEND 1/1 source-check: change behavior to check only selected packages / add source-check-all

The original 'source-check' target first selects all packages, and then checks whether the package tarballs can be found. This is useful for Buildroot maintainers, but less useful for developers working on a specific project. The latter only care about the packages used in that project.

This patch removes the allyesconfig dependency to source-check so that only selected packages are checked. The original behavior is moved to a new target 'source-check-all'.

Signed-off-by Thomas De Schampheleire <[email protected]>

---
 Makefile |  8 +++++---
 1 files changed, 5 insertions(+), 3 deletions(-)

Makefile +5 -3

@@ -48,7 +48,7 @@ export BR2_VERSION_FULL:=$(BR2_VERSION)$
 noconfig_targets:=menuconfig nconfig gconfig xconfig config oldconfig randconfig \
 	defconfig %_defconfig savedefconfig allyesconfig allnoconfig silentoldconfig release \
 	randpackageconfig allyespackageconfig allnopackageconfig \
-	source-check print-version
+	source-check source-check-all print-version
 
 # Strip quotes and then whitespaces
 qstrip=$(strip $(subst ",,$(1)))

@@ -584,7 +584,8 @@ savedefconfig: $(BUILD_DIR)/buildroot-co
 	@$(COMMON_CONFIG_ENV) $< --savedefconfig=$(CONFIG_DIR)/defconfig $(CONFIG_CONFIG_IN)
 
 # check if download URLs are outdated
-source-check: allyesconfig
+source-check-all: allyesconfig source-check
+source-check:
 	$(MAKE) DL_MODE=SOURCE_CHECK $(EXTRAMAKEARGS) source
 
 endif # ifeq ($(BR2_HAVE_DOT_CONFIG),y)

@@ -671,7 +672,8 @@ endif
 	@echo
 	@echo 'Miscellaneous:'
 	@echo '  source                 - download all sources needed for offline-build'
-	@echo '  source-check           - check all packages for valid download URLs'
+	@echo '  source-check           - check selected packages for valid download URLs'
+	@echo '  source-check-all       - check all packages for valid download URLs'
 	@echo '  external-deps          - list external packages used'
 	@echo
 	@echo '  make V=0|1             - 0 => quiet build (default), 1 => verbose build'

Arnout Vandecappelle

2012-05-15 20:45 UTC #1 lore raw

PATCH RESEND 1/1 source-check: change behavior to check only selected packages / add source-check-all

Quoted 10 lines · Thomas De Schampheleire

The original 'source-check' target first selects all packages, and then checks whether the package tarballs can be found. This is useful for Buildroot maintainers, but less useful for developers working on a specific project. The latter only care about the packages used in that project.
This patch removes the allyesconfig dependency to source-check so that only selected packages are checked. The original behavior is moved to a new target 'source-check-all'.
Signed-off-by Thomas De Schampheleire<[email protected]>

Acked-by Arnout Vandecappelle (Essensium/Mind) <[email protected]>

Signature · 6 lines

Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

Luca Ceresoli

2012-05-16 11:02 UTC #2 lore raw

PATCH RESEND 1/1 source-check: change behavior to check only selected packages / add source-check-all

In reply to Thomas De Schampheleire

Quoted 11 lines · Thomas De Schampheleire

The original 'source-check' target first selects all packages, and then checks whether the package tarballs can be found. This is useful for Buildroot maintainers, but less useful for developers working on a specific project. The latter only care about the packages used in that project.
This patch removes the allyesconfig dependency to source-check so that only selected packages are checked. The original behavior is moved to a new target 'source-check-all'.
Signed-off-by Thomas De Schampheleire<[email protected]>

Acked-by Luca Ceresoli <[email protected]>

Luca

Thomas Petazzoni

2012-05-16 11:41 UTC #3 lore raw

PATCH RESEND 1/1 source-check: change behavior to check only selected packages / add source-check-all

In reply to Thomas De Schampheleire

Le Tue, 15 May 2012 20:43:03 +0200,
Thomas De Schampheleire <[email protected]> a ?crit :

Quoted 10 lines

The original 'source-check' target first selects all packages, and then checks whether the package tarballs can be found. This is useful for Buildroot maintainers, but less useful for developers working on a specific project. The latter only care about the packages used in that project.
This patch removes the allyesconfig dependency to source-check so that only selected packages are checked. The original behavior is moved to a new target 'source-check-all'.
Signed-off-by Thomas De Schampheleire <[email protected]>

Acked-by Thomas Petazzoni <[email protected]>

Signature · 4 lines

Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com