Skip to contentSkip to conversation

USB keyboard stops working occasionally

-next regression Jiri Slaby 2 participants 3 messages May 19, 2012 – May 28, 2012 1 message not in the archive

Subsystems (3)
lore
Share & tools
lore

Jiri Slaby

author
#0 lore raw

Hi,

sometimes, in the middle of writing, my USB HID keyboard stops sending interrupts (no changes in /proc/interrupts). I have to hit a key on another USB interface of that keyboard to resurrect the other. It happens once or twice a day. It happens with -next since around Friday 4th.

I tried to bisect it a bit (three or four times because of fuzz) in the past 3 weeks and my suspect number one is currently:
commit 3d9545cc375d117554a9b35dfddadf9189c62775

Author: Alan Stern <[email protected]>
Date:   Mon Apr 23 13:54:36 2012 -0400
    EHCI: maintain the ehci->command value properly

===

I'm currently running on -next 20120518 with that commit reverted for one whole day and the issue seems to be gone.

Could you take a look and double-check that commit? (Or do you have any other ideas where to take a look?)

thanks,

Signature · 2 lines
js
suse labs

A message that is not in the archive (sent off-list or not yet received): [email protected]

Acked-by Alan Stern
#2 lore raw
Quoted 15 lines · Jiri Slaby

Hi,

sometimes, in the middle of writing, my USB HID keyboard stops sending interrupts (no changes in /proc/interrupts). I have to hit a key on another USB interface of that keyboard to resurrect the other. It happens once or twice a day. It happens with -next since around Friday 4th.

I tried to bisect it a bit (three or four times because of fuzz) in the past 3 weeks and my suspect number one is currently:
commit 3d9545cc375d117554a9b35dfddadf9189c62775

Author: Alan Stern <stern-nwvwT67g6+6dFdvTe/[email protected]>
Date:   Mon Apr 23 13:54:36 2012 -0400
    EHCI: maintain the ehci->command value properly
Quoted 7 lines

===

I'm currently running on -next 20120518 with that commit reverted for one whole day and the issue seems to be gone.

Could you take a look and double-check that commit? (Or do you have any other ideas where to take a look?)

Yes, we realized this a few days ago, and I committed a fix for this a few hours ago to the usb-next tree, and should show up in the next -next release.

I've included the patch below that should fix this problem, please let me know if it doesn't for you.

thanks,

greg k-h

Quoted 1 line

From 1c01f1d9a603ecf1744ae2d1a015c4b27c2b9fa0 Mon Sep 17 00:00:00 2001

From: Ming Lei <[email protected]>
Date: Sat, 19 May 2012 23:11:19 +0800
Subject: [PATCH] USB: EHCI: fix command register configuration lost problem

The 3d9545cc375d117554a9b35dfddadf9189c62775(EHCI: maintain the ehci->command value properly) introducs one command register configuration lost problem by the below line in ehci_reset:

	ehci->command = ehci_readl(ehci, &ehci->regs->command);

After writting RESET into command register, it is restored to its default value per EHCI spec[1], so the previous configuration will be lost, and may introduce some problems reported recently:
- imx51 Babbage board detect usb hub failed[2], reported by Richard Zhao.
- mouse and keyboard hangs in linux-next found by Dan Carpenter and Greg-KH.

So this patch just removes the line to fix these problems, and keep configurating command register consistent as before the commit 3d9545cc(EHCI: maintain the ehci->command value properly).

[1], 4.1 Host Controller Initialization of EHCI Specification 1.0
[2], failed dmesg log:
usb 1-1: new high-speed USB device number 2 using mxc-ehci
hub 1-1:1.0: USB hub found
hub 1-1:1.0: 7 ports detected
mxc-ehci mxc-ehci.1: fatal error
mxc-ehci mxc-ehci.1: HC died; cleaning up
mxc-ehci mxc-ehci.1: force halt; handshake f5780344 00004000 00004000 -> -110 mxc-ehci mxc-ehci.1: HC died; cleaning up
usb 1-1: USB disconnect, device number 2

drivers/usb/host/ehci-hcd.c +0 -1
index f644ba9..5597e60 100644
@@ -352,7 +352,6 @@ static int ehci_reset (struct ehci_hcd *ehci)
 	if (ehci->debug)
 		dbgp_external_startup();
 
-	ehci->command = ehci_readl(ehci, &ehci->regs->command);
 	ehci->port_c_suspend = ehci->suspended_ports =
 			ehci->resuming_ports = 0;
 	return retval;
author
#3 lore raw
Quoted 24 lines · Greg Kroah-Hartman
Quoted 15 lines · Jiri Slaby

Hi,

sometimes, in the middle of writing, my USB HID keyboard stops sending interrupts (no changes in /proc/interrupts). I have to hit a key on another USB interface of that keyboard to resurrect the other. It happens once or twice a day. It happens with -next since around Friday 4th.

I tried to bisect it a bit (three or four times because of fuzz) in the past 3 weeks and my suspect number one is currently:
commit 3d9545cc375d117554a9b35dfddadf9189c62775

Author: Alan Stern <[email protected]>
Date:   Mon Apr 23 13:54:36 2012 -0400
    EHCI: maintain the ehci->command value properly
Quoted 7 lines

===

I'm currently running on -next 20120518 with that commit reverted for one whole day and the issue seems to be gone.

Could you take a look and double-check that commit? (Or do you have any other ideas where to take a look?)

Quoted 6 lines

Yes, we realized this a few days ago, and I committed a fix for this a few hours ago to the usb-next tree, and should show up in the next -next release.

I've included the patch below that should fix this problem, please let me know if it doesn't for you.

FWIW after running the kernel a couple of days without a glitch I can conclude that it is fixed now.

thanks,

Signature · 2 lines
js
suse labs