Skip to contentSkip to conversation

dlm: remove stray unlock

PATCH New Dan Carpenter 2 participants 2 messages May 21, 2012

Subsystems (2)
Kernel janitors Distributed lock manager (DLM)
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 dlm: remove stray unlock

Smatch complains that we unlock this twice. It looks like an accidental to me.

Signed-off-by Dan Carpenter <[email protected]>

---
This was added in 525f31c1f3 ("dlm: fix race between remove and lookup") Untested.

fs/dlm/lock.c +0 -1
index 06063a3..1c10bf4 100644
@@ -1570,7 +1570,6 @@ static void wait_pending_remove(struct dlm_rsb *r_new)
 			continue;
 		if (rsb_cmp(r_new, r->res_name, r->res_length))
 			continue;
-		spin_unlock(&ls->ls_send_remove_spin);
 
 		log_debug(ls, "delay lookup %p for remove %p dir %d %s",
 		  	  r_new, r, r_new->res_dir_nodeid, r_new->res_name);
maintainer
#1 lore raw

PATCH 1/1 dlm: remove stray unlock

Quoted 2 lines · Dan Carpenter

Smatch complains that we unlock this twice. It looks like an accidental to me.

Thanks, will fix that.