Skip to contentSkip to conversation

net: Fix smc911x Ethernet driver warning

PATCH New Joe Hershberger 3 participants 4 messages May 21, 2012 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: Fix smc911x Ethernet driver warning

Fix this warning:
smc911x.c: In function 'smc911x_initialize':
smc911x.c:288:12: warning: assignment from incompatible pointer type [enabled by default]

Tested on omap3_overo

---
 drivers/net/smc911x.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/smc911x.c +1 -1
index e34b487..3911989 100644
@@ -162,7 +162,7 @@ static int smc911x_init(struct eth_device *dev, bd_t * bd)
 }
 
 static int smc911x_send(struct eth_device *dev,
-			volatile void *packet, int length)
+			void *packet, int length)
 {
 	u32 *data = (u32*)packet;
 	u32 tmplen;
Signature · 1 line
1.6.0.2
#1 lore raw

PATCH 1/1 net: Fix smc911x Ethernet driver warning

Hi Joe,

Quoted 3 lines · On Mon, 21 May 2012 12:21:53 -0500 Joe Hershberger <[email protected]>…

Fix this warning:
smc911x.c: In function 'smc911x_initialize':
smc911x.c:288:12: warning: assignment from incompatible pointer type [enabled by default]

just a note: some patches for similar issues already exist on patchwork:

http://patchwork.ozlabs.org/patch/160294/
http://patchwork.ozlabs.org/patch/160293/
http://patchwork.ozlabs.org/patch/160292/
http://patchwork.ozlabs.org/patch/160291/

unfortunately I forgot to cc you, sorry.

Thanks,
Anatolij

#2 lore raw

PATCH 1/1 net: Fix smc911x Ethernet driver warning

Hi Anatolij,

Quoted 9 lines · Anatolij Gustschin

Hi Joe,

Quoted 3 lines · On Mon, 21 May 2012 12:21:53 -0500 Joe Hershberger <[email protected]>…

Fix this warning:
smc911x.c: In function 'smc911x_initialize':
smc911x.c:288:12: warning: assignment from incompatible pointer type [enabled by default]

Quoted 7 lines

just a note: some patches for similar issues already exist on patchwork:

http://patchwork.ozlabs.org/patch/160294/
http://patchwork.ozlabs.org/patch/160293/
http://patchwork.ozlabs.org/patch/160292/
http://patchwork.ozlabs.org/patch/160291/

Thanks for submitting the patches. Were you able to test them out on hardware? If so, please comment what hardware.

Thanks,
-Joe

#3 lore raw

PATCH 1/1 net: Fix smc911x Ethernet driver warning

Hi Joe,

On Mon, 21 May 2012 13:20:40 -0500
Joe Hershberger <[email protected]> wrote:
...

Quoted 10 lines
Quoted 7 lines

just a note: some patches for similar issues already exist on patchwork:

http://patchwork.ozlabs.org/patch/160294/
http://patchwork.ozlabs.org/patch/160293/
http://patchwork.ozlabs.org/patch/160292/
http://patchwork.ozlabs.org/patch/160291/

Thanks for submitting the patches. Were you able to test them out on hardware? If so, please comment what hardware.

I only tested the patch http://patchwork.ozlabs.org/patch/160291/
on the TQM5200 board. For other 4 patches I do not have the hardware to test.

I'm going to fix drivers/net/4xx_enet.c, too. I have the HW to test it and hope to submit a patch soon.

Thanks,

Anatolij