Skip to contentSkip to conversation

mfd: Add terminating entry for i2c_device_id table

PATCH In review Axel Lin 3 participants 3 messages May 21, 2012 – May 22, 2012

Subsystems (2)
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 mfd: Add terminating entry for i2c_device_id table

The i2c_device_id table is supposed to be zero-terminated.

---
 drivers/mfd/palmas.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/mfd/palmas.c +1 -0
index 00c0aba..5d896b3 100644
@@ -472,6 +472,7 @@ static const struct i2c_device_id palmas_i2c_id[] = {
 	{ "twl6035", },
 	{ "twl6037", },
 	{ "tps65913", },
+	{ /* end */ }
 };
 MODULE_DEVICE_TABLE(i2c, palmas_i2c_id);
 
Signature · 1 line
1.7.5.4
#1 lore raw
Quoted 3 lines · Axel Lin

The i2c_device_id table is supposed to be zero-terminated.

Samuel, Linus already pulled the regmap tree so this should probably go via MFD as a bug fix? Might have to wait to after -rc1 to avoid you having to rebase though...

#2 lore raw

Hi Mark,

Quoted 8 lines · Mark Brown
Quoted 3 lines · Axel Lin

The i2c_device_id table is supposed to be zero-terminated.

Samuel, Linus already pulled the regmap tree so this should probably go via MFD as a bug fix? Might have to wait to after -rc1 to avoid you having to rebase though...

Yes, I'm queueing this one for my first post merge window pull request.

Cheers,
Samuel.

Signature · 2 lines
Intel Open Source Technology Centre
http://oss.intel.com/