staging: comedi: remove this_board macro in the aio_aio12_8 driver
PATCH 1/1 staging: comedi: remove this_board macro in the aio_aio12_8 driver
The 'thisboard' macro depends on having a local variable with a magic name. The CodingStyle document suggests not doing this to avoid confusion. Remove the macro and use the comedi_board() inline helper to get the dev->board_ptr information.
Signed-off-by H Hartley Sweeten <[email protected]>
Cc Ian Abbott <[email protected]>
Cc Mori Hess <[email protected]>
Cc Greg Kroah-Hartman <[email protected]>
---
drivers/staging/comedi/drivers/aio_aio12_8.c +2 -3
@@ -80,8 +80,6 @@ static const struct aio12_8_boardtype board_types[] = { .name = "aio_aio12_8"}, }; -#define thisboard ((const struct aio12_8_boardtype *) dev->board_ptr) -struct aio12_8_private {unsigned int ao_readback[4 ]; };
@@ -167,6 +165,7 @@ static const struct comedi_lrange range_aio_aio12_8 = {static int aio_aio12_8_attach (struct comedi_device *dev,struct comedi_devconfig *it) { +const struct aio12_8_boardtype *board =comedi_board (dev);int iobase;struct comedi_subdevice *s;
@@ -176,7 +175,7 @@ static int aio_aio12_8_attach(struct comedi_device *dev,return -EIO ; } - dev->board_name = thisboard->name; + dev->board_name = board->name; dev->iobase = iobase;