Skip to contentSkip to conversation

vfs: increment iversion when a file is truncated

PATCH New [email protected] 1 participant 1 message May 29, 2012 VFS

lore
Share & tools
lore
#0 lore raw

PATCH 1/6 vfs: increment iversion when a file is truncated

From: Dmitry Kasatkin <[email protected]>
Subject: vfs: increment iversion when a file is truncated

When a file is truncated with truncate()/ftruncate() and then closed, iversion is not updated. This patch uses ATTR_SIZE flag as an indication to increment iversion.

Mimi said:

On fput(), i_version is used to detect and flag files that have changed and need to be re-measured in the IMA measurement policy. When a file is truncated with truncate()/ftruncate() and then closed, i_version is not updated. As a result, although the file has changed, it will not be re-measured and added to the IMA measurement list on subsequent access.

---

 fs/attr.c |    5 +++++
 1 file changed, 5 insertions(+)
fs/attr.c renamed from fs/attr.c~vfs-increment-iversion-when-a-file-is-truncated +5 -0
diff -puN fs/attr.c~vfs-increment-iversion-when-a-file-is-truncated fs/attr.c
@@ -176,6 +176,11 @@ int notify_change(struct dentry * dentry
 			return -EPERM;
 	}
 
+	if ((ia_valid & ATTR_SIZE) && IS_I_VERSION(inode)) {
+		if (attr->ia_size != inode->i_size)
+			inode_inc_iversion(inode);
+	}
+
 	if ((ia_valid & ATTR_MODE)) {
 		umode_t amode = attr->ia_mode;
 		/* Flag setting protected by i_mutex */

_