mx28evk: Scan only first 128MB of DRAM to avoid memory wraparound
PATCH v2 1/1 mx28evk: Scan only first 128MB of DRAM to avoid memory wraparound
From: Fabio Estevam <[email protected]>
Scan only first 128MB of DRAM to avoid memory wraparound.
This fixes mx28evk boot and it follows the same idea of commit 19a2066b57 (M28: Scan only first 512 MB of DRAM to avoid memory wraparound)
---
Change since v1:
- Set the RAM size as 128MB.
include/configs/mx28evk.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
include/configs/mx28evk.h +1 -1
@@ -75,7 +75,7 @@*/ #define CONFIG_NR_DRAM_BANKS 1/* 1 bank of DRAM */ #define PHYS_SDRAM_1 0x40000000/* Base address */ -#define PHYS_SDRAM_1_SIZE 0x40000000/* Max 1 GB RAM */ +#define PHYS_SDRAM_1_SIZE 0x08000000/* 128MB RAM */ #define CONFIG_STACKSIZE (128 * 1024)/* 128 KB stack */ #define CONFIG_SYS_MALLOC_LEN 0x00400000/* 4 MB for malloc */ #define CONFIG_SYS_MEMTEST_START 0x40000000/* Memtest start adr */
Signature · 1 line
1.7.1
PATCH v2 1/1 mx28evk: Scan only first 128MB of DRAM to avoid memory wraparound
Dear Fabio Estevam,
Quoted 11 lines · In message <[email protected]> you wrote:
From: Fabio Estevam <[email protected]>
Scan only first 128MB of DRAM to avoid memory wraparound.
This fixes mx28evk boot and it follows the same idea of commit
19a2066b57(M28: Scan only first 512 MB of DRAM to avoid memory wraparound)Signed-off-by Fabio Estevam <[email protected]>---
Change since v1:
- Set the RAM size as 128MB.
I think this is the wrong approach. We should let get_ram_size() do it's job. Or can you explain why it isn't working for you?
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de It would seem that evil retreats when forcibly confronted -- Yarnek of Excalbia, "The Savage Curtain", stardate 5906.5
PATCH v2 1/1 mx28evk: Scan only first 128MB of DRAM to avoid memory wraparound
Hi Wolfgang,
Quoted 2 lines · Wolfgang Denk
I think this is the wrong approach. ?We should let
get_ram_size()do it's job. ?Or can you explain why it isn't working for you?
I haven't done a deeper investigation yet, but with current u-boot-imx I cannot get mx28evk to boot.
If I revert this commit:
commit acc4959fc1b3e61beb372f686595eb2f90240c92
Author: Marek Vasut <[email protected]> Date: Thu May 3 05:47:18 2012 +0000
Revert "i.MX28: Enable additional DRAM address bits"
,then it boots fine.
I followed then the same approach of commit:
commit 19a2066b578f826c7bcb2b96a90434382e8ec8f3
Author: Marek Vasut <[email protected]> Date: Thu May 3 05:47:19 2012 +0000
M28: Scan only first 512 MB of DRAM to avoid memory wraparound
,that fixed the boot.
Also, on the other i.MX boards we put the total size of RAM in the config files, and I did the same here with this patch.
If anyone has better suggestion on how to better handle this, please let know.
Regards,
Fabio Estevam
PATCH v2 1/1 mx28evk: Scan only first 128MB of DRAM to avoid memory wraparound
Dear Fabio Estevam,
Quoted 3 lines · In message <CAOMZO5AoXTbc1ELHoPLoicuwcf9rSuZZLUcKdyzWwyRfbDHC8Q@mail.gmail.com>…
Also, on the other i.MX boards we put the total size of RAM in the config files, and I did the same here with this patch.
This is a really bad habit that I would like to see eradicated rather sooner than later.
Best regards,
Wolfgang Denk
Signature · 4 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Use the Force, Luke.
PATCH v2 1/1 mx28evk: Scan only first 128MB of DRAM to avoid memory wraparound
Dear Wolfgang Denk,
Quoted 3 lines
Dear Fabio Estevam,
In message
Quoted 5 lines · <CAOMZO5AoXTbc1ELHoPLoicuwcf9rSuZZLUcKdyzWwyRfbDHC8Q@mail.gmail.com> you wrote:
Quoted 2 lines
Also, on the other i.MX boards we put the total size of RAM in the config files, and I did the same here with this patch.
This is a really bad habit that I would like to see eradicated rather sooner than later.
I've been thinking about it, maybe you can use the memory configuration adjustment function -- mx28_adjust_memory_params(). You shouldn't have the wraparound there then and you should be able to scan whole 1 gig of DRAM :)
Quoted 3 lines
Best regards,
Wolfgang Denk
Best regards,
Marek Vasut
PATCH v2 1/1 mx28evk: Scan only first 128MB of DRAM to avoid memory wraparound
Hi Marek,
Quoted 2 lines · Marek Vasut
I've been thinking about it, maybe you can use the memory configuration adjustment function --
mx28_adjust_memory_params(). You shouldn't have the
Care to send a patch to fix this?
As the patch in this thread will not be accepted, mx28evk does not boot in u-boot-imx anymore.
Quoted 1 line
wraparound there then and you should be able to scan whole 1 gig of DRAM :)
Just curious: why the value of 1GB was chosen?
Regards,
Fabio Estevam
PATCH v2 1/1 mx28evk: Scan only first 128MB of DRAM to avoid memory wraparound
Dear Fabio Estevam,
Quoted 8 lines
Hi Marek,
Quoted 3 lines · Marek Vasut
I've been thinking about it, maybe you can use the memory configuration adjustment function --
mx28_adjust_memory_params(). You shouldn't have theCare to send a patch to fix this?
I thought I did ... lousy me, sent ;-)
Quoted 8 lines
As the patch in this thread will not be accepted, mx28evk does not boot in u-boot-imx anymore.
Quoted 2 lines
wraparound there then and you should be able to scan whole 1 gig of DRAM :)
Just curious: why the value of 1GB was chosen?
That's the maximum amount of DRAM MX28 can handle.
Quoted 4 lines
Regards,
Fabio Estevam
Best regards,
Marek Vasut