New package: freerdp

PATCH New Julian Lunz 3 participants 5 messages May 23, 2012 – May 30, 2012

lore

Share & tools

lore

Julian Lunz

author

2012-05-23 21:45 UTC #0 lore raw

PATCH 1/1 New package: freerdp

Signed-off-by Julian Lunz <[email protected]>

---
 package/Config.in          |    1 +
 package/freerdp/Config.in  |   38 ++++++++++++++++++++++++++++++++++++++
 package/freerdp/freerdp.mk |   41 +++++++++++++++++++++++++++++++++++++++++
 3 files changed, 80 insertions(+), 0 deletions(-)
 create mode 100644 package/freerdp/Config.in
 create mode 100644 package/freerdp/freerdp.mk

package/Config.in +1 -0

index fb1b08f..dc683aa 100644
@@ -144,6 +144,7 @@ comment "X applications"
 source "package/alsamixergui/Config.in"
 source "package/docker/Config.in"
 source "package/feh/Config.in"
+source "package/freerdp/Config.in"
 source "package/gqview/Config.in"
 source "package/gmpc/Config.in"
 source "package/gob2/Config.in"

package/freerdp/Config.in new file +38 -0

new file mode 100644
index 0000000..b452141
@@ -0,0 +1,38 @@
+menuconfig BR2_PACKAGE_FREERDP
+	bool "freerdp"
+	select BR2_PACKAGE_OPENSSL
+	select BR2_PACKAGE_XLIB_LIBX11
+	select BR2_PACKAGE_XLIB_LIBXT
+	select BR2_PACKAGE_ZLIB
+	depends on BR2_PACKAGE_XORG7
+	help
+	  FreeRDPFreeRDP is a free implementation of the 
+	  Remote Desktop Protocol (RDP), released under the Apache license
+
+	  http://www.freerdp.com/
+	  
+
+if BR2_PACKAGE_FREERDP
+
+config BR2_PACKAGE_FREERDP_WITHCUPS
+	bool "CUPS support"
+	help
+	  Compile with CUPS support.
+	  
+config BR2_PACKAGE_FREERDP_WITHFFMPEG
+	bool "FFmpeg support"
+	help
+	  Compile with FFmpeg support.
+	  
+config BR2_PACKAGE_FREERDP_WITHALSA
+	bool "Alsa support"
+	help
+	  Compile with Alsa support.
+	  
+config BR2_PACKAGE_FREERDP_WITHXINERAMA
+	bool "Xinerama support"
+	help
+	  Compile with Xinerama support.
+
+endif # BR2_PACKAGE_FREERDP
+

package/freerdp/freerdp.mk new file +41 -0

41 lines not on this page · raw message

Signature · 1 line

1.7.0.4

Julian Lunz

author

2012-05-29 18:34 UTC #1 lore raw

PATCH 1/1 New package: freerdp

Hi,

Cared to fix, looking good?

Quoted 113 lines · On Wed, 23 May 2012 23:45:09 +0200 Julian Lunz <[email protected]> wrote:

Signed-off-by Julian Lunz <[email protected]>

---
 package/Config.in          |    1 +
 package/freerdp/Config.in  |   38

++++++++++++++++++++++++++++++++++++++ package/freerdp/freerdp.mk | 41 +++++++++++++++++++++++++++++++++++++++++ 3 files changed, 80 insertions(+), 0 deletions(-) create mode 100644 package/freerdp/Config.in create mode 100644 package/freerdp/freerdp.mk

package/Config.in +1 -0

index fb1b08f..dc683aa 100644
@@ -144,6 +144,7 @@ comment "X applications"
 source "package/alsamixergui/Config.in"
 source "package/docker/Config.in"
 source "package/feh/Config.in"
+source "package/freerdp/Config.in"
 source "package/gqview/Config.in"
 source "package/gmpc/Config.in"
 source "package/gob2/Config.in"

package/freerdp/Config.in new file +10 -0

new file mode 100644
index 0000000..b452141
@@ -0,0 +1,38 @@
+menuconfig BR2_PACKAGE_FREERDP
+	bool "freerdp"
+	select BR2_PACKAGE_OPENSSL
+	select BR2_PACKAGE_XLIB_LIBX11
+	select BR2_PACKAGE_XLIB_LIBXT
+	select BR2_PACKAGE_ZLIB
+	depends on BR2_PACKAGE_XORG7
+	help
+	  FreeRDPFreeRDP is a free implementation of the 
+	  Remote Desktop Protocol (RDP), released under the Apache

license +

package/freerdp/Config.in new file +27 -0

+	  http://www.freerdp.com/
+	  
+
+if BR2_PACKAGE_FREERDP
+
+config BR2_PACKAGE_FREERDP_WITHCUPS
+	bool "CUPS support"
+	help
+	  Compile with CUPS support.
+	  
+config BR2_PACKAGE_FREERDP_WITHFFMPEG
+	bool "FFmpeg support"
+	help
+	  Compile with FFmpeg support.
+	  
+config BR2_PACKAGE_FREERDP_WITHALSA
+	bool "Alsa support"
+	help
+	  Compile with Alsa support.
+	  
+config BR2_PACKAGE_FREERDP_WITHXINERAMA
+	bool "Xinerama support"
+	help
+	  Compile with Xinerama support.
+
+endif # BR2_PACKAGE_FREERDP
+

package/freerdp/freerdp.mk new file +41 -0

new file mode 100644
index 0000000..b947628
@@ -0,0 +1,41 @@
+#############################################################
+#
+# FreeRDP
+#
+#############################################################
+
+FREERDP_VERSION = 1.0.1
+FREERDP_SOURCE = freerdp-$(FREERDP_VERSION).tar.gz
+FREERDP_SITE = https://github.com/downloads/FreeRDP/FreeRDP
+
+ifeq ($(BR2_PACKAGE_FREERDP_WITHCUPS),y)
+FREERDP_CONF_OPT += -DWITH_CUPS=ON
+FREERDP_DEPENDENCIES += cups
+else
+FREERDP_CONF_OPT += -DWITH_CUPS=OFF
+endif
+
+ifeq ($(BR2_PACKAGE_FREERDP_WITHFFMPEG),y)
+FREERDP_CONF_OPT += -DWITH_FFMPEG=ON
+FREERDP_DEPENDENCIES += ffmpeg
+else
+FREERDP_CONF_OPT += -DWITH_FFMPEG=OFF
+endif
+
+ifeq ($(BR2_PACKAGE_FREERDP_WITHALSA),y)
+FREERDP_CONF_OPT += -DWITH_ALSA=ON
+FREERDP_DEPENDENCIES += alsa-utils
+else
+FREERDP_CONF_OPT += -DWITH_ALSA=OFF
+endif
+
+ifeq ($(BR2_PACKAGE_FREERDP_WITHXINERAMA),y)
+FREERDP_CONF_OPT += -DWITH_XINERAMA=ON
+FREERDP_DEPENDENCIES += xlib_libXinerama
+else
+FREERDP_CONF_OPT += -DWITH_XINERAMA=OFF
+endif
+
+FREERDP_DEPENDENCIES += openssl xlib_libX11 xlib_libXt zlib
+
+$(eval $(call CMAKETARGETS))

Arnout Vandecappelle

2012-05-29 19:12 UTC #2 lore raw

PATCH 1/1 New package: freerdp

In reply to Julian Lunz

On 05/23/12 23:45, Julian Lunz wrote:
[snip]

package/freerdp/Config.in line 18

Quoted 4 lines

package/freerdp/Config.in new file +4 -0

+if BR2_PACKAGE_FREERDP
+
+config BR2_PACKAGE_FREERDP_WITHCUPS
+    bool "CUPS support"

You need to add 'select BR2_PACKAGE_CUPS'.

But in fact, in this case I think it could be turned around: compile with
cups support if BR2_PACKAGE_CUPS is selected. I.e., remove these config options and in the .mk file:
[snip]

Quoted 1 line

+ifeq ($(BR2_PACKAGE_FREERDP_WITHCUPS),y)

replace with
ifeq ($(BR2_PACKAGE_CUPS),y)

On the other hand, for some of these (particularly alsa and Xinerama) it's
probably more user-friendly to have a config option like you have now.

Quoted 6 lines

package/freerdp/freerdp.mk new file +6 -0

+FREERDP_CONF_OPT += -DWITH_CUPS=ON
+FREERDP_DEPENDENCIES += cups
+else
+FREERDP_CONF_OPT += -DWITH_CUPS=OFF
+endif
+

package/freerdp/freerdp.mk line 27

Quoted 10 lines

package/freerdp/freerdp.mk new file +10 -0

+ifeq ($(BR2_PACKAGE_FREERDP_WITHFFMPEG),y)
+FREERDP_CONF_OPT += -DWITH_FFMPEG=ON
+FREERDP_DEPENDENCIES += ffmpeg
+else
+FREERDP_CONF_OPT += -DWITH_FFMPEG=OFF
+endif
+
+ifeq ($(BR2_PACKAGE_FREERDP_WITHALSA),y)
+FREERDP_CONF_OPT += -DWITH_ALSA=ON
+FREERDP_DEPENDENCIES += alsa-utils

Shouldn't this be alsa-lib, rather than alsa-utils?

[snip]

Regards,
Arnout

Signature · 6 lines

Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

Julian Lunz

author

2012-05-30 17:53 UTC #3 lore raw

PATCH 1/1 New package: freerdp

Hi Arnout,

thanks for your input!

Quoted 7 lines · On Tue, 29 May 2012 21:12:29 +0200 Arnout Vandecappelle <[email protected]> wrote:

On 05/23/12 23:45, Julian Lunz wrote:
[snip]
package/freerdp/Config.in line 18
Quoted 4 lines
package/freerdp/Config.in new file +4 -0
+if BR2_PACKAGE_FREERDP
+
+config BR2_PACKAGE_FREERDP_WITHCUPS
+    bool "CUPS support"
You need to add 'select BR2_PACKAGE_CUPS'.

Yep, missing for the others as well.

Quoted 9 lines

But in fact, in this case I think it could be turned around:
compile with cups support if BR2_PACKAGE_CUPS is selected. I.e., remove these config options and in the .mk file:
[snip]
Quoted 1 line
+ifeq ($(BR2_PACKAGE_FREERDP_WITHCUPS),y)
replace with
ifeq ($(BR2_PACKAGE_CUPS),y)

True, but I tend to have it stated more explicitly that these options could but mustn't be used.
So it is more a question of how would I buildroot like to behave. A lot of other packages use the mechanism you describe, so what about merging both like that:

(make "logical or")

ifneq (,$(filter y, $(BR2_PACKAGE_CUPS) \
$(BR2_PACKAGE_FREERDP_WITHCUPS)))
...
endif

Quoted 14 lines

On the other hand, for some of these (particularly alsa and
Xinerama) it's probably more user-friendly to have a config option like you have now.
Quoted 9 lines
package/freerdp/freerdp.mk new file +9 -0
+FREERDP_CONF_OPT += -DWITH_CUPS=ON
+FREERDP_DEPENDENCIES += cups
+else
+FREERDP_CONF_OPT += -DWITH_CUPS=OFF
+endif
+
+ifeq ($(BR2_PACKAGE_FREERDP_WITHFFMPEG),y)
+FREERDP_CONF_OPT += -DWITH_FFMPEG=ON
+FREERDP_DEPENDENCIES += ffmpeg

Quoted 8 lines

package/freerdp/freerdp.mk line 27
Quoted 7 lines
package/freerdp/freerdp.mk new file +7 -0
+else
+FREERDP_CONF_OPT += -DWITH_FFMPEG=OFF
+endif
+
+ifeq ($(BR2_PACKAGE_FREERDP_WITHALSA),y)
+FREERDP_CONF_OPT += -DWITH_ALSA=ON
+FREERDP_DEPENDENCIES += alsa-utils
Shouldn't this be alsa-lib, rather than alsa-utils?

Indeed, alsa-lib here.

Quoted 7 lines

[snip]
Regards,
Arnout

Best regards,
Julian

Thomas Petazzoni

2012-05-30 19:04 UTC #4 lore raw

PATCH 1/1 New package: freerdp

Le Wed, 30 May 2012 19:53:34 +0200,
Julian Lunz <[email protected]> a ?crit :

Quoted 6 lines

True, but I tend to have it stated more explicitly that these options could but mustn't be used.
So it is more a question of how would I buildroot like to behave. A lot of other packages use the mechanism you describe, so what about merging both like that:

Quoted 6 lines

(make "logical or")
ifneq (,$(filter y, $(BR2_PACKAGE_CUPS) \
$(BR2_PACKAGE_FREERDP_WITHCUPS)))
...
endif

No, please do like we do for all other packages in Buildroot: simply use them if available, i.e:

ifeq ($(BR2_PACKAGE_CUPS),y)
... do whatever is needed in your package to use cups yourpkg_DEPENDENCIES += cups
else
... do whatever is needed in your package to not use cups endif

Best regards,

Thomas

Signature · 4 lines

Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com