checkpatch: False positive on wrong indentation within block.

PATCH Kamalesh Babulal 1 participant 1 message May 31, 2012 x86

Share & tools

Kamalesh Babulal

author

2012-05-31 11:01 UTC #0 lore raw

Checkpatch does not warns about the wrong indentation within a block. When checkpatch is run on following patch, it does not complain about the wrong indentation of if block.

[...]

arch/x86/kernel/smpboot.c +6 -1

index fd019d7..a8d78f3 100644
@@ -382,7 +382,12 @@ void __cpuinit set_cpu_sibling_map(int cpu)
 		if ((i == cpu) || (has_mc && match_llc(c, o)))
 			link_mask(llc_shared, cpu, i);
 
-		if ((i == cpu) || (has_mc && match_mc(c, o))) {
+	}
+
+	for_each_cpu(i, cpu_sibling_setup_mask) {
+		o = &cpu_data(i);
+
+	if ((i == cpu) || (has_mc && match_mc(c, o))) {
 			link_mask(core, cpu, i);
 
 			/*

$ ./scripts/checkpatch.pl Fix-booted_cores-reporting.patch
total: 0 errors, 0 warnings, 13 lines checked

Fix-booted_cores-reporting.patch has no obvious style problems and is ready for submission.

Thanks,
Kamalesh.