Skip to contentSkip to conversation

Kirkwood: Add support for Ka-Ro TK71

PATCH New Marek Vasut 4 participants 7 messages May 31, 2012 – Jun 4, 2012

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Kirkwood: Add support for Ka-Ro TK71

Cc Prafulla Wadaskar <[email protected]>
Cc Wolfgang Denk <[email protected]>
---
 board/karo/tk71/Makefile         |   45 ++++++++++
 board/karo/tk71/kwbimage-256.cfg |  174 ++++++++++++++++++++++++++++++++++++++
 board/karo/tk71/kwbimage-512.cfg |  174 ++++++++++++++++++++++++++++++++++++++
 board/karo/tk71/tk71.c           |  165 ++++++++++++++++++++++++++++++++++++
 boards.cfg                       |    2 +
 include/configs/tk71.h           |  128 ++++++++++++++++++++++++++++
 6 files changed, 688 insertions(+)
 create mode 100644 board/karo/tk71/Makefile
 create mode 100644 board/karo/tk71/kwbimage-256.cfg
 create mode 100644 board/karo/tk71/kwbimage-512.cfg
 create mode 100644 board/karo/tk71/tk71.c
 create mode 100644 include/configs/tk71.h
board/karo/tk71/Makefile new file +45 -0
new file mode 100644
index 0000000..934e391
@@ -0,0 +1,45 @@
+#
+# Copyright (C) 2012 Marek Vasut <[email protected]>
+# on behalf of DENX Software Engineering GmbH
+#
+#
+# See file CREDITS for list of people who contributed to this
+# project.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.	 See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
+# MA 02110-1301 USA
+#
+
+include $(TOPDIR)/config.mk
+
+LIB	= $(obj)lib$(BOARD).o
+
+COBJS	:= tk71.o
+
+SRCS	:= $(SOBJS:.o=.S) $(COBJS:.o=.c)
+OBJS	:= $(addprefix $(obj),$(COBJS))
+SOBJS	:= $(addprefix $(obj),$(SOBJS))
+
+$(LIB):	$(obj).depend $(OBJS) $(SOBJS)
+	$(call cmd_link_o_target, $(OBJS) $(SOBJS))
+
+#########################################################################
+
+# defines $(obj).depend target
+include $(SRCTREE)/rules.mk
+
+sinclude $(obj).depend
+
+#########################################################################
board/karo/tk71/kwbimage-256.cfg new file +174 -0

174 lines not on this page · raw message

board/karo/tk71/kwbimage-512.cfg new file +174 -0

174 lines not on this page · raw message

board/karo/tk71/tk71.c new file +165 -0

165 lines not on this page · raw message

boards.cfg +2 -0
index 5f328b5..1f6f726 100644
@@ -154,6 +154,8 @@ openrd_ultimate              arm         arm926ejs   openrd              Marvell
 rd6281a                      arm         arm926ejs   -                   Marvell        kirkwood
 sheevaplug                   arm         arm926ejs   -                   Marvell        kirkwood
 dockstar                     arm         arm926ejs   -                   Seagate        kirkwood
+tk71_256mb                   arm         arm926ejs   tk71                karo           kirkwood	tk71:RAM_SIZE=256
+tk71_512mb                   arm         arm926ejs   tk71                karo           kirkwood	tk71:RAM_SIZE=512
 jadecpu                      arm         arm926ejs   jadecpu             syteco         mb86r0x
 mx25pdk                      arm         arm926ejs   mx25pdk             freescale      mx25		mx25pdk:IMX_CONFIG=board/freescale/mx25pdk/imximage.cfg
 tx25                         arm         arm926ejs   tx25                karo           mx25
include/configs/tk71.h new file +128 -0

128 lines not on this page · raw message

Signature · 1 line
1.7.10
#1 lore raw

PATCH 1/1 Kirkwood: Add support for Ka-Ro TK71

Quoted 12 lines

-----Original Message-----
From: Marek Vasut [mailto:marex at denx.de]
Sent: 31 May 2012 16:37
To: u-boot at lists.denx.de
Cc: Marek Vasut; Prafulla Wadaskar; Wolfgang Denk
Subject: [PATCH] Kirkwood: Add support for Ka-Ro TK71

Cc Prafulla Wadaskar <[email protected]>
Cc Wolfgang Denk <[email protected]>
Quoted 6 lines
---
 board/karo/tk71/Makefile         |   45 ++++++++++
 board/karo/tk71/kwbimage-256.cfg |  174
++++++++++++++++++++++++++++++++++++++
 board/karo/tk71/kwbimage-512.cfg |  174

++++++++++++++++++++++++++++++++++++++

Dear Marek
Just for DRAM size change do not add one more cfg file, configure by default 256MB of RAM in default kwbimg.cfg file and in function board_early_init_f() tune it to 512 for your other board version.

Regards..
Prafulla . . .

#2 lore raw

PATCH 1/1 Kirkwood: Add support for Ka-Ro TK71

Dear Prafulla Wadaskar,

Quoted 17 lines
Quoted 17 lines

-----Original Message-----
From: Marek Vasut [mailto:marex at denx.de]
Sent: 31 May 2012 16:37
To: u-boot at lists.denx.de
Cc: Marek Vasut; Prafulla Wadaskar; Wolfgang Denk
Subject: [PATCH] Kirkwood: Add support for Ka-Ro TK71

Cc Prafulla Wadaskar <[email protected]>
Cc Wolfgang Denk <[email protected]>

---

 board/karo/tk71/Makefile         |   45 ++++++++++
 board/karo/tk71/kwbimage-256.cfg |  174

++++++++++++++++++++++++++++++++++++++

Quoted 8 lines
Quoted 3 lines
 board/karo/tk71/kwbimage-512.cfg |  174

++++++++++++++++++++++++++++++++++++++

Dear Marek
Just for DRAM size change do not add one more cfg file, configure by default 256MB of RAM in default kwbimg.cfg file and in function board_early_init_f() tune it to 512 for your other board version.

There's only one single bit flipped between those two kwb configs. Do you think it'd work if we just configured the system for 512MB RAM and ran get_ram_size() to see if it has only 256MB? That'd eliminate two board entries for this tk71.

Quoted 3 lines

Regards..
Prafulla . . .

Best regards,
Marek Vasut

#3 lore raw

PATCH 1/1 Kirkwood: Add support for Ka-Ro TK71

Hi Marek and Prafulla,

Quoted 23 lines · Marek Vasut

Dear Prafulla Wadaskar,

Quoted 21 lines
Quoted 20 lines

-----Original Message-----
From: Marek Vasut [mailto:marex at denx.de]
Sent: 31 May 2012 16:37
To: u-boot at lists.denx.de
Cc: Marek Vasut; Prafulla Wadaskar; Wolfgang Denk
Subject: [PATCH] Kirkwood: Add support for Ka-Ro TK71

Cc Prafulla Wadaskar <[email protected]>
Cc Wolfgang Denk <[email protected]>

---

 board/karo/tk71/Makefile         |   45 ++++++++++
 board/karo/tk71/kwbimage-256.cfg |  174

++++++++++++++++++++++++++++++++++++++

 board/karo/tk71/kwbimage-512.cfg |  174

++++++++++++++++++++++++++++++++++++++

Quoted 9 lines
Quoted 4 lines

Dear Marek
Just for DRAM size change do not add one more cfg file, configure by default 256MB of RAM in default kwbimg.cfg file and in function board_early_init_f() tune it to 512 for your other board version.

There's only one single bit flipped between those two kwb configs. Do you think it'd work if we just configured the system for 512MB RAM and ran get_ram_size() to see if it has only 256MB? That'd eliminate two board entries for this tk71.

I would like to have your advice on this as well Prafulla.

We have tested this on km_arm (we will have the same boards with 1/2 the RAM size) and with the above get_ram_size() it works as expected.

We still should, however, at some point (board_early_init_f() is a good candidate) then reduce the corresponding RAM CS size (reg @1504 for CS0 so that the window is the same size as what was detected by get_ram_size). What do you guys think ?

Valentin

#4 lore raw

PATCH 1/1 Kirkwood: Add support for Ka-Ro TK71

Quoted 55 lines

-----Original Message-----
From: Valentin Longchamp [mailto:valentin.longchamp at keymile.com]
Sent: 04 June 2012 21:07
To: Marek Vasut
Cc: Prafulla Wadaskar; u-boot at lists.denx.de; Holger Brunck
Subject: Re: [PATCH] Kirkwood: Add support for Ka-Ro TK71

Hi Marek and Prafulla,

Quoted 25 lines · Marek Vasut

Dear Prafulla Wadaskar,

Quoted 23 lines
Quoted 12 lines

-----Original Message-----
From: Marek Vasut [mailto:marex at denx.de]
Sent: 31 May 2012 16:37
To: u-boot at lists.denx.de
Cc: Marek Vasut; Prafulla Wadaskar; Wolfgang Denk
Subject: [PATCH] Kirkwood: Add support for Ka-Ro TK71

Cc Prafulla Wadaskar <[email protected]>
Cc Wolfgang Denk <[email protected]>

---

Quoted 8 lines
 board/karo/tk71/Makefile         |   45 ++++++++++
 board/karo/tk71/kwbimage-256.cfg |  174

++++++++++++++++++++++++++++++++++++++

 board/karo/tk71/kwbimage-512.cfg |  174

++++++++++++++++++++++++++++++++++++++

Dear Marek
Just for DRAM size change do not add one more cfg file, configure

by

Quoted 4 lines
Quoted 2 lines

default 256MB of RAM in default kwbimg.cfg file and in function board_early_init_f() tune it to 512 for your other board version.

There's only one single bit flipped between those two kwb configs.

Do you think

Quoted 1 line

it'd work if we just configured the system for 512MB RAM and ran

get_ram_size()

Quoted 1 line

to see if it has only 256MB? That'd eliminate two board entries for

this tk71.

Quoted 1 line

I would like to have your advice on this as well Prafulla.

We have tested this on km_arm (we will have the same boards with 1/2 the RAM
size) and with the above get_ram_size() it works as expected.

Quoted 7 lines

We still should, however, at some point (board_early_init_f() is a good
candidate) then reduce the corresponding RAM CS size (reg @1504 for CS0 so that
the window is the same size as what was detected by get_ram_size). What do you
guys think ?

Dear Valentin
Yes, we should use this method. That's why I always ask if one can reuse any existing kwbimage.cfg.

It makes no sense to add one more file of 250 lines just for one or two difference/s that can be handled through board_early_init_f().

Regards..
Prafulla . . .

#5 lore raw

PATCH 1/1 Kirkwood: Add support for Ka-Ro TK71

Quoted 63 lines · Prafulla Wadaskar
Quoted 55 lines

-----Original Message-----
From: Valentin Longchamp [mailto:valentin.longchamp at keymile.com]
Sent: 04 June 2012 21:07
To: Marek Vasut
Cc: Prafulla Wadaskar; u-boot at lists.denx.de; Holger Brunck
Subject: Re: [PATCH] Kirkwood: Add support for Ka-Ro TK71

Hi Marek and Prafulla,

Quoted 25 lines · Marek Vasut

Dear Prafulla Wadaskar,

Quoted 23 lines
Quoted 12 lines

-----Original Message-----
From: Marek Vasut [mailto:marex at denx.de]
Sent: 31 May 2012 16:37
To: u-boot at lists.denx.de
Cc: Marek Vasut; Prafulla Wadaskar; Wolfgang Denk
Subject: [PATCH] Kirkwood: Add support for Ka-Ro TK71

Cc Prafulla Wadaskar <[email protected]>
Cc Wolfgang Denk <[email protected]>

---

Quoted 8 lines
 board/karo/tk71/Makefile         |   45 ++++++++++
 board/karo/tk71/kwbimage-256.cfg |  174

++++++++++++++++++++++++++++++++++++++

 board/karo/tk71/kwbimage-512.cfg |  174

++++++++++++++++++++++++++++++++++++++

Dear Marek
Just for DRAM size change do not add one more cfg file, configure

by

Quoted 4 lines
Quoted 2 lines

default 256MB of RAM in default kwbimg.cfg file and in function board_early_init_f() tune it to 512 for your other board version.

There's only one single bit flipped between those two kwb configs.

Do you think

Quoted 1 line

it'd work if we just configured the system for 512MB RAM and ran

get_ram_size()

Quoted 1 line

to see if it has only 256MB? That'd eliminate two board entries for

this tk71.

Quoted 1 line

I would like to have your advice on this as well Prafulla.

We have tested this on km_arm (we will have the same boards with 1/2 the RAM
size) and with the above get_ram_size() it works as expected.

Quoted 7 lines

We still should, however, at some point (board_early_init_f() is a good
candidate) then reduce the corresponding RAM CS size (reg @1504 for CS0 so that
the window is the same size as what was detected by get_ram_size). What do you
guys think ?

Quoted 5 lines

Dear Valentin
Yes, we should use this method. That's why I always ask if one can reuse any existing kwbimage.cfg.

It makes no sense to add one more file of 250 lines just for one or two difference/s that can be handled through board_early_init_f().

but how should this work for kwbimabe.cfg files for images which will be downloaded via serial terminal and the runs directly from RAM. This patch is related to this topic:
http://lists.denx.de/pipermail/u-boot/2012-May/124802.html

In this case we change already the *.kwb in that way that we can download it directly into RAM and execute it directly from there. Isn't it mandatory for this usecase to have the exact RAM size specified in u-boot.kwb ? If so the above approach would not work, or we enhance the kwboot tool proposed in the patch with an additional commandline argument for the ramsize.

Regards
Holger

#6 lore raw

PATCH 1/1 Kirkwood: Add support for Ka-Ro TK71

Quoted 90 lines

-----Original Message-----
From: Holger Brunck [mailto:holger.brunck at keymile.com]
Sent: 04 June 2012 21:50
To: Prafulla Wadaskar
Cc: Valentin Longchamp; Marek Vasut; u-boot at lists.denx.de
Subject: Re: [PATCH] Kirkwood: Add support for Ka-Ro TK71

Quoted 38 lines · Prafulla Wadaskar
Quoted 38 lines

-----Original Message-----
From: Valentin Longchamp [mailto:valentin.longchamp at keymile.com]
Sent: 04 June 2012 21:07
To: Marek Vasut
Cc: Prafulla Wadaskar; u-boot at lists.denx.de; Holger Brunck
Subject: Re: [PATCH] Kirkwood: Add support for Ka-Ro TK71

Hi Marek and Prafulla,

Quoted 25 lines · Marek Vasut

Dear Prafulla Wadaskar,

Quoted 23 lines
Quoted 12 lines

-----Original Message-----
From: Marek Vasut [mailto:marex at denx.de]
Sent: 31 May 2012 16:37
To: u-boot at lists.denx.de
Cc: Marek Vasut; Prafulla Wadaskar; Wolfgang Denk
Subject: [PATCH] Kirkwood: Add support for Ka-Ro TK71

Cc Prafulla Wadaskar <[email protected]>
Cc Wolfgang Denk <[email protected]>

---

Quoted 8 lines
 board/karo/tk71/Makefile         |   45 ++++++++++
 board/karo/tk71/kwbimage-256.cfg |  174

++++++++++++++++++++++++++++++++++++++

 board/karo/tk71/kwbimage-512.cfg |  174

++++++++++++++++++++++++++++++++++++++

Dear Marek
Just for DRAM size change do not add one more cfg file, configure

by

Quoted 8 lines
Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

default 256MB of RAM in default kwbimg.cfg file and in function board_early_init_f() tune it to 512 for your other board version.

There's only one single bit flipped between those two kwb configs.

Do you think

Quoted 1 line

it'd work if we just configured the system for 512MB RAM and ran

get_ram_size()

Quoted 1 line

to see if it has only 256MB? That'd eliminate two board entries

for

Quoted 6 lines
Quoted 6 lines

this tk71.

Quoted 1 line

I would like to have your advice on this as well Prafulla.

We have tested this on km_arm (we will have the same boards with

1/2

Quoted 11 lines
Quoted 10 lines

the RAM
size) and with the above get_ram_size() it works as expected.

We still should, however, at some point (board_early_init_f() is a good
candidate) then reduce the corresponding RAM CS size (reg @1504 for CS0 so that
the window is the same size as what was detected by get_ram_size). What do you
guys think ?

Quoted 2 lines

Dear Valentin
Yes, we should use this method. That's why I always ask if one can

reuse any existing kwbimage.cfg.

Quoted 2 lines

It makes no sense to add one more file of 250 lines just for one or

two difference/s that can be handled through board_early_init_f().

Quoted 1 line

but how should this work for kwbimabe.cfg files for images which will be
downloaded via serial terminal and the runs directly from RAM. This patch is
related to this topic:
http://lists.denx.de/pipermail/u-boot/2012-May/124802.html

Quoted 9 lines

In this case we change already the *.kwb in that way that we can download it
directly into RAM and execute it directly from there. Isn't it mandatory for
this usecase to have the exact RAM size specified in u-boot.kwb ? If so the
above approach would not work, or we enhance the kwboot tool proposed in the
patch with an additional commandline argument for the ramsize.

In theory one common kwbimage.cfg should be used by both methods (boot from UART and boot from media)

Currently kwbimage.cfg embeds boot option, it can be abstracted and u-boot.kwb can be prepared for boot from UART or boot from media (flash). This can be addressed through u-boot.kwb target generation ( mkimage tool is not mandatory).

Whereas u-boot.kwb prepared for UART can be fetched by said tool into RAM by Kirkwood and will be executed in the same way (as it fetches and executes from flash)

Regards..
Prafulla . . .