Skip to contentSkip to conversation

luajit: fix dependencies of Lua modules

PATCH New François Perrad 2 participants 4 messages Jun 1, 2012 – Jul 13, 2012

lore
Share & tools
lore
#0 lore raw

PATCH 2/2 luajit: fix dependencies of Lua modules

---
 package/cgilua/Config.in        |    1 -
 package/copas/Config.in         |    1 -
 package/lua/Config.in           |    3 +--
 package/luafilesystem/Config.in |    1 -
 package/luasocket/Config.in     |    1 -
 package/rings/Config.in         |    1 -
 package/xavante/Config.in       |    1 -
 7 files changed, 1 insertion(+), 8 deletions(-)
package/cgilua/Config.in +0 -1
index b43ba97..855ff48 100644
@@ -1,6 +1,5 @@
 config BR2_PACKAGE_CGILUA
 	bool "cgilua"
-	select BR2_PACKAGE_LUA_SHARED_LIBRARY
 	select BR2_PACKAGE_LUAFILESYSTEM
 	help
 	  CGILua is a tool for creating dynamic HTML pages
package/copas/Config.in +0 -1
index 36abcc1..9969c8f 100644
@@ -2,7 +2,6 @@ config BR2_PACKAGE_COPAS
 	bool "copas"
 	select BR2_PACKAGE_COXPCALL
 	select BR2_PACKAGE_LUASOCKET
-	select BR2_PACKAGE_LUA_SHARED_LIBRARY # for luasocket
 	help
 	  Copas is a dispatcher based on coroutines that
 	  can be used by TCP/IP servers.
package/lua/Config.in +1 -2
index 56eba35..b9cde26 100644
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_LUA
 	bool "lua"
+	select BR2_PACKAGE_LUA_SHARED_LIBRARY
 	help
 	  Lua is a powerful, fast, light-weight, embeddable scripting language.
 
@@ -8,14 +9,12 @@ config BR2_PACKAGE_LUA
 config BR2_PACKAGE_LUA_COMPILER
 	bool "lua compiler"
 	depends on BR2_PACKAGE_LUA
-	select BR2_PACKAGE_LUA_SHARED_LIBRARY
 	help
 	  Install luac binary
 
 config BR2_PACKAGE_LUA_INTERPRETER
 	bool "lua interpreter"
 	depends on BR2_PACKAGE_LUA
-	select BR2_PACKAGE_LUA_SHARED_LIBRARY
 	help
 	  Install lua binary
 
package/luafilesystem/Config.in +0 -1
index edcb414..7c130f8 100644
@@ -1,6 +1,5 @@
 config BR2_PACKAGE_LUAFILESYSTEM
 	bool "luafilesystem"
-	select BR2_PACKAGE_LUA_SHARED_LIBRARY
 	help
 	  LuaFileSystem offers a portable way to access
 	  the underlying directory structure and file attributes.
package/luasocket/Config.in +0 -1
index 298db56..4526303 100644
@@ -1,6 +1,5 @@
 config BR2_PACKAGE_LUASOCKET
 	bool "luasocket"
-	depends on BR2_PACKAGE_LUA_SHARED_LIBRARY
 	help
 	  LuaSocket is the most comprehensive networking support library
 	  for the Lua language.
package/rings/Config.in +0 -1
index 2fe14aa..d1f1efe 100644
@@ -1,6 +1,5 @@
 config BR2_PACKAGE_RINGS
 	bool "rings"
-	depends on BR2_PACKAGE_LUA_SHARED_LIBRARY
 	help
 	  Provides a way to create new Lua states from within Lua.
 
package/xavante/Config.in +0 -1
index a7df530..db34d66 100644
@@ -1,6 +1,5 @@
 config BR2_PACKAGE_XAVANTE
 	bool "xavante"
-	select BR2_PACKAGE_LUA_SHARED_LIBRARY
 	select BR2_PACKAGE_CGILUA
 	select BR2_PACKAGE_COPAS
 	select BR2_PACKAGE_COXPCALL
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 2/2 luajit: fix dependencies of Lua modules

Le Fri, 1 Jun 2012 11:58:27 +0200,
Fran?ois Perrad <[email protected]> a ?crit :

Quoted 1 line

I am not a Lua guy, so maybe I'm missing something obvious, but you could expand the justification for this patch, and include this justification in the commit log?

Thanks!

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#2 lore raw

PATCH 2/2 luajit: fix dependencies of Lua modules

2012/6/1 Thomas Petazzoni <[email protected]>:

Quoted 9 lines

Le Fri, 1 Jun 2012 11:58:27 +0200,
Fran?ois Perrad <[email protected]> a ?crit :

Quoted 1 line

I am not a Lua guy, so maybe I'm missing something obvious, but you could expand the justification for this patch, and include this justification in the commit log?

luajit is another Lua 5.1 interpreter, API- and ABI-compatible to the standard one (lua package).
A Lua module (luasocket for example) depends on lua OR luajit (only one is deployed on the target).
The dependency against BR2_PACKAGE_LUA_SHARED_LIBRARY must be removed, because it's an internal of lua package.

Fran?ois

Quoted 12 lines

Thanks!

Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

#3 lore raw

PATCH 2/2 luajit: fix dependencies of Lua modules

2012/6/1 Fran?ois Perrad <[email protected]>:

Quoted 11 lines

2012/6/1 Thomas Petazzoni <[email protected]>:

Quoted 9 lines

Le Fri, 1 Jun 2012 11:58:27 +0200,
Fran?ois Perrad <[email protected]> a ?crit :

Quoted 1 line

I am not a Lua guy, so maybe I'm missing something obvious, but you could expand the justification for this patch, and include this justification in the commit log?

Quoted 8 lines

luajit is another Lua 5.1 interpreter, API- and ABI-compatible to the standard one (lua package).
A Lua module (luasocket for example) depends on lua OR luajit (only one is deployed on the target).
The dependency against BR2_PACKAGE_LUA_SHARED_LIBRARY must be removed, because it's an internal of lua package.

As side effect, this patch solves the building issue of lua in autobuild.builroot.net.

Fran?ois

Quoted 14 lines

Fran?ois

Quoted 12 lines

Thanks!

Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot