Skip to contentSkip to conversation

ARM: OMAP4: hwspinlocks_init() should be static

PATCH New Ohad Ben-Cohen 2 participants 2 messages May 13, 2012 – Jun 4, 2012

Subsystems (3)
Arm (32-bit) Arm sub-architectures OMAP2+ support
lore
Share & tools
lore

Ohad Ben-Cohen

author
#0 lore raw

PATCH 1/1 ARM: OMAP4: hwspinlocks_init() should be static

Sparse found out that hwspinlocks_init() wasn't marked static, and it should've been.

Signed-off-by Ohad Ben-Cohen <[email protected]>
---
 arch/arm/mach-omap2/hwspinlock.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/mach-omap2/hwspinlock.c +1 -1
index 454dfce..8763c85 100644
@@ -28,7 +28,7 @@ static struct hwspinlock_pdata omap_hwspinlock_pdata __initdata = {
 	.base_id = 0,
 };
 
-int __init hwspinlocks_init(void)
+static int __init hwspinlocks_init(void)
 {
 	int retval = 0;
 	struct omap_hwmod *oh;
Signature · 1 line
1.7.5.4
maintainer
#1 lore raw

PATCH 1/1 ARM: OMAP4: hwspinlocks_init() should be static

Quoted 2 lines · Ohad Ben-Cohen

Sparse found out that hwspinlocks_init() wasn't marked static, and it should've been.

Looks like this already got fixed by Paul's commit 8c3d4534.

Regards,

Tony

Quoted 21 lines
Signed-off-by Ohad Ben-Cohen <[email protected]>
---
 arch/arm/mach-omap2/hwspinlock.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/mach-omap2/hwspinlock.c +1 -1
index 454dfce..8763c85 100644
@@ -28,7 +28,7 @@ static struct hwspinlock_pdata omap_hwspinlock_pdata __initdata = {
 	.base_id = 0,
 };
 
-int __init hwspinlocks_init(void)
+static int __init hwspinlocks_init(void)
 {
 	int retval = 0;
 	struct omap_hwmod *oh;
Signature · 1 line
1.7.5.4