Skip to contentSkip to conversation

6lowpan: Incorrect type in lowpan_alloc_new_frame() definition : tag is u8 but should be u16

PATCH In review Tony Cheneau 1 participant 1 message Jun 11, 2012

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 2/4 6lowpan: Incorrect type in lowpan_alloc_new_frame() definition : tag is u8 but should be u16

lowpan_alloc_new_frame() takes u8 tag as an argument. Howerer, its only caller, lowpan_process_data() passes down a u16. Hence, the tag value got corrupted.
This prevent 6lowpan fragment reassembly after 256 fragmented packets have been reassembled by the same recipient.

---
 net/ieee802154/6lowpan.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
net/ieee802154/6lowpan.c +0 -0
index a52e795..af4f29b 100644
@@ -654,7 +654,7 @@ static void lowpan_fragment_timer_expired(unsigned

long entry_addr) }

static struct lowpan_fragment *
-lowpan_alloc_new_frame(struct sk_buff *skb, u8 iphc0, u8 len, u8 tag) +lowpan_alloc_new_frame(struct sk_buff *skb, u8 iphc0, u8 len, u16 tag)
{
struct lowpan_fragment *frame;

Signature · 1 line
1.7.3.4