Skip to contentSkip to conversation

ARM: OMAP2+: cpu: Add am33xx device under cpu_class_is_omap2

PATCH New Vaibhav Hiremath 2 participants 4 messages Jun 9, 2012 – Jun 11, 2012

Subsystems (2)
Arm (32-bit) Arm sub-architectures
lore
Share & tools
lore

Vaibhav Hiremath

author
#0 lore raw

PATCH 1/1 ARM: OMAP2+: cpu: Add am33xx device under cpu_class_is_omap2

Newly added AM33XX device falls under omap2 class, so make cpu_class_is_omap2() true for AM33XX (Add soc_is_am33xx() check).

Signed-off-by Vaibhav Hiremath <[email protected]>
---
 arch/arm/plat-omap/include/plat/cpu.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/plat-omap/include/plat/cpu.h +1 -1
index 14f050f..5e36564 100644
@@ -375,7 +375,7 @@ IS_OMAP_TYPE(3430, 0x3430)
 #define cpu_class_is_omap1()	(cpu_is_omap7xx() || cpu_is_omap15xx() || \
 				cpu_is_omap16xx())
 #define cpu_class_is_omap2()	(cpu_is_omap24xx() || cpu_is_omap34xx() || \
-				cpu_is_omap44xx())
+				cpu_is_omap44xx() || soc_is_am33xx())
 
 /* Various silicon revisions for omap2 */
 #define OMAP242X_CLASS		0x24200024
Signature · 1 line
1.7.0.4
#1 lore raw

PATCH 1/1 ARM: OMAP2+: cpu: Add am33xx device under cpu_class_is_omap2

Quoted 14 lines · Vaibhav Hiremath

Newly added AM33XX device falls under omap2 class, so make cpu_class_is_omap2() true for AM33XX (Add soc_is_am33xx() check).

Signed-off-by Vaibhav Hiremath <[email protected]>
---
 arch/arm/plat-omap/include/plat/cpu.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/plat-omap/include/plat/cpu.h +0 -0
index 14f050f..5e36564 100644

arch/arm/plat-omap/include/plat/cpu.h IS_OMAP_TYPE(3430, 0x3430) · line 381

Quoted 8 lines
arch/arm/plat-omap/include/plat/cpu.h +1 -1
@@ -375,7 +375,7 @@ IS_OMAP_TYPE(3430, 0x3430)
 #define cpu_class_is_omap1()	(cpu_is_omap7xx() || cpu_is_omap15xx() || \
 				cpu_is_omap16xx())
 #define cpu_class_is_omap2()	(cpu_is_omap24xx() || cpu_is_omap34xx() || \
-				cpu_is_omap44xx())
+				cpu_is_omap44xx() || soc_is_am33xx())
 
 /* Various silicon revisions for omap2 */
 #define OMAP242X_CLASS		0x24200024

I think this can be now simply !cpu_class_is_omap1() as there is a very slim chance that we'll ever be compiling omap1 and omap2+ together because of the different compiler flags needed.

Regards,

Tony

author
#2 lore raw

PATCH 1/1 ARM: OMAP2+: cpu: Add am33xx device under cpu_class_is_omap2

Quoted 27 lines · Tony Lindgren
Quoted 14 lines · Vaibhav Hiremath

Newly added AM33XX device falls under omap2 class, so make cpu_class_is_omap2() true for AM33XX (Add soc_is_am33xx() check).

Signed-off-by Vaibhav Hiremath <[email protected]>
---
  arch/arm/plat-omap/include/plat/cpu.h |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/plat-omap/include/plat/cpu.h +0 -0
index 14f050f..5e36564 100644

arch/arm/plat-omap/include/plat/cpu.h IS_OMAP_TYPE(3430, 0x3430) · line 381

Quoted 8 lines
arch/arm/plat-omap/include/plat/cpu.h +1 -1
@@ -375,7 +375,7 @@ IS_OMAP_TYPE(3430, 0x3430)
  #define cpu_class_is_omap1()	(cpu_is_omap7xx() || cpu_is_omap15xx() || \
  				cpu_is_omap16xx())
  #define cpu_class_is_omap2()	(cpu_is_omap24xx() || cpu_is_omap34xx() || \
-				cpu_is_omap44xx())
+				cpu_is_omap44xx() || soc_is_am33xx())
 
  /* Various silicon revisions for omap2 */
  #define OMAP242X_CLASS		0x24200024

I think this can be now simply !cpu_class_is_omap1() as there is a very slim chance that we'll ever be compiling omap1 and omap2+ together because of the different compiler flags needed.

Quoted 3 lines

Regards,

Tony

Ok...

Shall I submit patch with this change?

Thanks,
Vaibhav

#3 lore raw

PATCH 1/1 ARM: OMAP2+: cpu: Add am33xx device under cpu_class_is_omap2

Quoted 27 lines · Vaibhav Hiremath
Quoted 26 lines · Tony Lindgren
Quoted 14 lines · Vaibhav Hiremath

Newly added AM33XX device falls under omap2 class, so make cpu_class_is_omap2() true for AM33XX (Add soc_is_am33xx() check).

Signed-off-by Vaibhav Hiremath <[email protected]>
---
 arch/arm/plat-omap/include/plat/cpu.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/plat-omap/include/plat/cpu.h +0 -0
index 14f050f..5e36564 100644

arch/arm/plat-omap/include/plat/cpu.h IS_OMAP_TYPE(3430, 0x3430) · line 380

Quoted 7 lines
arch/arm/plat-omap/include/plat/cpu.h +1 -1
@@ -375,7 +375,7 @@ IS_OMAP_TYPE(3430, 0x3430)
 #define cpu_class_is_omap1()	(cpu_is_omap7xx() || cpu_is_omap15xx() || \
 				cpu_is_omap16xx())
 #define cpu_class_is_omap2()	(cpu_is_omap24xx() || cpu_is_omap34xx() || \
-				cpu_is_omap44xx())
+				cpu_is_omap44xx() || soc_is_am33xx())
 /* Various silicon revisions for omap2 */
 #define OMAP242X_CLASS		0x24200024

I think this can be now simply !cpu_class_is_omap1() as there is a very slim chance that we'll ever be compiling omap1 and omap2+ together because of the different compiler flags needed.

Quoted 7 lines
Quoted 3 lines

Regards,

Tony

Ok...

Shall I submit patch with this change?

Yes thanks.

Tony