Skip to contentSkip to conversation

regulator: Fix the s5m8767a problem of the division by null

PATCH Applied Sangbeom Kim 2 participants 2 messages Jun 13, 2012

Subsystems (2)
Voltage and current regulator framework Samsung multifunction PMIC device drivers
lore
Share & tools
lore

Sangbeom Kim

author
#0 lore raw

PATCH 2/5 regulator: Fix the s5m8767a problem of the division by null

If ramp_delay is 0, delay value can be divided by zero. This patch can fix the problem.

Signed-off-by Sangbeom Kim <[email protected]>
---
 drivers/regulator/s5m8767.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/regulator/s5m8767.c +1 -1
index 4edf344..ce9dda2 100644
@@ -451,7 +451,7 @@ static int s5m8767_set_voltage_time_sel(struct regulator_dev *rdev,
 
 	desc = reg_voltage_map[reg_id];
 
-	if (old_sel < new_sel)
+	if ((old_sel < new_sel) && s5m8767->ramp_delay)
 		return DIV_ROUND_UP(desc->step * (new_sel - old_sel),
 					s5m8767->ramp_delay * 1000);
 	return 0;
Signature · 1 line
1.7.1
Applied
#1 lore raw
Quoted 2 lines · Sangbeom Kim

If ramp_delay is 0, delay value can be divided by zero. This patch can fix the problem.

Applied, thanks.