Skip to contentSkip to conversation

clk: SPEAr600: Fix ethernet clock name for DT based probing

PATCH New Stefan Roese 5 participants 11 messages May 11, 2012 – Jun 19, 2012

Subsystems (2)
Common clk Spear platform/clock/pinctrl support
lore
Share & tools
lore

Stefan Roese

author
#0 lore raw

PATCH 1/1 clk: SPEAr600: Fix ethernet clock name for DT based probing

Signed-off-by Stefan Roese <[email protected]>
Cc Viresh Kumar <[email protected]>
Cc "Mike Turquette" <[email protected]>
---
 drivers/clk/spear/spear6xx_clock.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/spear/spear6xx_clock.c +1 -1
index f9a20b3..bf33c1d 100644
@@ -298,7 +298,7 @@ void __init spear6xx_clk_init(void)
 
 	clk = clk_register_gate(NULL, "gmac_clk", "ahb_clk", 0, PERIP1_CLK_ENB,
 			GMAC_CLK_ENB, 0, &_lock);
-	clk_register_clkdev(clk, NULL, "gmac");
+	clk_register_clkdev(clk, NULL, "e0800000.ethernet");
 
 	clk = clk_register_gate(NULL, "i2c_clk", "ahb_clk", 0, PERIP1_CLK_ENB,
 			I2C_CLK_ENB, 0, &_lock);
Signature · 1 line
1.7.10.1
#1 lore raw

PATCH 1/1 clk: SPEAr600: Fix ethernet clock name for DT based probing

drivers/clk/spear/spear6xx_clock.c void __init spear6xx_clk_init(void) · line 304

Quoted 13 lines · Stefan Roese
drivers/clk/spear/spear6xx_clock.c +1 -1
index f9a20b3..bf33c1d 100644
@@ -298,7 +298,7 @@ void __init spear6xx_clk_init(void)
 
 	clk = clk_register_gate(NULL, "gmac_clk", "ahb_clk", 0, PERIP1_CLK_ENB,
 			GMAC_CLK_ENB, 0, &_lock);
-	clk_register_clkdev(clk, NULL, "gmac");
+	clk_register_clkdev(clk, NULL, "e0800000.ethernet");
 
 	clk = clk_register_gate(NULL, "i2c_clk", "ahb_clk", 0, PERIP1_CLK_ENB,
 			I2C_CLK_ENB, 0, &_lock);
Acked-by Viresh Kumar <[email protected]>
Signature · 1 line
viresh
#2 lore raw

PATCH 1/1 clk: SPEAr600: Fix ethernet clock name for DT based probing

Quoted 12 lines · Viresh Kumar
Quoted 11 lines · Stefan Roese
drivers/clk/spear/spear6xx_clock.c +1 -1
index f9a20b3..bf33c1d 100644
@@ -298,7 +298,7 @@ void __init spear6xx_clk_init(void)
 
 ? ? ? clk = clk_register_gate(NULL, "gmac_clk", "ahb_clk", 0, PERIP1_CLK_ENB,
 ? ? ? ? ? ? ? ? ? ? ? GMAC_CLK_ENB, 0, &_lock);
- ? ? clk_register_clkdev(clk, NULL, "gmac");
+ ? ? clk_register_clkdev(clk, NULL, "e0800000.ethernet");
Quoted 4 lines

drivers/clk/spear/spear6xx_clock.c void __init spear6xx_clk_init(void) · line 304

Quoted 2 lines
drivers/clk/spear/spear6xx_clock.c +0 -0
 ? ? ? clk = clk_register_gate(NULL, "i2c_clk", "ahb_clk", 0, PERIP1_CLK_ENB,
 ? ? ? ? ? ? ? ? ? ? ? I2C_CLK_ENB, 0, &_lock);
Acked-by Viresh Kumar <[email protected]>

Do you want me to take this? Spear didn't originally go through me but I can take it if that is the intent.

Regards,
Mike

Quoted 3 lines

--
viresh

#3 lore raw

PATCH 1/1 clk: SPEAr600: Fix ethernet clock name for DT based probing

Quoted 4 lines · Mike
Quoted 2 lines · Viresh Kumar

Review

Quoted 1 line · Stefan Roese
(quoted diff) +0 -0

b/drivers/clk/spear/spear6xx_clock.c

Quoted 6 lines
Quoted 6 lines

drivers/clk/spear/spear6xx_clock.c void __init spear6xx_clk_init(void) · line 299

Quoted 6 lines

index f9a20b3..bf33c1d 100644

drivers/clk/spear/spear6xx_clock.c +0 -0
@@ -298,7 +298,7 @@ void __init spear6xx_clk_init(void)
 
      clk = clk_register_gate(NULL, "gmac_clk", "ahb_clk", 0,

PERIP1_CLK_ENB,

Quoted 5 lines
Quoted 5 lines

drivers/clk/spear/spear6xx_clock.c void __init spear6xx_clk_init(void)

Quoted 5 lines
drivers/clk/spear/spear6xx_clock.c +1 -1
                      GMAC_CLK_ENB, 0, &_lock);
-     clk_register_clkdev(clk, NULL, "gmac");
+     clk_register_clkdev(clk, NULL, "e0800000.ethernet");
 
      clk = clk_register_gate(NULL, "i2c_clk", "ahb_clk", 0,

PERIP1_CLK_ENB,

Quoted 7 lines
Quoted 3 lines

drivers/clk/spear/spear6xx_clock.c void __init spear6xx_clk_init(void) · line 304

Quoted 1 line
drivers/clk/spear/spear6xx_clock.c +0 -0
                      I2C_CLK_ENB, 0, &_lock);
Acked-by Viresh Kumar <[email protected]>

Do you want me to take this? Spear didn't originally go through me but I can take it if that is the intent.

Sure. Go ahead.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120516/178decb8/attachment-0001.html>

#4 lore raw

PATCH 1/1 clk: SPEAr600: Fix ethernet clock name for DT based probing

Quoted 24 lines · viresh kumar
Quoted 22 lines · Mike
Quoted 19 lines · Viresh Kumar
Quoted 14 lines · Stefan Roese
drivers/clk/spear/spear6xx_clock.c +1 -1
index f9a20b3..bf33c1d 100644
@@ -298,7 +298,7 @@ void __init spear6xx_clk_init(void)
 
 ? ? ? clk = clk_register_gate(NULL, "gmac_clk", "ahb_clk", 0,
 PERIP1_CLK_ENB,
 ? ? ? ? ? ? ? ? ? ? ? GMAC_CLK_ENB, 0, &_lock);
- ? ? clk_register_clkdev(clk, NULL, "gmac");
+ ? ? clk_register_clkdev(clk, NULL, "e0800000.ethernet");
 
 ? ? ? clk = clk_register_gate(NULL, "i2c_clk", "ahb_clk", 0,
Quoted 2 lines

PERIP1_CLK_ENB,
? ? ? ? ? ? ? ? ? ? ? I2C_CLK_ENB, 0, &_lock);

Acked-by Viresh Kumar <[email protected]>
Quoted 5 lines
Quoted 3 lines

Do you want me to take this? ?Spear didn't originally go through me but I can take it if that is the intent.

Sure. Go ahead.

Oops. I'm working too late. Wasn't thinking.

I don't have spear in my clk-next branch (since clk-next is stable and the spear clock stuff went straight to arm-soc). Instead of having me make a new branch based on arm-soc's latest can you just send this Arnd/Olof?

Thanks,
Mike

author
#5 lore raw

PATCH 1/1 clk: SPEAr600: Fix ethernet clock name for DT based probing

In reply to viresh kumar
Quoted 6 lines · On Wednesday 16 May 2012 07:56:49 viresh kumar wrote:
Quoted 4 lines
Quoted 1 line
Acked-by Viresh Kumar <[email protected]>

Do you want me to take this? Spear didn't originally go through me but I can take it if that is the intent.

Sure. Go ahead.

Ping.

Thanks,
Stefan

author
#6 lore raw

PATCH 1/1 clk: SPEAr600: Fix ethernet clock name for DT based probing

Quoted 9 lines · On Wednesday 06 June 2012 08:46:07 Stefan Roese wrote:
Quoted 6 lines · On Wednesday 16 May 2012 07:56:49 viresh kumar wrote:
Quoted 4 lines
Quoted 1 line
Acked-by Viresh Kumar <[email protected]>

Do you want me to take this? Spear didn't originally go through me but I can take it if that is the intent.

Sure. Go ahead.

Ping.

Ping again (this is a real show-stopper for SPEAr600 in v3.5!).

Thanks,
Stefan

#7 lore raw

PATCH 1/1 clk: SPEAr600: Fix ethernet clock name for DT based probing

Quoted 4 lines · Stefan Roese
Quoted 3 lines · On Wednesday 06 June 2012 08:46:07 Stefan Roese wrote:
Quoted 2 lines · On Wednesday 16 May 2012 07:56:49 viresh kumar wrote:
Quoted 2 lines
Quoted 1 line
Acked-by Viresh Kumar <[email protected]>
Quoted 9 lines
Quoted 6 lines
Quoted 4 lines
Quoted 2 lines

Do you want me to take this? Spear didn't originally go through me but I can take it if that is the intent.

Sure. Go ahead.

Ping.

Ping again (this is a real show-stopper for SPEAr600 in v3.5!).

Hi Stefan,

I've taken this into my clk-next branch already. Sorry if I did not communicate that well enough. I will request for clk-next to be included into linux-next later this week. Hopefully this patch will start showing up in linux-next in a matter of days.

Let me know if there is anything else I can do.

Thanks,
Mike

Quoted 2 lines

Thanks,
Stefan

author
#8 lore raw

PATCH 1/1 clk: SPEAr600: Fix ethernet clock name for DT based probing

Hi Mike,

Quoted 12 lines · On Monday 18 June 2012 19:20:42 Mike Turquette wrote:
Quoted 11 lines · Stefan Roese
Quoted 9 lines · On Wednesday 06 June 2012 08:46:07 Stefan Roese wrote:
Quoted 6 lines · On Wednesday 16 May 2012 07:56:49 viresh kumar wrote:
Quoted 4 lines
Quoted 1 line
Acked-by Viresh Kumar <[email protected]>

Do you want me to take this? Spear didn't originally go through me but I can take it if that is the intent.

Sure. Go ahead.

Ping.

Quoted 8 lines
Quoted 1 line

Ping again (this is a real show-stopper for SPEAr600 in v3.5!).

Hi Stefan,

I've taken this into my clk-next branch already. Sorry if I did not communicate that well enough. I will request for clk-next to be included into linux-next later this week. Hopefully this patch will start showing up in linux-next in a matter of days.

Great. Thanks,
Stefan

#9 lore raw

PATCH 1/1 clk: SPEAr600: Fix ethernet clock name for DT based probing

In reply to Mike Turquette
Quoted 8 lines · Mike Turquette
Quoted 2 lines

Ping again (this is a real show-stopper for SPEAr600 in v3.5!).

I've taken this into my clk-next branch already. Sorry if I did not communicate that well enough. I will request for clk-next to be included into linux-next later this week. Hopefully this patch will start showing up in linux-next in a matter of days.

Let me know if there is anything else I can do.

It sounds to me that Stefan needs this in 3.5, while the clk-next patches are destined for 3.6. Is that correct? If so, do you also have a clk-fixes branch that is targetted at 3.5 regressions?

Arnd

author
#10 lore raw

PATCH 1/1 clk: SPEAr600: Fix ethernet clock name for DT based probing

Quoted 11 lines · On Tuesday 19 June 2012 13:18:42 Arnd Bergmann wrote:
Quoted 8 lines · Mike Turquette
Quoted 1 line

Ping again (this is a real show-stopper for SPEAr600 in v3.5!).

I've taken this into my clk-next branch already. Sorry if I did not communicate that well enough. I will request for clk-next to be included into linux-next later this week. Hopefully this patch will start showing up in linux-next in a matter of days.

Let me know if there is anything else I can do.

It sounds to me that Stefan needs this in 3.5,

Yes. Its definitely a fix for 3.5.

Quoted 3 lines

while the clk-next
patches are destined for 3.6. Is that correct? If so, do you also have a clk-fixes branch that is targetted at 3.5 regressions?

Thanks,
Stefan