Skip to contentSkip to conversation

ARM: mx23: Add initial support for olinuxino board

PATCH Superseded Fabio Estevam 4 participants 7 messages Jun 18, 2012 – Jun 26, 2012

Subsystems (4)

v4 of 5 Superseded Latest is v5 →

lore
Share & tools
lore
#0 lore raw

PATCH v4 1/1 ARM: mx23: Add initial support for olinuxino board

mx23-olinuxino is a low cost board designed by Olimex.

It has the following features:

- Freescale iMX233 ARM926J processor at 454MHz
-64 MB RAM
-SD-card connector
-TV PAL/NTSC video output
-2 USB High Speed Hosts
-Ethernet 100 Mbit
-Stereo Audio Input
-Stereo Headphones Audio Output

More information at:
http://www.olimex.com/dev/imx233-olinuxino-maxi.html

---
Changes since v3:
- Fix the compatible string in imx23_dt_compat
Changes since v2:
- Add an olimex.txt file
- Change the compatible board string to 'olimex,imx23-olinuxino'
- Keep the board entry in imx23_dt_compat
Changes since v1:
- Drop "fsl,imx23-olinuxino" from mach-mxs.c

 Documentation/devicetree/bindings/arm/olimex.txt |    6 +++
 arch/arm/boot/dts/imx23-olinuxino.dts            |   44 ++++++++++++++++++++++
 arch/arm/boot/dts/imx23.dtsi                     |   14 +++++++
 arch/arm/mach-mxs/mach-mxs.c                     |    1 +
 4 files changed, 65 insertions(+), 0 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/arm/olimex.txt
 create mode 100644 arch/arm/boot/dts/imx23-olinuxino.dts
Documentation/devicetree/bindings/arm/olimex.txt new file +6 -0
new file mode 100644
index 0000000..007fb5c
@@ -0,0 +1,6 @@
+Olimex i.MX Platforms Device Tree Bindings
+------------------------------------------
+
+i.MX23 Olinuxino Low Cost Board
+Required root node properties:
+    - compatible = "olimex,imx23-olinuxino", "fsl,imx23";
arch/arm/boot/dts/imx23-olinuxino.dts new file +44 -0

44 lines not on this page · raw message

arch/arm/boot/dts/imx23.dtsi +14 -0
index 8c5f999..6fc3f54 100644
@@ -134,6 +134,20 @@
 					fsl,pinmux-ids = <0x2010 0x2060>;
 					fsl,pull-up = <0>;
 				};
+
+				mmc0_4bit_pins_a: mmc0-4bit at 0 {
+					reg = <0>;
+					fsl,pinmux-ids = <0x2000 0x2020 0x2030
+						0x2040 0x2050>;
+					fsl,drive-strength = <1>;
+					fsl,voltage = <1>;
+					fsl,pull-up = <1>;
+				};
+
+				mmc0_sck_cfg: mmc0_sck_cfg {
+					fsl,pinmux-ids = <0x2010>;
+					fsl,pull-up = <0>;
+				};
 			};
 
 			digctl at 8001c000 {
arch/arm/mach-mxs/mach-mxs.c +1 -0
index 8cac94b..a321753 100644
@@ -92,6 +92,7 @@ static void __init mxs_machine_init(void)
 
 static const char *imx23_dt_compat[] __initdata = {
 	"fsl,imx23-evk",
+	"olimex,imx23-olinuxino",
 	"fsl,imx23",
 	NULL,
 };
Signature · 1 line
1.7.1
#1 lore raw

PATCH v4 1/1 ARM: mx23: Add initial support for olinuxino board

Dear Fabio Estevam,

Quoted 13 lines

mx23-olinuxino is a low cost board designed by Olimex.

It has the following features:

- Freescale iMX233 ARM926J processor at 454MHz
-64 MB RAM

(quoted diff) +0 -6
-SD-card connector
-TV PAL/NTSC video output
-2 USB High Speed Hosts
-Ethernet 100 Mbit
-Stereo Audio Input
-Stereo Headphones Audio Output
Quoted 4 lines

More information at:
http://www.olimex.com/dev/imx233-olinuxino-maxi.html

Quoted 110 lines

---
Changes since v3:
- Fix the compatible string in imx23_dt_compat
Changes since v2:
- Add an olimex.txt file
- Change the compatible board string to 'olimex,imx23-olinuxino'
- Keep the board entry in imx23_dt_compat
Changes since v1:
- Drop "fsl,imx23-olinuxino" from mach-mxs.c

 Documentation/devicetree/bindings/arm/olimex.txt |    6 +++
 arch/arm/boot/dts/imx23-olinuxino.dts            |   44
++++++++++++++++++++++ arch/arm/boot/dts/imx23.dtsi                     | 
 14 +++++++
 arch/arm/mach-mxs/mach-mxs.c                     |    1 +
 4 files changed, 65 insertions(+), 0 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/arm/olimex.txt
 create mode 100644 arch/arm/boot/dts/imx23-olinuxino.dts
(quoted diff) +0 -0

b/Documentation/devicetree/bindings/arm/olimex.txt new file mode 100644 index 0000000..007fb5c

Documentation/devicetree/bindings/arm/olimex.txt new file +6 -0
@@ -0,0 +1,6 @@
+Olimex i.MX Platforms Device Tree Bindings
+------------------------------------------
+
+i.MX23 Olinuxino Low Cost Board
+Required root node properties:
+    - compatible = "olimex,imx23-olinuxino", "fsl,imx23";
(quoted diff) +0 -0

b/arch/arm/boot/dts/imx23-olinuxino.dts new file mode 100644 index 0000000..7abdd40

arch/arm/boot/dts/imx23-olinuxino.dts new file +44 -0
@@ -0,0 +1,44 @@
+/*
+ * Copyright 2012 Freescale Semiconductor, Inc.
+ *
+ * Author: Fabio Estevam <[email protected]>
+ *
+ * The code contained herein is licensed under the GNU General Public
+ * License. You may obtain a copy of the GNU General Public License
+ * Version 2 or later at the following locations:
+ *
+ * http://www.opensource.org/licenses/gpl-license.html
+ * http://www.gnu.org/copyleft/gpl.html
+ */
+
+/dts-v1/;
+/include/ "imx23.dtsi"
+
+/ {
+	model = "i.MX23 Olinuxino Low Cost Board";
+	compatible = "olimex,imx23-olinuxino", "fsl,imx23";
+
+	memory {
+		reg = <0x40000000 0x08000000>;
+	};
+
+	apb at 80000000 {
+		apbh at 80000000 {
+			ssp0: ssp at 80010000 {
+				compatible = "fsl,imx23-mmc";
+				pinctrl-names = "default";
+				pinctrl-0 = <&mmc0_4bit_pins_a &mmc0_sck_cfg>;
+				bus-width = <4>;
+				status = "okay";
+			};
+		};
+
+		apbx at 80040000 {
+			duart: serial at 80070000 {
+				pinctrl-names = "default";
+				pinctrl-0 = <&duart_pins_a>;
+				status = "okay";
+			};
+		};
+	};
+};
arch/arm/boot/dts/imx23.dtsi +14 -0
index 8c5f999..6fc3f54 100644
@@ -134,6 +134,20 @@
 					fsl,pinmux-ids = <0x2010 0x2060>;
 					fsl,pull-up = <0>;
 				};
+
+				mmc0_4bit_pins_a: mmc0-4bit at 0 {
+					reg = <0>;
+					fsl,pinmux-ids = <0x2000 0x2020 0x2030
+						0x2040 0x2050>;
+					fsl,drive-strength = <1>;
+					fsl,voltage = <1>;
+					fsl,pull-up = <1>;
+				};
+
+				mmc0_sck_cfg: mmc0_sck_cfg {
+					fsl,pinmux-ids = <0x2010>;
+					fsl,pull-up = <0>;
+				};
 			};
 
 			digctl at 8001c000 {
arch/arm/mach-mxs/mach-mxs.c +0 -0
index 8cac94b..a321753 100644

arch/arm/mach-mxs/mach-mxs.c static void __init mxs_machine_init(void) · line 98

Quoted 7 lines
arch/arm/mach-mxs/mach-mxs.c +1 -0
@@ -92,6 +92,7 @@ static void __init mxs_machine_init(void)
 
 static const char *imx23_dt_compat[] __initdata = {
 	"fsl,imx23-evk",
+	"olimex,imx23-olinuxino",
 	"fsl,imx23",
 	NULL,
 };

Best regards,
Marek Vasut

#2 lore raw

PATCH v4 1/1 ARM: mx23: Add initial support for olinuxino board

In reply to Fabio Estevam

Applied with a fix-up below.

Quoted 6 lines · Fabio Estevam

mx23-olinuxino is a low cost board designed by Olimex.

It has the following features:

- Freescale iMX233 ARM926J processor at 454MHz
-64 MB RAM

It says 64 MB ...

Quoted 58 lines
(quoted diff) +0 -6
-SD-card connector
-TV PAL/NTSC video output
-2 USB High Speed Hosts
-Ethernet 100 Mbit
-Stereo Audio Input
-Stereo Headphones Audio Output

More information at:
http://www.olimex.com/dev/imx233-olinuxino-maxi.html

---
Changes since v3:
- Fix the compatible string in imx23_dt_compat
Changes since v2:
- Add an olimex.txt file
- Change the compatible board string to 'olimex,imx23-olinuxino'
- Keep the board entry in imx23_dt_compat
Changes since v1:
- Drop "fsl,imx23-olinuxino" from mach-mxs.c

 Documentation/devicetree/bindings/arm/olimex.txt |    6 +++
 arch/arm/boot/dts/imx23-olinuxino.dts            |   44 ++++++++++++++++++++++
 arch/arm/boot/dts/imx23.dtsi                     |   14 +++++++
 arch/arm/mach-mxs/mach-mxs.c                     |    1 +
 4 files changed, 65 insertions(+), 0 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/arm/olimex.txt
 create mode 100644 arch/arm/boot/dts/imx23-olinuxino.dts
Documentation/devicetree/bindings/arm/olimex.txt new file +6 -0
new file mode 100644
index 0000000..007fb5c
@@ -0,0 +1,6 @@
+Olimex i.MX Platforms Device Tree Bindings
+------------------------------------------
+
+i.MX23 Olinuxino Low Cost Board
+Required root node properties:
+    - compatible = "olimex,imx23-olinuxino", "fsl,imx23";
arch/arm/boot/dts/imx23-olinuxino.dts new file +12 -0
new file mode 100644
index 0000000..7abdd40
@@ -0,0 +1,44 @@
+/*
+ * Copyright 2012 Freescale Semiconductor, Inc.
+ *
+ * Author: Fabio Estevam <[email protected]>
+ *
+ * The code contained herein is licensed under the GNU General Public
+ * License. You may obtain a copy of the GNU General Public License
+ * Version 2 or later at the following locations:
+ *
+ * http://www.opensource.org/licenses/gpl-license.html
+ * http://www.gnu.org/copyleft/gpl.html
+ */

arch/arm/boot/dts/imx23-olinuxino.dts line 22

Quoted 10 lines
arch/arm/boot/dts/imx23-olinuxino.dts new file +10 -0
+
+/dts-v1/;
+/include/ "imx23.dtsi"
+
+/ {
+	model = "i.MX23 Olinuxino Low Cost Board";
+	compatible = "olimex,imx23-olinuxino", "fsl,imx23";
+
+	memory {
+		reg = <0x40000000 0x08000000>;

... so I changed 0x080000000 to 0x04000000 here.

Regards,
Shawn

Quoted 63 lines
arch/arm/boot/dts/imx23-olinuxino.dts new file +22 -0
+	};
+
+	apb at 80000000 {
+		apbh at 80000000 {
+			ssp0: ssp at 80010000 {
+				compatible = "fsl,imx23-mmc";
+				pinctrl-names = "default";
+				pinctrl-0 = <&mmc0_4bit_pins_a &mmc0_sck_cfg>;
+				bus-width = <4>;
+				status = "okay";
+			};
+		};
+
+		apbx at 80040000 {
+			duart: serial at 80070000 {
+				pinctrl-names = "default";
+				pinctrl-0 = <&duart_pins_a>;
+				status = "okay";
+			};
+		};
+	};
+};
arch/arm/boot/dts/imx23.dtsi +14 -0
index 8c5f999..6fc3f54 100644
@@ -134,6 +134,20 @@
 					fsl,pinmux-ids = <0x2010 0x2060>;
 					fsl,pull-up = <0>;
 				};
+
+				mmc0_4bit_pins_a: mmc0-4bit at 0 {
+					reg = <0>;
+					fsl,pinmux-ids = <0x2000 0x2020 0x2030
+						0x2040 0x2050>;
+					fsl,drive-strength = <1>;
+					fsl,voltage = <1>;
+					fsl,pull-up = <1>;
+				};
+
+				mmc0_sck_cfg: mmc0_sck_cfg {
+					fsl,pinmux-ids = <0x2010>;
+					fsl,pull-up = <0>;
+				};
 			};
 
 			digctl at 8001c000 {
arch/arm/mach-mxs/mach-mxs.c +1 -0
index 8cac94b..a321753 100644
@@ -92,6 +92,7 @@ static void __init mxs_machine_init(void)
 
 static const char *imx23_dt_compat[] __initdata = {
 	"fsl,imx23-evk",
+	"olimex,imx23-olinuxino",
 	"fsl,imx23",
 	NULL,
 };
Signature · 1 line
1.7.1
#3 lore raw

PATCH v4 1/1 ARM: mx23: Add initial support for olinuxino board

In reply to Fabio Estevam
Quoted 4 lines · Fabio Estevam
arch/arm/boot/dts/imx23.dtsi +4 -0
+
+				mmc0_4bit_pins_a: mmc0-4bit at 0 {
+					reg = <0>;
+					fsl,pinmux-ids = <0x2000 0x2020 0x2030

arch/arm/boot/dts/imx23.dtsi line 150

Quoted 10 lines
arch/arm/boot/dts/imx23.dtsi +10 -0
+						0x2040 0x2050>;
+					fsl,drive-strength = <1>;
+					fsl,voltage = <1>;
+					fsl,pull-up = <1>;
+				};
+
+				mmc0_sck_cfg: mmc0_sck_cfg {
+					fsl,pinmux-ids = <0x2010>;
+					fsl,pull-up = <0>;
+				};

This looks suspicious. First of all, 0x2010 (SSP1_DETECT) should be in pinmux-ids of mmc0_4bit_pins_a. Secondly, SSP1_SCK seems missing from the pins. You do not have a SSP1_SCK pin for the mmc slot?

Signature · 2 lines
Regards,
Shawn
reviewer
#4 lore raw

PATCH v4 1/1 ARM: mx23: Add initial support for olinuxino board

Hi Shawn,

Quoted 11 lines · Shawn Guo
Quoted 10 lines · Fabio Estevam
(quoted diff) +10 -0
+
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? mmc0_4bit_pins_a: mmc0-4bit at 0 {
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? reg = <0>;
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? fsl,pinmux-ids = <0x2000 0x2020 0x2030
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? 0x2040 0x2050>;
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? fsl,drive-strength = <1>;
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? fsl,voltage = <1>;
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? fsl,pull-up = <1>;
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? };
+
Quoted 8 lines
Quoted 4 lines

+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? mmc0_sck_cfg: mmc0_sck_cfg {
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? fsl,pinmux-ids = <0x2010>;
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? fsl,pull-up = <0>;
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? };

This looks suspicious. ?First of all, 0x2010 (SSP1_DETECT) should be in pinmux-ids of mmc0_4bit_pins_a. ?Secondly, SSP1_SCK seems missing from the pins. ?You do not have a SSP1_SCK pin for the mmc slot?

Looks like the ROM code did the IOMUX setup of SSP1_SCK, so that's why it worked.

I will fix it. How do you want me to handle it? Via an incremental patch against your tree or should I post a new version of the patch?

Regards,

Fabio Estevam

#5 lore raw

PATCH v4 1/1 ARM: mx23: Add initial support for olinuxino board

Quoted 3 lines · Fabio Estevam

I will fix it. How do you want me to handle it? Via an incremental patch against your tree or should I post a new version of the patch?

Send me an incremental change, and I will amend it into the original one.

Signature · 2 lines
Regards,
Shawn
#6 lore raw

PATCH v4 1/1 ARM: mx23: Add initial support for olinuxino board

Quoted 6 lines · Shawn Guo
Quoted 3 lines · Fabio Estevam

I will fix it. How do you want me to handle it? Via an incremental patch against your tree or should I post a new version of the patch?

Send me an incremental change, and I will amend it into the original one.

Sorry, Fabio. I'm rebasing my for-next branch to back out the patch, so please send me a new version instead. Thanks.

Signature · 2 lines
Regards,
Shawn