Skip to contentSkip to conversation

x86: Aspire One Happy2 reboots only with the kbd method

PATCH In review Uros Vampl 4 participants 6 messages Jun 21, 2012 – Jan 1, 2013 x86

lore
Share & tools
lore

Uros Vampl

author
#0 lore raw

PATCH 1/1 x86: Aspire One Happy2 reboots only with the kbd method

Add a quirk to make the Acer Aspire One Happy2 reboot properly. For reference, discussion at the Arch forums:
https://bbs.archlinux.org/viewtopic.php?id=143716

arch/x86/kernel/reboot.c +8 -0
@@ -317,6 +317,14 @@
 			DMI_MATCH(DMI_PRODUCT_NAME, "AOA110"),
 		},
 	},
+	{ /* Handle reboot issue on Acer Aspire One Happy2 */
+		.callback = set_kbd_reboot,
+		.ident = "Acer Aspire One Happy2",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "AOHAPPY2"),
+		},
+	},
 	{ }
 };
 
Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Uros Vampl

Add a quirk to make the Acer Aspire One Happy2 reboot properly. For reference, discussion at the Arch forums:
https://bbs.archlinux.org/viewtopic.php?id=143716

Seems fine by me based on the thread above. Not sure if there is another callback that should be tried first before using BOOT_KBD. Probably doesn't matter.

Quoted 18 lines
arch/x86/kernel/reboot.c +8 -0
@@ -317,6 +317,14 @@
 			DMI_MATCH(DMI_PRODUCT_NAME, "AOA110"),
 		},
 	},
+	{ /* Handle reboot issue on Acer Aspire One Happy2 */
+		.callback = set_kbd_reboot,
+		.ident = "Acer Aspire One Happy2",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "AOHAPPY2"),
+		},
+	},
 	{ }
 };
 
#2 lore raw
Quoted 11 lines · Don Zickus
Quoted 5 lines · Uros Vampl

Add a quirk to make the Acer Aspire One Happy2 reboot properly. For reference, discussion at the Arch forums:
https://bbs.archlinux.org/viewtopic.php?id=143716

Seems fine by me based on the thread above. Not sure if there is another callback that should be tried first before using BOOT_KBD. Probably doesn't matter.

Actually please do the following:

a) please use "acpidump" (from the pmtools package) to dump the ACPI tables, specifically the FACP table;
b) please figure out which of reboot=pci, reboot=kbd, reboot=bios, and reboot=triple work on this platform.

-hpa

author
#3 lore raw
Quoted 13 lines · H. Peter Anvin
Quoted 11 lines · Don Zickus
Quoted 5 lines · Uros Vampl

Add a quirk to make the Acer Aspire One Happy2 reboot properly. For reference, discussion at the Arch forums:
https://bbs.archlinux.org/viewtopic.php?id=143716

Seems fine by me based on the thread above. Not sure if there is another callback that should be tried first before using BOOT_KBD. Probably doesn't matter.

Quoted 9 lines

Actually please do the following:

a) please use "acpidump" (from the pmtools package) to dump the ACPI tables, specifically the FACP table;
b) please figure out which of reboot=pci, reboot=kbd, reboot=bios, and reboot=triple work on this platform.

-hpa

I advised the Arch user to join this discussion and provide the requested info. I immediately went for kbd as the solution because that's exactly what I need for my own Aspire One - that AOA110 quirk that's visible in the context of this patch. I figured it's a pattern, Aspire One machines quirky in the same way.

Regards,
Uroš

#4 lore raw
Quoted 7 lines · Uros Vampl

I advised the Arch user to join this discussion and provide the requested info. I immediately went for kbd as the solution because that's exactly what I need for my own Aspire One - that AOA110 quirk that's visible in the context of this patch. I figured it's a pattern, Aspire One machines quirky in the same way.

Probably, but we'd like to figure out what is going on.

-hpa

Signature · 2 lines
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.
#5 lore raw
Quoted 10 lines · H. Peter Anvin <hpa <at> zytor.com> writes:
Quoted 7 lines · Uros Vampl

I advised the Arch user to join this discussion and provide the requested info. I immediately went for kbd as the solution because that's exactly what I need for my own Aspire One - that AOA110 quirk that's visible in the context of this patch. I figured it's a pattern, Aspire One machines quirky in the same way.

Quoted 4 lines

Probably, but we'd like to figure out what is going on.

-hpa

Hi. I got here from this forum https://bbs.archlinux.org/viewtopic.php?id=143716
with the same issue on the same device.

Here is FACP table from acpidump output:

FACP @ 0x7f5fd000

  0000: 46 41 43 50 f4 00 00 00 04 4c 41 43 52 53 59 53  FACP.....LACRSYS
  0010: 41 43 52 50 52 44 43 54 01 00 00 00 31 30 32 35  ACRPRDCT....1025
  0020: 00 00 04 00 00 30 58 7f 00 10 5f 7f 00 02 09 00  .....0X..._.....
  0030: b2 00 00 00 a0 a1 00 80 00 04 00 00 00 00 00 00  ................
  0040: 04 04 00 00 00 00 00 00 20 04 00 00 08 04 00 00  ........ .......
  0050: 28 04 00 00 00 00 00 00 04 02 01 04 08 00 00 85  (...............
  0060: 65 00 e9 03 00 00 00 00 01 03 0d 00 00 03 00 00  e...............
  0070: a5 84 00 00 01 08 00 01 b2 00 00 00 00 00 00 00  ................
  0080: fb 00 00 00 00 30 58 7f 00 00 00 00 00 10 5f 7f  .....0X......._.
  0090: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
  00a0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
  00b0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
  00c0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
  00d0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
  00e0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................

00f0: 00 00 00 00

I have tried to reboot with different kernel parameters.
Worked: kbd, efi, bios
Not worked: acpi, triple, pci

So, this patch works for me:

arch/x86/kernel/reboot.c +8 -0
@@ -447,6 +447,14 @@ 
 			DMI_MATCH(DMI_PRODUCT_NAME, "Precision M6600"),
 		},
 	},
+	{	/* Handle reboot issue on the Acer Aspire One Happy2. */
+		.callback = set_kbd_reboot,
+		.ident = "Acer Aspire One Happy2",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "AOHAPPY2"),
+		},
+	},
 	{ }
 };