memcg: replace unsigned long by u64 to avoid overflow
Subsystems (4)
PATCH v2 1/5 memcg: replace unsigned long by u64 to avoid overflow
Changlog:
V2 -> V1:
* fix zone_page_state()::/include/linux/vmstat.h returns 'unsigned long'
From: Wanpeng Li <[email protected]>
Since the return value variable in mem_cgroup_zone_nr_lru_pages and mem_cgroup_node_nr_lru_pages functions are u64, so replace the return value of funtions by u64 to avoid overflow.
--- include/linux/vmstat.h | 2 +- mm/memcontrol.c | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-)
include/linux/vmstat.h +1 -1
@@ -106,7 +106,7 @@ static inline unsigned long global_page_state(enum zone_stat_item item)return x; } -static inline unsigned long zone_page_state (struct zone *zone, +static inline u64 zone_page_state (struct zone *zone,enum zone_stat_item item) {long x =atomic_long_read (&zone->vm_stat[item]);
mm/memcontrol.c +2 -3
@@ -776,8 +776,7 @@ mem_cgroup_zone_nr_lru_pages(struct mem_cgroup *memcg, int nid, int zid,return ret; } -static unsigned long -mem_cgroup_node_nr_lru_pages (struct mem_cgroup *memcg, +static u64 mem_cgroup_node_nr_lru_pages (struct mem_cgroup *memcg,int nid,unsigned int lru_mask) {u64 total =0 ;
@@ -790,7 +789,7 @@ mem_cgroup_node_nr_lru_pages(struct mem_cgroup *memcg,return total; } -static unsigned long mem_cgroup_nr_lru_pages (struct mem_cgroup *memcg, +static u64 mem_cgroup_nr_lru_pages (struct mem_cgroup *memcg,unsigned int lru_mask) {int nid;
Signature · 1 line
1.7.9.5
Johannes Weiner
maintainerQuoted 22 lines · Wanpeng Li
Changlog:
V2 -> V1:
* fix zone_page_state()::/include/linux/vmstat.h returns 'unsigned long'From: Wanpeng Li <[email protected]>
Since the return value variable in
mem_cgroup_zone_nr_lru_pagesandmem_cgroup_node_nr_lru_pagesfunctions are u64, so replace the return value of funtions by u64 to avoid overflow.Signed-off-by Wanpeng Li <[email protected]>--- include/linux/vmstat.h | 2 +- mm/memcontrol.c | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-)include/linux/vmstat.h +0
-0
include/linux/vmstat.h static inline unsigned long global_page_state(enum zone_stat_item item) · line 112
Quoted 8 lines
include/linux/vmstat.h +1
-1@@ -106,7 +106,7 @@ static inline unsigned long global_page_state(enum zone_stat_item item)return x; } -static inline unsigned long zone_page_state (struct zone *zone, +static inline u64 zone_page_state (struct zone *zone,enum zone_stat_item item) {long x =atomic_long_read (&zone->vm_stat[item]);
We established that there is no known reason to use ulong for page counters and that IF YOU HAD ONE, you should obviously say so and then do a wholesale conversion. But I don't think you have one.
This patch makes absolutely no sense.
Quoted 36 lines · Johannes Weiner
Quoted 22 lines · Wanpeng Li
Changlog:
V2 -> V1:
* fix zone_page_state()::/include/linux/vmstat.h returns 'unsigned long'From: Wanpeng Li <[email protected]>
Since the return value variable in
mem_cgroup_zone_nr_lru_pagesandmem_cgroup_node_nr_lru_pagesfunctions are u64, so replace the return value of funtions by u64 to avoid overflow.Signed-off-by Wanpeng Li <[email protected]>--- include/linux/vmstat.h | 2 +- mm/memcontrol.c | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-)include/linux/vmstat.h +0
-0include/linux/vmstat.h static inline unsigned long global_page_state(enum zone_stat_item item) · line 112
Quoted 8 lines
include/linux/vmstat.h +1
-1@@ -106,7 +106,7 @@ static inline unsigned long global_page_state(enum zone_stat_item item)return x; } -static inline unsigned long zone_page_state (struct zone *zone, +static inline u64 zone_page_state (struct zone *zone,enum zone_stat_item item) {long x =atomic_long_read (&zone->vm_stat[item]);We established that there is no known reason to use ulong for page counters and that IF YOU HAD ONE, you should obviously say so and then do a wholesale conversion. But I don't think you have one.
Quoted 2 lines
This patch makes absolutely no sense.
I agree. Then, Nack from me.
Thanks,
-Kame
Quoted 37 lines · Kamezawa Hiroyuki
Quoted 36 lines · Johannes Weiner
Quoted 22 lines · Wanpeng Li
Changlog:
V2 -> V1:
* fix zone_page_state()::/include/linux/vmstat.h returns 'unsigned long'From: Wanpeng Li <[email protected]>
Since the return value variable in
mem_cgroup_zone_nr_lru_pagesandmem_cgroup_node_nr_lru_pagesfunctions are u64, so replace the return value of funtions by u64 to avoid overflow.Signed-off-by Wanpeng Li <[email protected]>--- include/linux/vmstat.h | 2 +- mm/memcontrol.c | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-)include/linux/vmstat.h +0
-0include/linux/vmstat.h static inline unsigned long global_page_state(enum zone_stat_item item) · line 112
Quoted 8 lines
include/linux/vmstat.h +1
-1@@ -106,7 +106,7 @@ static inline unsigned long global_page_state(enum zone_stat_item item)return x; } -static inline unsigned long zone_page_state (struct zone *zone, +static inline u64 zone_page_state (struct zone *zone,enum zone_stat_item item) {long x =atomic_long_read (&zone->vm_stat[item]);We established that there is no known reason to use ulong for page counters and that IF YOU HAD ONE, you should obviously say so and then do a wholesale conversion. But I don't think you have one.
Quoted 6 lines
Quoted 2 lines
This patch makes absolutely no sense.
I agree. Then, Nack from me.
Thanks,
-Kame
static unsigned long mem_cgroup_node_nr_lru_pages(struct mem_cgroup *memcg,
int nid, unsigned int lru_mask)
{
u64 total = 0;
int zid;
for (zid = 0; zid < MAX_NR_ZONES; zid++)
total += mem_cgroup_zone_nr_lru_pages(memcg,
nid, zid, lru_mask);
return total;
}Since you use unsigned long to caculate nr_pages and unsigned long long to caculate bytes, so u64 in function mem_cgroup_node_nr_lru_pages should replace by unsigned long to save kernel stack, right?
Regards,
Wanpeng Li
Quoted 2 lines
Quoted 59 lines · Wanpeng Li
Quoted 37 lines · Kamezawa Hiroyuki
Quoted 36 lines · Johannes Weiner
Quoted 22 lines · Wanpeng Li
Changlog:
V2 -> V1:
* fix zone_page_state()::/include/linux/vmstat.h returns 'unsigned long'From: Wanpeng Li <[email protected]>
Since the return value variable in
mem_cgroup_zone_nr_lru_pagesandmem_cgroup_node_nr_lru_pagesfunctions are u64, so replace the return value of funtions by u64 to avoid overflow.Signed-off-by Wanpeng Li <[email protected]>--- include/linux/vmstat.h | 2 +- mm/memcontrol.c | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-)include/linux/vmstat.h +0
-0include/linux/vmstat.h static inline unsigned long global_page_state(enum zone_stat_item item) · line 112
Quoted 8 lines
include/linux/vmstat.h +1
-1@@ -106,7 +106,7 @@ static inline unsigned long global_page_state(enum zone_stat_item item)return x; } -static inline unsigned long zone_page_state (struct zone *zone, +static inline u64 zone_page_state (struct zone *zone,enum zone_stat_item item) {long x =atomic_long_read (&zone->vm_stat[item]);We established that there is no known reason to use ulong for page counters and that IF YOU HAD ONE, you should obviously say so and then do a wholesale conversion. But I don't think you have one.
Quoted 6 lines
Quoted 2 lines
This patch makes absolutely no sense.
I agree. Then, Nack from me.
Thanks,
-Kamestatic unsigned long mem_cgroup_node_nr_lru_pages(struct
mem_cgroup*memcg,
int nid, unsigned intlru_mask){ u64 total = 0; int zid; for (zid = 0; zid < MAX_NR_ZONES; zid++) total += mem_cgroup_zone_nr_lru_pages(memcg, nid, zid, lru_mask); return total; }
Quoted 3 lines
Since you use unsigned long to caculate
nr_pagesand unsigned long long to caculate bytes, so u64 in functionmem_cgroup_node_nr_lru_pagesshould replace by unsigned long to save kernel stack, right?
How many bytes do you intend to save by replacing "u64" with "unsigned long" ? Have you asked yourself this question ?
Johannes Weiner
maintainerQuoted 60 lines · Glauber Costa
Quoted 59 lines · Wanpeng Li
Quoted 37 lines · Kamezawa Hiroyuki
Quoted 36 lines · Johannes Weiner
Quoted 22 lines · Wanpeng Li
Changlog:
V2 -> V1:
* fix zone_page_state()::/include/linux/vmstat.h returns 'unsigned long'From: Wanpeng Li <[email protected]>
Since the return value variable in
mem_cgroup_zone_nr_lru_pagesandmem_cgroup_node_nr_lru_pagesfunctions are u64, so replace the return value of funtions by u64 to avoid overflow.Signed-off-by Wanpeng Li <[email protected]>--- include/linux/vmstat.h | 2 +- mm/memcontrol.c | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-)include/linux/vmstat.h +0
-0include/linux/vmstat.h static inline unsigned long global_page_state(enum zone_stat_item item) · line 112
Quoted 8 lines
include/linux/vmstat.h +1
-1@@ -106,7 +106,7 @@ static inline unsigned long global_page_state(enum zone_stat_item item)return x; } -static inline unsigned long zone_page_state (struct zone *zone, +static inline u64 zone_page_state (struct zone *zone,enum zone_stat_item item) {long x =atomic_long_read (&zone->vm_stat[item]);We established that there is no known reason to use ulong for page counters and that IF YOU HAD ONE, you should obviously say so and then do a wholesale conversion. But I don't think you have one.
Quoted 6 lines
Quoted 2 lines
This patch makes absolutely no sense.
I agree. Then, Nack from me.
Thanks,
-Kamestatic unsigned long mem_cgroup_node_nr_lru_pages(struct
mem_cgroup*memcg,
int nid, unsigned intlru_mask){ u64 total = 0; int zid; for (zid = 0; zid < MAX_NR_ZONES; zid++) total += mem_cgroup_zone_nr_lru_pages(memcg, nid, zid, lru_mask); return total; }
Quoted 6 lines
Quoted 3 lines
Since you use unsigned long to caculate
nr_pagesand unsigned long long to caculate bytes, so u64 in functionmem_cgroup_node_nr_lru_pagesshould replace by unsigned long to save kernel stack, right?How many bytes do you intend to save by replacing "u64" with "unsigned long" ? Have you asked yourself this question ?
I think fixing these types is a good thing. Not for their memory savings but to clarify the code. Otherwise, people will scratch their heads and waste time over whether there is something that requires the counter to be 64-bit on a 32-bit system when really there isn't.
Quoted 65 lines · Johannes Weiner
Quoted 64 lines · Glauber Costa
Quoted 62 lines · Wanpeng Li
Quoted 37 lines · Kamezawa Hiroyuki
Quoted 36 lines · Johannes Weiner
Quoted 22 lines · Wanpeng Li
Changlog:
V2 -> V1:
* fix zone_page_state()::/include/linux/vmstat.h returns 'unsigned long'From: Wanpeng Li <[email protected]>
Since the return value variable in
mem_cgroup_zone_nr_lru_pagesandmem_cgroup_node_nr_lru_pagesfunctions are u64, so replace the return value of funtions by u64 to avoid overflow.Signed-off-by Wanpeng Li <[email protected]>--- include/linux/vmstat.h | 2 +- mm/memcontrol.c | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-)include/linux/vmstat.h +0
-0include/linux/vmstat.h static inline unsigned long global_page_state(enum zone_stat_item item) · line 112
Quoted 8 lines
include/linux/vmstat.h +1
-1@@ -106,7 +106,7 @@ static inline unsigned long global_page_state(enum zone_stat_item item)return x; } -static inline unsigned long zone_page_state (struct zone *zone, +static inline u64 zone_page_state (struct zone *zone,enum zone_stat_item item) {long x =atomic_long_read (&zone->vm_stat[item]);We established that there is no known reason to use ulong for page counters and that IF YOU HAD ONE, you should obviously say so and then do a wholesale conversion. But I don't think you have one.
Quoted 6 lines
Quoted 2 lines
This patch makes absolutely no sense.
I agree. Then, Nack from me.
Thanks,
-Kamestatic unsigned long mem_cgroup_node_nr_lru_pages(struct
mem_cgroup*memcg,
int nid, unsigned intlru_mask){ u64 total = 0; int zid; for (zid = 0; zid < MAX_NR_ZONES; zid++) total += mem_cgroup_zone_nr_lru_pages(memcg, nid, zid, lru_mask); return total; }Since you use unsigned long to caculate
nr_pagesand unsigned long long to caculate bytes, so u64 in functionmem_cgroup_node_nr_lru_pagesshould replace by unsigned long to save kernel stack, right?
Quoted 8 lines
Quoted 2 lines
How many bytes do you intend to save by replacing "u64" with "unsigned long" ? Have you asked yourself this question ?
I think fixing these types is a good thing. Not for their memory savings but to clarify the code. Otherwise, people will scratch their heads and waste time over whether there is something that requires the counter to be 64-bit on a 32-bit system when really there isn't.
I don't see a reason not to be type consistent, it's just not a stack issue at all. Being just a type fix, its benefits need to be offset against any problems it may bring, such as conflicts with other people working on that, risking doing a mid-term conversion that break something, and all the likes.