ARM: OMAP2+: fix naming collision of variable nr_irqs
Subsystems (4)
PATCH 1/2 ARM: OMAP2+: fix naming collision of variable nr_irqs
Using nr_irqs as local variable name triggers the sparse warning.. ./arch/arm/mach-omap2/irq.c:265:6: warning: symbol 'nr_irqs' shadows an earlier one ./linux/include/linux/irqnr.h:26:12: originally declared here
--- arch/arm/mach-omap2/irq.c | 8 ++++---- arch/arm/mach-omap2/prm_common.c | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-)
arch/arm/mach-omap2/irq.c +4 -4
@@ -262,7 +262,7 @@ int __init omap_intc_of_init(struct device_node *node, struct device_node *parent) {struct resource res; -u32 nr_irqs =96 ; +u32 nr_irq =96 ;if (WARN_ON (!node))return -ENODEV ;
@@ -272,10 +272,10 @@ int __init omap_intc_of_init(struct device_node *node,return -EINVAL ; } -if (of_property_read_u32 (node,"ti,intc-size" , &nr_irqs)) -pr_warn ("unable to get intc-size, default to %d\n" , nr_irqs); +if (of_property_read_u32 (node,"ti,intc-size" , &nr_irq)) +pr_warn ("unable to get intc-size, default to %d\n" , nr_irq); -omap_init_irq (res.start, nr_irqs,of_node_get (node)); +omap_init_irq (res.start, nr_irq,of_node_get (node));return 0 ; }
arch/arm/mach-omap2/prm_common.c +4 -4
@@ -85,7 +85,7 @@ static void omap_prcm_irq_handler(unsigned int irq, struct irq_desc *desc)unsigned long priority_pending[OMAP_PRCM_MAX_NR_PENDING_REG ];struct irq_chip *chip =irq_desc_get_chip (desc);unsigned int virtirq; -int nr_irqs = prcm_irq_setup->nr_regs *32 ; +int nr_irq = prcm_irq_setup->nr_regs *32 ;/* * If we are suspended, mask all interrupts from PRCM level,
@@ -110,7 +110,7 @@ static void omap_prcm_irq_handler(unsigned int irq, struct irq_desc *desc) prcm_irq_setup->read_pending_irqs (pending);/* No bit set, then all IRQs are handled */ -if (find_first_bit (pending, nr_irqs) >= nr_irqs) +if (find_first_bit (pending, nr_irq) >= nr_irq)break ;omap_prcm_events_filter_priority (pending, priority_pending);
@@ -121,11 +121,11 @@ static void omap_prcm_irq_handler(unsigned int irq, struct irq_desc *desc)*/ /* Serve priority events first */ -for_each_set_bit (virtirq, priority_pending, nr_irqs) +for_each_set_bit (virtirq, priority_pending, nr_irq)generic_handle_irq (prcm_irq_setup->base_irq + virtirq);/* Serve normal events next */ -for_each_set_bit (virtirq, pending, nr_irqs) +for_each_set_bit (virtirq, pending, nr_irq)generic_handle_irq (prcm_irq_setup->base_irq + virtirq); }if (chip->irq_ack)
Signature · 1 line
1.7.0.4
PATCH 2/2 ARM: OMAP2+: use proper type for keymap data in boardfiles.
This fixes the sparse warnings... arch/arm/mach-omap2/board-igep0020.c:482:14:
warning: incorrect type in initializer (different signedness)arch/arm/mach-omap2/board-4430sdp.c:200:14:
warning: incorrect type in initializer (different signedness)
--- arch/arm/mach-omap2/board-4430sdp.c | 2 +- arch/arm/mach-omap2/board-igep0020.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/mach-omap2/board-4430sdp.c +1 -1
@@ -64,7 +64,7 @@#define GPIO_WIFI_PMENA 54#define GPIO_WIFI_IRQ 53 -static const int sdp4430_keymap[] = { +static const uint32_t sdp4430_keymap[] = {KEY (0 ,0 ,KEY_E ),KEY (0 ,1 ,KEY_R ),KEY (0 ,2 ,KEY_T ),
arch/arm/mach-omap2/board-igep0020.c +1 -1
@@ -459,7 +459,7 @@ static struct platform_device *igep_devices[] __initdata = { &igep_vwlan_device, }; -static int igep2_keymap[] = { +static const uint32_t igep2_keymap[] = {KEY (0 ,0 ,KEY_LEFT ),KEY (0 ,1 ,KEY_RIGHT ),KEY (0 ,2 ,KEY_A ),
Signature · 1 line
1.7.0.4
Tony Lindgren
maintainerPATCH 1/2 ARM: OMAP2+: fix naming collision of variable nr_irqs
In reply to Venkatraman SQuoted 3 lines · Venkatraman S
Using
nr_irqsas local variable name triggers the sparse warning.../arch/arm/mach-omap2/irq.c:265:6: warning: symbol 'nr_irqs' shadows an earlier one./linux/include/linux/irqnr.h:26:12: originally declared here
Thanks applying both into fixes-non-critical.
Tony