Skip to contentSkip to conversation

fio 2.0.8 fails to build on mipsel

DISCUSSION Martin Steigerwald 4 participants 4 messages Jun 26, 2012 – Jun 28, 2012

lore
Share & tools
lore
#0 lore raw

Hi Jens!

Sven and I are currently trying to get fio 2.0.8 into Debian in time for Wheezy:

Building fails on mipsel due to¹:

    CC crc/sha256.o
    CC crc/sha512.o
    CC engines/cpu.o
    CC engines/mmap.o
    CC engines/sync.o
    CC engines/null.o
    CC engines/net.o
    CC memalign.o
    CC server.o

server.c: In function 'handle_probe_cmd':
server.c:411:15: error: 'arch_mips' undeclared (first use in this function) server.c:411:15: note: each undeclared identifier is reported only once for each function it appears in make[1]: *** [server.o] Error 1
make[1]: Leaving directory `/build/buildd-fio_2.0.8-1-mipsel-9VXitB/fio-2.0.8'
make: *** [build-stamp] Error 2

This happens in server.c:

397 static int handle_probe_cmd(struct fio_net_cmd *cmd) 398 {
399 struct cmd_probe_pdu probe;
400
401 dprint(FD_NET, "server: sending probe reply\n");
402
403 memset(&probe, 0, sizeof(probe));
404 gethostname((char *) probe.hostname, sizeof(probe.hostname));
405 #ifdef FIO_BIG_ENDIAN
406 probe.bigendian = 1;
407 #endif
408 strncpy((char *) probe.fio_version, fio_version_string, sizeof(probe.fio_version));
409

 410         probe.os        = FIO_OS;
 411         probe.arch      = FIO_ARCH;

412
413 probe.bpp = sizeof(void *);
414
415 return fio_net_send_cmd(server_fd, FIO_NET_CMD_PROBE, &probe, sizeof(probe), cmd->tag);
416 }

FIO_ARCH is defined to (arch_mips) in arch/arch-mips.h - any idea what might be going on here?

I'd like to include some patch to have it build on mipsel as well.

[1] https://buildd.debian.org/status/package.php?p=fio&suite=sid

Thanks,

Signature · 2 lines
Martin Steigerwald - teamix GmbH - http://www.teamix.de
gpg: 19E3 8D42 896F D004 08AC A0CA 1E10 C593 0399 AE90
#1 lore raw

On Tue, Jun 26, 2012 at 12:45:30PM +0200, Martin Steigerwald wrote:

Hi,

Quoted 9 lines

Building fails on mipsel due to�:

CC server.o
server.c: In function 'handle_probe_cmd':
server.c:411:15: error: 'arch_mips' undeclared (first use in this function) server.c:411:15: note: each undeclared identifier is reported only once for each function it appears in make[1]: *** [server.o] Error 1
make[1]: Leaving directory `/build/buildd-fio_2.0.8-1-mipsel-9VXitB/fio-2.0.8'
make: *** [build-stamp] Error 2

Adding arch_mips to the enum list at the top of arch/arch.h fixes the build issue, but I've no idea if that's the correct fix, regarding endianess issue etc. Tested on mipsel only, though the build failure happens on mips and mipsel.

Sven

Signature · 3 lines
And I don't know much, but I do know this:
With a golden heart comes a rebel fist.
     [ Streetlight Manifesto - Here's To Life ]
#2 lore raw
Quoted 15 lines · Sven Hoexter

On Tue, Jun 26, 2012 at 12:45:30PM +0200, Martin Steigerwald wrote:

Hi,

Quoted 9 lines

Building fails on mipsel due to�:

CC server.o
server.c: In function 'handle_probe_cmd':
server.c:411:15: error: 'arch_mips' undeclared (first use in this function) server.c:411:15: note: each undeclared identifier is reported only once for each function it appears in make[1]: *** [server.o] Error 1
make[1]: Leaving directory `/build/buildd-fio_2.0.8-1-mipsel-9VXitB/fio-2.0.8'
make: *** [build-stamp] Error 2

Quoted 4 lines

Adding arch_mips to the enum list at the top of arch/arch.h fixes the build issue, but I've no idea if that's the correct fix, regarding endianess issue etc. Tested on mipsel only, though the build failure happens on mips and mipsel.

It is the right fix, it just needs to have some value. Added.

Signature · 1 line
Jens Axboe
#3 lore raw

Am Dienstag, 26. Juni 2012 schrieb Jens Axboe:

Quoted 17 lines · Sven Hoexter
Quoted 16 lines · Martin Steigerwald

Hi,

Quoted 11 lines

Building fails on mipsel due to¹:
CC server.o

server.c: In function 'handle_probe_cmd':
server.c:411:15: error: 'arch_mips' undeclared (first use in this function) server.c:411:15: note: each undeclared identifier is reported only once for each function it appears in make[1]: *** [server.o] Error 1
make[1]: Leaving directory `/build/buildd-fio_2.0.8-1-mipsel-9VXitB/fio-2.0.8' make: *** [build-stamp] Error 2

Quoted 6 lines
Quoted 4 lines

Adding arch_mips to the enum list at the top of arch/arch.h fixes the build issue, but I've no idea if that's the correct fix, regarding endianess issue etc. Tested on mipsel only, though the build failure happens on mips and mipsel.

It is the right fix, it just needs to have some value. Added.

fio 2.0.8-2 with a build fix for mips/mipsel made it to Debian unstable.

If desired by myself or someone else I may consider backporting it to Squeeze after it has entered testing.

Thanks,

Signature · 2 lines
Martin 'Helios' Steigerwald - http://www.Lichtvoll.de
GPG: 03B0 0D6C 0040 0710 4AFA  B82F 991B EAAC A599 84C7