Skip to contentSkip to conversation

ARM: OMAP2+: do not allow SmartReflex to be built as a module

PATCH New Kevin Hilman 2 participants 2 messages Jun 28, 2012 – Jun 29, 2012

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: OMAP2+: do not allow SmartReflex to be built as a module

From: Jean Pihet <[email protected]>

Disable the module option for POWER_AVS since this is currently not supported.

This patch fixes these error in the case POWER_AVS is set to 'm':

arch/arm/mach-omap2/built-in.o: In function `sr_class3_configure':
/home/tmlind/src/linux-2.6/arch/arm/mach-omap2/smartreflex-class3.c:43: undefined reference to sr_configure_errgen' arch/arm/mach-omap2/built-in.o: In function sr_class3_disable':
/home/tmlind/src/linux-2.6/arch/arm/mach-omap2/smartreflex-class3.c:33: undefined reference to sr_disable_errgen' /home/tmlind/src/linux-2.6/arch/arm/mach-omap2/smartreflex-class3.c:35: undefined reference to sr_disable' arch/arm/mach-omap2/built-in.o: In function `sr_class3_enable':
/home/tmlind/src/linux-2.6/arch/arm/mach-omap2/smartreflex-class3.c:28: undefined reference to sr_enable' arch/arm/mach-omap2/built-in.o: In function sr_class3_init':
/home/tmlind/src/linux-2.6/arch/arm/mach-omap2/smartreflex-class3.c:59: undefined reference to `sr_register_class'

---
Tony, this one fixes the SR related build errors you saw with randconfig. It applies to my for_3.6/pm/sr-move branch which is now included in your devel-driver. Let me know if want me to fold this into the original and re-spin the branch.

Also, special thanks to Jean for fixing this immediatly after it was reported!

 drivers/power/avs/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/power/avs/Kconfig +1 -1
index 18493f7..2a1008b 100644
@@ -1,5 +1,5 @@
 menuconfig POWER_AVS
-	tristate "Adaptive Voltage Scaling class support"
+	bool "Adaptive Voltage Scaling class support"
 	help
 	  AVS is a power management technique which finely controls the
 	  operating voltage of a device in order to optimize (i.e. reduce)
Signature · 1 line
1.7.9.2
#1 lore raw

PATCH 1/1 ARM: OMAP2+: do not allow SmartReflex to be built as a module

Quoted 20 lines · Kevin Hilman

From: Jean Pihet <[email protected]>

Disable the module option for POWER_AVS since this is currently not supported.

This patch fixes these error in the case POWER_AVS is set to 'm':

arch/arm/mach-omap2/built-in.o: In function `sr_class3_configure':
/home/tmlind/src/linux-2.6/arch/arm/mach-omap2/smartreflex-class3.c:43: undefined reference to sr_configure_errgen' arch/arm/mach-omap2/built-in.o: In function sr_class3_disable':
/home/tmlind/src/linux-2.6/arch/arm/mach-omap2/smartreflex-class3.c:33: undefined reference to sr_disable_errgen' /home/tmlind/src/linux-2.6/arch/arm/mach-omap2/smartreflex-class3.c:35: undefined reference to sr_disable' arch/arm/mach-omap2/built-in.o: In function `sr_class3_enable':
/home/tmlind/src/linux-2.6/arch/arm/mach-omap2/smartreflex-class3.c:28: undefined reference to sr_enable' arch/arm/mach-omap2/built-in.o: In function sr_class3_init':
/home/tmlind/src/linux-2.6/arch/arm/mach-omap2/smartreflex-class3.c:59: undefined reference to `sr_register_class'

Quoted 8 lines

---
Tony, this one fixes the SR related build errors you saw with randconfig. It applies to my for_3.6/pm/sr-move branch which is now included in your devel-driver. Let me know if want me to fold this into the original and re-spin the branch.

Also, special thanks to Jean for fixing this immediatly after it was reported!

Thanks applying into devel-driver branch.

Tony