Skip to contentSkip to conversation

Add /var/www to device table

PATCH New spdawson at gmail.com 4 participants 5 messages Jun 25, 2012 – Jul 9, 2012

lore
Share & tools
lore

spdawson at gmail.com

author
#0 lore raw

PATCH 1/1 Add /var/www to device table

From: Simon Dawson <[email protected]>

The /var/www directory is listed in /etc/passwd in the skeleton target filesystem as the home directory of the www-data user (uid 33).

In the final target filesystem, /var/www should be owned by www-data. This is important for the lighttpd package, for example.

Signed-off-by Simon Dawson <[email protected]>
---
 target/generic/device_table.txt |    1 +
 1 file changed, 1 insertion(+)
target/generic/device_table.txt +1 -0
index fc397a9..421b357 100644
@@ -10,6 +10,7 @@
 /tmp					d	1777	0	0	-	-	-	-	-
 /etc					d	755	0	0	-	-	-	-	-
 /home/default				d	2755	1000	1000	-	-	-	-	-
+/var/www					d	755	33	33	-	-	-	-	-
 /etc/shadow				f	600	0	0	-	-	-	-	-
 /etc/passwd				f	644	0	0	-	-	-	-	-
 /etc/network/if-up.d			d	755	0	0	-	-	-	-	-
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 Add /var/www to device table

Quoted 9 lines · spdawson at gmail.com

From: Simon Dawson<[email protected]>

The /var/www directory is listed in /etc/passwd in the skeleton target filesystem as the home directory of the www-data user (uid 33).

In the final target filesystem, /var/www should be owned by www-data. This is important for the lighttpd package, for example.

Signed-off-by Simon Dawson<[email protected]>
Acked-by Arnout Vandecappelle (Essensium/Mind) <[email protected]>

There's a redundant tab in the /var/www line, however.

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#3 lore raw

PATCH 1/1 Add /var/www to device table

In reply to spdawson at gmail.com
Quoted 9 lines · spdawson at gmail.com

From: Simon Dawson <[email protected]>

The /var/www directory is listed in /etc/passwd in the skeleton target filesystem as the home directory of the www-data user (uid 33).

In the final target filesystem, /var/www should be owned by www-data. This is important for the lighttpd package, for example.

Signed-off-by Simon Dawson <[email protected]>

Shouldn't it be changed by using a LIGHTTPD_PERMISSIONS variable, instead of modifying the common device table ? This makes the relationship more evident.

See the following example:
---

package/lighttpd/lighttpd.mk +5 -0
index b8aa310..34f59b2 100644
@@ -62,4 +62,9 @@ define LIGHTTPD_UNINSTALL_TARGET_CMDS
 	rm -rf $(TARGET_DIR)/usr/lib/lighttpd
 endef
 
+#<name>		<type>	<mode>	<uid>	<gid>	<major>	<minor>	<start>	<inc>	<count>
+define LIGHTTPD_PERMISSIONS
+var/www		d	755	33	33	-	-	-	-	-
+endef
+
 $(eval $(call AUTOTARGETS))
Signature · 1 line
Romain Izard
#4 lore raw

PATCH 1/1 Add /var/www to device table

Le Mon, 2 Jul 2012 08:33:24 +0000 (UTC), Romain Izard <[email protected]> a ?crit :

Quoted 3 lines

Shouldn't it be changed by using a LIGHTTPD_PERMISSIONS variable, instead of modifying the common device table ? This makes the relationship more evident.

I think the point was that /var/www would not only be used by lighttpd, but also by other web servers, and packages installing Javascript stuff, etc.

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com