clk: wm831x: fix checkpatch issue for static const char * array
Subsystems (2)
PATCH 1/1 clk: wm831x: fix checkpatch issue for static const char * array
From: Barry Song <[email protected]>
static const char * array should probably be static const char * const
--- drivers/clk/clk-wm831x.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/clk/clk-wm831x.c +2 -2
@@ -177,7 +177,7 @@ static int wm831x_fll_set_rate(struct clk_hw *hw, unsigned long rate, WM831X_FLL_AUTO_FREQ_MASK, i); } -static const char *wm831x_fll_parents[] = { +static const char *const wm831x_fll_parents[] = {"xtal" ,"clkin" , };
@@ -298,7 +298,7 @@ static void wm831x_clkout_unprepare(struct clk_hw *hw)wm831x_reg_lock (wm831x); } -static const char *wm831x_clkout_parents[] = { +static const char *const wm831x_clkout_parents[] = {"xtal" ,"fll" , };
Signature · 6 lines
1.7.1 Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom More information can be found at www.csr.com. Follow CSR on Twitter at http://twitter.com/CSR_PLC and read our blog at www.csr.com/blog
PATCH 1/1 clk: wm831x: fix checkpatch issue for static const char * array
Quoted 3 lines · Barry Song
From: Barry Song <[email protected]>
static const char * array should probably be static const char * const
We need some additional clock API patches to get merged before this is
OK, last time I checked the API wasn't const correct enough for it.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120704/dc221aa9/attachment.sig>
PATCH 1/1 clk: wm831x: fix checkpatch issue for static const char * array
2012/7/4 Mark Brown <[email protected]>:
Quoted 8 lines · Barry Song
Quoted 3 lines
From: Barry Song <[email protected]>
static const char * array should probably be static const char * const
We need some additional clock API patches to get merged before this is OK, last time I checked the API wasn't const correct enough for it.
ok. also with this conflict: "warning: initialization discards qualifiers from pointer target type"
PATCH 1/1 clk: wm831x: fix checkpatch issue for static const char * array
Quoted 7 lines · Barry Song
2012/7/4 Mark Brown <[email protected]>:
Quoted 2 lines
We need some additional clock API patches to get merged before this is OK, last time I checked the API wasn't const correct enough for it.
ok. also with this conflict: "warning: initialization discards qualifiers from pointer target type"
Yes, that's the issue I'm referring to - we need the clock API to mark
the inputs it takes as const before we can have the drivers declare
thinngs const.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120706/76d0bdc0/attachment.sig>