ARM: OMAP2+: omap2plus_defconfig: EHCI driver is not stable, disable it
Subsystems (2)
PATCH 1/1 ARM: OMAP2+: omap2plus_defconfig: EHCI driver is not stable, disable it
The EHCI driver is not stable enough to be enabled by default. In v3.5, it has at least the following problems:
- warning dump during bootup
- hang during suspend
- prevents CORE powerdomain from entering retention during idle (even when no USB devices connected.)
This demonstrates that this driver has not been thoroughly tested and therfore should not be enabled in the default defconfig.
In addition, the problems above cause new PM regressions which need be addressed before this driver should be enabled in the default defconfig.
---
Tony, this applies to your current fixes branch. Please queue up for v3.5-rc
so this PM regression is fixed in v3.5. Thanks.
arch/arm/configs/omap2plus_defconfig | 1 - 1 file changed, 1 deletion(-)
arch/arm/configs/omap2plus_defconfig +0 -1
@@ -176,7 +176,6 @@ CONFIG_USB_ANNOUNCE_NEW_DEVICES=y CONFIG_USB_DEVICEFS=y CONFIG_USB_SUSPEND=y CONFIG_USB_MON=y -CONFIG_USB_EHCI_HCD=y CONFIG_USB_WDM=y CONFIG_USB_STORAGE=y CONFIG_USB_LIBUSUAL=y
Signature · 1 line
1.7.9.2
Tony Lindgren
maintainerPATCH 1/1 ARM: OMAP2+: omap2plus_defconfig: EHCI driver is not stable, disable it
Quoted 11 lines · Kevin Hilman
The EHCI driver is not stable enough to be enabled by default. In v3.5, it has at least the following problems:
- warning dump during bootup
- hang during suspend
- prevents CORE powerdomain from entering retention during idle (even when no USB devices connected.)This demonstrates that this driver has not been thoroughly tested and therfore should not be enabled in the default defconfig.
Quoted 8 lines
In addition, the problems above cause new PM regressions which need be addressed before this driver should be enabled in the default defconfig.
Signed-off-by Kevin Hilman <[email protected]>---
Tony, this applies to your current fixes branch. Please queue up for v3.5-rc
so this PM regression is fixed in v3.5. Thanks.
OK adding, although I don't like the idea of having to disable drivers in the defconfig to fix issues :( The hang during suspend case would be potentially hit by many people.. Should the driver/usb/host/ehci-omap.c be patched to disable suspend or at least warn about it?
Regards,
Tony
Quoted 22 lines
arch/arm/configs/omap2plus_defconfig | 1 - 1 file changed, 1 deletion(-)arch/arm/configs/omap2plus_defconfig +0
-1@@ -176,7 +176,6 @@ CONFIG_USB_ANNOUNCE_NEW_DEVICES=y CONFIG_USB_DEVICEFS=y CONFIG_USB_SUSPEND=y CONFIG_USB_MON=y -CONFIG_USB_EHCI_HCD=y CONFIG_USB_WDM=y CONFIG_USB_STORAGE=y CONFIG_USB_LIBUSUAL=ySignature · 6 lines
1.7.9.2 -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH 1/1 ARM: OMAP2+: omap2plus_defconfig: EHCI driver is not stable, disable it
Quoted 16 lines · Tony Lindgren
Quoted 15 lines · Kevin Hilman
The EHCI driver is not stable enough to be enabled by default. In v3.5, it has at least the following problems:
- warning dump during bootup
- hang during suspend
- prevents CORE powerdomain from entering retention during idle (even when no USB devices connected.)This demonstrates that this driver has not been thoroughly tested and therfore should not be enabled in the default defconfig.
In addition, the problems above cause new PM regressions which need be addressed before this driver should be enabled in the default defconfig.
Quoted 6 lines
Quoted 4 lines
Signed-off-by Kevin Hilman <[email protected]>---
Tony, this applies to your current fixes branch. Please queue up for v3.5-rc
so this PM regression is fixed in v3.5. Thanks.OK adding,
Thanks.
Quoted 2 lines
although I don't like the idea of having to disable drivers in the defconfig to fix issues :(
Neither do I, that's why I've been complaining about it since v3.5 came out so it would be properly addressed by the driver writers. It hasn't, so this is the last resort.
Quoted 3 lines
The hang during suspend case would
be potentially hit by many people.. Should thedriver/usb/host/ehci-omap.cbe patched to disable suspend or at least warn about it?
Russ Dill has posted fixes already for several of the problems, and Keshava has posted a revert, but I don't see them beling addressed for v3.5.
However, those fixes still don't address the CORE retention in idle issue which breaks PM for the whole SoC, so IMO this driver is still not ready to be enabled by default.
Kevin
PATCH 1/1 ARM: OMAP2+: omap2plus_defconfig: EHCI driver is not stable, disable it
In reply to Kevin HilmanQuoted 36 lines · Kevin Hilman
The EHCI driver is not stable enough to be enabled by default. In v3.5, it has at least the following problems:
- warning dump during bootup
- hang during suspend
- prevents CORE powerdomain from entering retention during idle (even when no USB devices connected.)This demonstrates that this driver has not been thoroughly tested and therfore should not be enabled in the default defconfig.
In addition, the problems above cause new PM regressions which need be addressed before this driver should be enabled in the default defconfig.
Signed-off-by Kevin Hilman <[email protected]>---
Tony, this applies to your current fixes branch. Please queue up for v3.5-rc
so this PM regression is fixed in v3.5. Thanks.arch/arm/configs/omap2plus_defconfig | 1 - 1 file changed, 1 deletion(-)arch/arm/configs/omap2plus_defconfig +0
-2@@ -176,7 +176,6 @@ CONFIG_USB_ANNOUNCE_NEW_DEVICES=y CONFIG_USB_DEVICEFS=y CONFIG_USB_SUSPEND=y CONFIG_USB_MON=y -CONFIG_USB_EHCI_HCD=y CONFIG_USB_WDM=y CONFIG_USB_STORAGE=y CONFIG_USB_LIBUSUAL=y --
Quoted 2 lines
1.7.9.2
hi Kevin
This patch is good. But , in my earlier patch I was disabling the
dependent configuration of ehci too.
- CONFIG_USB=y
- removes the usb host ( EHCI is the only host),
hence keeping it enabled with ehci does not make sense for
omap2 defconfig
-CONFIG_USB_DEBUG=y
- Enables the debug messages for usb host
-CONFIG_USB_ANNOUNCE_NEW_DEVICES=y
-CONFIG_USB_DEVICEFS=y
Announces the new devices attached to ehci; if usb
host it self is not there, then we dont need it.
-CONFIG_USB_SUSPEND=y
- suspend resume of usb host; not required if ehci
itself is not existing
-CONFIG_USB_MON=y
- usb monitor
-CONFIG_USB_WDM=y
-CONFIG_USB_STORAGE=y
-CONFIG_USB_LIBUSUAL=y
-CONFIG_USB_TEST=y
- usb storage and test ; again dependent on ehci only in
omap2plusdefconfig.
for omap build, if you disabling ehci , its good have not include these modules; yet including these modules does not harm anything.
regards
keshava