Skip to contentSkip to conversation

u-boot-usb/master

GIT PULL Applied Marek Vasut 2 participants 3 messages Jul 9, 2012 – Jul 10, 2012

lore
Share & tools
lore
#0 lore raw

Hello,

This has been in the usb tree for a while, but I'm hesitant to ask you for scheduling it into current release. On the other hand, I don't think this will cause any breakage.

The following changes since commit 58e22f8a15adec39d24d060180d76a4cbe86a04b:

fdt: send all dtc output to stderr (2012-07-09 09:05:24 +0200)

are available in the git repository at:

git://git.denx.de/u-boot-usb.git master

for you to fetch changes up to a4dae631bfa848d8a0d1933583ed7e2f6a96cab3:

CONFIG: EXYNOS5: USB: Enable USB 2.0 on smdk5250 (2012-07-09 18:27:55 +0200)

----------------------------------------------------------------
Rajeshwari Shinde (7):
USB: EXYNOS: Incorporate EHCI review comments
EXYNOS5: Fix system register structure
EXYNOS5: Add structure for PMU registers
USB: EXYNOS: Set USB 2.0 HOST Link mode
EXYNOS: Add power Enable/Disable for USB-EHCI
EXYNOS5: USB: Fix incorrect USB base addresses
CONFIG: EXYNOS5: USB: Enable USB 2.0 on smdk5250

 arch/arm/cpu/armv7/exynos/power.c                       |   22 +++
 arch/arm/cpu/armv7/exynos/system.c                      |   22 +++
 arch/arm/include/asm/arch-exynos/cpu.h                  |    7 +-
 arch/arm/include/asm/arch-exynos/{ehci-s5p.h => ehci.h} |   10 +-
 arch/arm/include/asm/arch-exynos/power.h                |  626 
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 arch/arm/include/asm/arch-exynos/system.h               |    4 +
 drivers/usb/host/Makefile                               |    2 +-
 drivers/usb/host/{ehci-s5p.c => ehci-exynos.c}          |   26 ++-
 include/configs/smdk5250.h                              |    6 +
 9 files changed, 708 insertions(+), 17 deletions(-)
 rename arch/arm/include/asm/arch-exynos/{ehci-s5p.h => ehci.h} (90%)
 rename drivers/usb/host/{ehci-s5p.c => ehci-exynos.c} (79%)

Best regards,
Marek Vasut

#1 lore raw

Dear Marek Vasut,

Quoted 28 lines · In message <[email protected]> you wrote:

Hello,

This has been in the usb tree for a while, but I'm hesitant to ask you for scheduling it into current release. On the other hand, I don't think this will cause any breakage.

The following changes since commit 58e22f8a15adec39d24d060180d76a4cbe86a04b:

fdt: send all dtc output to stderr (2012-07-09 09:05:24 +0200)

are available in the git repository at:

git://git.denx.de/u-boot-usb.git master

for you to fetch changes up to a4dae631bfa848d8a0d1933583ed7e2f6a96cab3:

CONFIG: EXYNOS5: USB: Enable USB 2.0 on smdk5250 (2012-07-09 18:27:55 +0200)

----------------------------------------------------------------
Rajeshwari Shinde (7):
USB: EXYNOS: Incorporate EHCI review comments
EXYNOS5: Fix system register structure
EXYNOS5: Add structure for PMU registers
USB: EXYNOS: Set USB 2.0 HOST Link mode
EXYNOS: Add power Enable/Disable for USB-EHCI
EXYNOS5: USB: Fix incorrect USB base addresses
CONFIG: EXYNOS5: USB: Enable USB 2.0 on smdk5250

Quoted 13 lines
 arch/arm/cpu/armv7/exynos/power.c                       |   22 +++
 arch/arm/cpu/armv7/exynos/system.c                      |   22 +++
 arch/arm/include/asm/arch-exynos/cpu.h                  |    7 +-
 arch/arm/include/asm/arch-exynos/{ehci-s5p.h => ehci.h} |   10 +-
 arch/arm/include/asm/arch-exynos/power.h                |  626 
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 arch/arm/include/asm/arch-exynos/system.h               |    4 +
 drivers/usb/host/Makefile                               |    2 +-
 drivers/usb/host/{ehci-s5p.c => ehci-exynos.c}          |   26 ++-
 include/configs/smdk5250.h                              |    6 +
 9 files changed, 708 insertions(+), 17 deletions(-)
 rename arch/arm/include/asm/arch-exynos/{ehci-s5p.h => ehci.h} (90%)
 rename drivers/usb/host/{ehci-s5p.c => ehci-exynos.c} (79%)

Applied, thanks.

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"I can call spirits from the vasty deep."
"Why so can I, or so can any man; but will they come when you do call
for them?"          - Shakespeare, 1 King Henry IV, Act III, Scene I.
#2 lore raw

Dear Marek, Vivek, Rajeshwari:

Quoted 15 lines · In message <[email protected]> I wrote:
Quoted 15 lines

for you to fetch changes up to a4dae631bfa848d8a0d1933583ed7e2f6a96cab3:

CONFIG: EXYNOS5: USB: Enable USB 2.0 on smdk5250 (2012-07-09 18:27:55 +0200)

----------------------------------------------------------------
Rajeshwari Shinde (7):
USB: EXYNOS: Incorporate EHCI review comments
EXYNOS5: Fix system register structure
EXYNOS5: Add structure for PMU registers
USB: EXYNOS: Set USB 2.0 HOST Link mode
EXYNOS: Add power Enable/Disable for USB-EHCI
EXYNOS5: USB: Fix incorrect USB base addresses
CONFIG: EXYNOS5: USB: Enable USB 2.0 on smdk5250

Quoted 13 lines
Quoted 5 lines
 arch/arm/cpu/armv7/exynos/power.c                       |   22 +++
 arch/arm/cpu/armv7/exynos/system.c                      |   22 +++
 arch/arm/include/asm/arch-exynos/cpu.h                  |    7 +-
 arch/arm/include/asm/arch-exynos/{ehci-s5p.h => ehci.h} |   10 +-
 arch/arm/include/asm/arch-exynos/power.h                |  626 
Quoted 8 lines

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

 arch/arm/include/asm/arch-exynos/system.h               |    4 +
 drivers/usb/host/Makefile                               |    2 +-
 drivers/usb/host/{ehci-s5p.c => ehci-exynos.c}          |   26 ++-
 include/configs/smdk5250.h                              |    6 +
 9 files changed, 708 insertions(+), 17 deletions(-)
 rename arch/arm/include/asm/arch-exynos/{ehci-s5p.h => ehci.h} (90%)
 rename drivers/usb/host/{ehci-s5p.c => ehci-exynos.c} (79%)

These patches break 5 ARM boards:

origen s5pc210_universal smdk5250 smdkv310 trats

For example:

Configuring for origen board...
text data bss dec hex filename
158893 3880 205648 368421 59f25 /work/wd/tmp-arm/u-boot
2332 0 0 2332 91c /work/wd/tmp-arm/spl/u-boot-spl
system.c: In function 'exynos5_set_usbhost_mode':
system.c:32:15: warning: unused variable 'phy_cfg' [-Wunused-variable] system.c: In function 'exynos5_set_usbhost_mode':
system.c:32:15: warning: unused variable 'phy_cfg' [-Wunused-variable]

Please fix.

Thanks.

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If there was anything that depressed him more than his own  cynicism,
it was that quite often it still wasn't as cynical as real life.
                                 - Terry Pratchett, _Guards! Guards!_